* [PATCH] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 @ 2023-03-11 12:34 Yaroslav Furman 2023-03-11 16:54 ` Alan Stern 0 siblings, 1 reply; 9+ messages in thread From: Yaroslav Furman @ 2023-03-11 12:34 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: yaro330, Alan Stern, linux-usb, usb-storage, linux-kernel Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them. Tested-and-reported-by: Yaroslav Furman <yaro330@gmail.com> Signed-off-by: Yaroslav Furman <yaro330@gmail.com> --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index c7b763d6d102..e4ff28ba93e5 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -97,6 +97,13 @@ UNUSUAL_DEV(0x152d, 0x0539, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_REPORT_OPCODES), +/* Reported by: Yaroslav Furman <yaro330@gmail.com> */ +UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999, + "JMicron", + "JMS583Gen 2", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES), + /* Reported-by: Claudio Bizzarri <claudio.bizzarri@gmail.com> */ UNUSUAL_DEV(0x152d, 0x0567, 0x0000, 0x9999, "JMicron", -- 2.39.2 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 2023-03-11 12:34 [PATCH] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 Yaroslav Furman @ 2023-03-11 16:54 ` Alan Stern 2023-03-11 17:12 ` [PATCH v2] " Yaroslav Furman 0 siblings, 1 reply; 9+ messages in thread From: Alan Stern @ 2023-03-11 16:54 UTC (permalink / raw) To: Yaroslav Furman; +Cc: Greg Kroah-Hartman, linux-usb, usb-storage, linux-kernel On Sat, Mar 11, 2023 at 02:34:18PM +0200, Yaroslav Furman wrote: > Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, > let's avoid them. > > Tested-and-reported-by: Yaroslav Furman <yaro330@gmail.com> > Signed-off-by: Yaroslav Furman <yaro330@gmail.com> > --- > drivers/usb/storage/unusual_uas.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index c7b763d6d102..e4ff28ba93e5 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -97,6 +97,13 @@ UNUSUAL_DEV(0x152d, 0x0539, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_NO_REPORT_OPCODES), > > +/* Reported by: Yaroslav Furman <yaro330@gmail.com> */ > +UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999, > + "JMicron", > + "JMS583Gen 2", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES), > + The new entry should be inserted in the correct location, according to the ordering by vendor ID and product ID. (Hint: 0x583 > 0x567.) > /* Reported-by: Claudio Bizzarri <claudio.bizzarri@gmail.com> */ > UNUSUAL_DEV(0x152d, 0x0567, 0x0000, 0x9999, > "JMicron", Alan Stern ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 2023-03-11 16:54 ` Alan Stern @ 2023-03-11 17:12 ` Yaroslav Furman 2023-03-12 6:52 ` Greg Kroah-Hartman 0 siblings, 1 reply; 9+ messages in thread From: Yaroslav Furman @ 2023-03-11 17:12 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: yaro330, Alan Stern, linux-usb, usb-storage, linux-kernel Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them. Signed-off-by: Yaroslav Furman <yaro330@gmail.com> --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index c7b763d6d102..1f8c9b16a0fb 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -111,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_BROKEN_FUA), +/* Reported by: Yaroslav Furman <yaro330@gmail.com> */ +UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999, + "JMicron", + "JMS583Gen 2", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES), + /* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */ UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999, "PNY", -- 2.39.2 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 2023-03-11 17:12 ` [PATCH v2] " Yaroslav Furman @ 2023-03-12 6:52 ` Greg Kroah-Hartman 2023-03-12 9:07 ` [PATCH v3] " Yaroslav Furman 2023-03-27 13:54 ` Yaroslav Furman 0 siblings, 2 replies; 9+ messages in thread From: Greg Kroah-Hartman @ 2023-03-12 6:52 UTC (permalink / raw) To: Yaroslav Furman; +Cc: Alan Stern, linux-usb, usb-storage, linux-kernel On Sat, Mar 11, 2023 at 07:12:26PM +0200, Yaroslav Furman wrote: > Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, > let's avoid them. > > Signed-off-by: Yaroslav Furman <yaro330@gmail.com> > --- > drivers/usb/storage/unusual_uas.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index c7b763d6d102..1f8c9b16a0fb 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -111,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_BROKEN_FUA), > > +/* Reported by: Yaroslav Furman <yaro330@gmail.com> */ > +UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999, > + "JMicron", > + "JMS583Gen 2", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > + US_FL_NO_REPORT_OPCODES), > + > /* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */ > UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999, > "PNY", > -- > 2.39.2 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 2023-03-12 6:52 ` Greg Kroah-Hartman @ 2023-03-12 9:07 ` Yaroslav Furman 2023-03-27 13:54 ` Yaroslav Furman 1 sibling, 0 replies; 9+ messages in thread From: Yaroslav Furman @ 2023-03-12 9:07 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: yaro330, Alan Stern, linux-usb, usb-storage, linux-kernel Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them. Signed-off-by: Yaroslav Furman <yaro330@gmail.com> --- V3: Moved the code in the appropriate place, after the 0x0578 device, as pointed out by Alan Stern --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index c7b763d6d102..1f8c9b16a0fb 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -111,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_BROKEN_FUA), +/* Reported by: Yaroslav Furman <yaro330@gmail.com> */ +UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999, + "JMicron", + "JMS583Gen 2", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES), + /* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */ UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999, "PNY", -- 2.39.2 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* (no subject) 2023-03-12 6:52 ` Greg Kroah-Hartman 2023-03-12 9:07 ` [PATCH v3] " Yaroslav Furman @ 2023-03-27 13:54 ` Yaroslav Furman 2023-03-27 13:54 ` [PATCH v3] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 Yaroslav Furman 2023-03-27 14:19 ` Greg Kroah-Hartman 1 sibling, 2 replies; 9+ messages in thread From: Yaroslav Furman @ 2023-03-27 13:54 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: yaro330, Alan Stern, linux-usb, usb-storage, linux-kernel Will this patch get ported to LTS trees? It applies cleanly. Would love to see it in 6.1 and 5.15 trees. 6.1 is what my steam deck is going to start using soon-ish. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 2023-03-27 13:54 ` Yaroslav Furman @ 2023-03-27 13:54 ` Yaroslav Furman 2023-03-27 16:52 ` Greg Kroah-Hartman 2023-03-27 14:19 ` Greg Kroah-Hartman 1 sibling, 1 reply; 9+ messages in thread From: Yaroslav Furman @ 2023-03-27 13:54 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: yaro330, Alan Stern, linux-usb, usb-storage, linux-kernel From: Yaroslav Furman <yaro330@gmail.com> Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, let's avoid them. Signed-off-by: Yaroslav Furman <yaro330@gmail.com> --- V3: Moved the code in the appropriate place, after the 0x0578 device, as pointed out by Alan Stern --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index c7b763d6d102..1f8c9b16a0fb 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -111,6 +111,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_BROKEN_FUA), +/* Reported by: Yaroslav Furman <yaro330@gmail.com> */ +UNUSUAL_DEV(0x152d, 0x0583, 0x0000, 0x9999, + "JMicron", + "JMS583Gen 2", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_NO_REPORT_OPCODES), + /* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */ UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999, "PNY", -- 2.39.2 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 2023-03-27 13:54 ` [PATCH v3] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 Yaroslav Furman @ 2023-03-27 16:52 ` Greg Kroah-Hartman 0 siblings, 0 replies; 9+ messages in thread From: Greg Kroah-Hartman @ 2023-03-27 16:52 UTC (permalink / raw) To: Yaroslav Furman; +Cc: Alan Stern, linux-usb, usb-storage, linux-kernel On Mon, Mar 27, 2023 at 04:54:23PM +0300, Yaroslav Furman wrote: > From: Yaroslav Furman <yaro330@gmail.com> > > Just like other JMicron JMS5xx enclosures, it chokes on report-opcodes, > let's avoid them. > > Signed-off-by: Yaroslav Furman <yaro330@gmail.com> > > --- > > V3: Moved the code in the appropriate place, after the 0x0578 device, > as pointed out by Alan Stern > --- > drivers/usb/storage/unusual_uas.h | 7 +++++++ > 1 file changed, 7 insertions(+) I'm confused, this is already in 6.3-rc4, right? thanks, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 2023-03-27 13:54 ` Yaroslav Furman 2023-03-27 13:54 ` [PATCH v3] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 Yaroslav Furman @ 2023-03-27 14:19 ` Greg Kroah-Hartman 1 sibling, 0 replies; 9+ messages in thread From: Greg Kroah-Hartman @ 2023-03-27 14:19 UTC (permalink / raw) To: Yaroslav Furman; +Cc: Alan Stern, linux-usb, usb-storage, linux-kernel On Mon, Mar 27, 2023 at 04:54:22PM +0300, Yaroslav Furman wrote: > > Will this patch get ported to LTS trees? It applies cleanly. > Would love to see it in 6.1 and 5.15 trees. What patch? confused, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-03-27 16:53 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-03-11 12:34 [PATCH] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 Yaroslav Furman 2023-03-11 16:54 ` Alan Stern 2023-03-11 17:12 ` [PATCH v2] " Yaroslav Furman 2023-03-12 6:52 ` Greg Kroah-Hartman 2023-03-12 9:07 ` [PATCH v3] " Yaroslav Furman 2023-03-27 13:54 ` Yaroslav Furman 2023-03-27 13:54 ` [PATCH v3] uas: Add US_FL_NO_REPORT_OPCODES for JMicron JMS583Gen 2 Yaroslav Furman 2023-03-27 16:52 ` Greg Kroah-Hartman 2023-03-27 14:19 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).