linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: clk: add documentation to log which clocks have been disabled
@ 2023-04-11 19:21 Brian Masney
  2023-04-20 16:15 ` Jonathan Corbet
  0 siblings, 1 reply; 2+ messages in thread
From: Brian Masney @ 2023-04-11 19:21 UTC (permalink / raw)
  To: corbet, sboyd; +Cc: linux-clk, linux-kernel, mturquette, linux-doc

The existing clk documentation has a section that talks about the
clk_ignore_unused kernel parameter. Add additional documentation that
describes how to log which clocks the kernel disables on bootup. This
will log messages like the following to the console on bootup:

    [    1.268115] clk: Disabling unused clocks
    [    1.272167] clk_disable: gcc_usb_clkref_en
    [    1.276389] clk_disable: gcc_usb30_sec_sleep_clk
    [    1.281131] clk_disable: gcc_usb30_prim_sleep_clk
    ...

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
 Documentation/driver-api/clk.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/driver-api/clk.rst b/Documentation/driver-api/clk.rst
index 3cad45d14187..2199c0042e75 100644
--- a/Documentation/driver-api/clk.rst
+++ b/Documentation/driver-api/clk.rst
@@ -258,6 +258,11 @@ clocks properly but rely on them being on from the bootloader, bypassing
 the disabling means that the driver will remain functional while the issues
 are sorted out.
 
+You can see which clocks have been disabled by booting your kernel with these
+parameters:
+
+ tp_printk trace_event=clk:clk_disable
+
 To bypass this disabling, include "clk_ignore_unused" in the bootargs to the
 kernel.
 
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] docs: clk: add documentation to log which clocks have been disabled
  2023-04-11 19:21 [PATCH] docs: clk: add documentation to log which clocks have been disabled Brian Masney
@ 2023-04-20 16:15 ` Jonathan Corbet
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2023-04-20 16:15 UTC (permalink / raw)
  To: Brian Masney, sboyd; +Cc: linux-clk, linux-kernel, mturquette, linux-doc

Brian Masney <bmasney@redhat.com> writes:

> The existing clk documentation has a section that talks about the
> clk_ignore_unused kernel parameter. Add additional documentation that
> describes how to log which clocks the kernel disables on bootup. This
> will log messages like the following to the console on bootup:
>
>     [    1.268115] clk: Disabling unused clocks
>     [    1.272167] clk_disable: gcc_usb_clkref_en
>     [    1.276389] clk_disable: gcc_usb30_sec_sleep_clk
>     [    1.281131] clk_disable: gcc_usb30_prim_sleep_clk
>     ...
>
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
>  Documentation/driver-api/clk.rst | 5 +++++
>  1 file changed, 5 insertions(+)

I've applied this, but...

> diff --git a/Documentation/driver-api/clk.rst b/Documentation/driver-api/clk.rst
> index 3cad45d14187..2199c0042e75 100644
> --- a/Documentation/driver-api/clk.rst
> +++ b/Documentation/driver-api/clk.rst
> @@ -258,6 +258,11 @@ clocks properly but rely on them being on from the bootloader, bypassing
>  the disabling means that the driver will remain functional while the issues
>  are sorted out.
>  
> +You can see which clocks have been disabled by booting your kernel with these
> +parameters:

...I took the liberty of making that "parameters::" so that the options
would be formatted as a literal block.

> + tp_printk trace_event=clk:clk_disable
> +
>  To bypass this disabling, include "clk_ignore_unused" in the bootargs to the
>  kernel.

Thanks,

jon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-20 16:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-11 19:21 [PATCH] docs: clk: add documentation to log which clocks have been disabled Brian Masney
2023-04-20 16:15 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).