[PATCH] pinctrl: amd: Don't show `Invalid config param` errors

[PATCH] pinctrl: amd: Don't show `Invalid config param` errors

[Mario Limonciello]

On some systems amd_pinconf_set() is called with parameters
0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
which are not supported by pinctrl-amd.

Don't show an err message when called with an invalid parameter,
downgrade this to debug instead.

Cc: stable@vger.kernel.org # 6.1
Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/pinctrl/pinctrl-amd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 4a8c1b57a90d6..20bd97a603d9c 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -748,7 +748,7 @@ static int amd_pinconf_get(struct pinctrl_dev *pctldev,
 		break;
 
 	default:
-		dev_err(&gpio_dev->pdev->dev, "Invalid config param %04x\n",
+		dev_dbg(&gpio_dev->pdev->dev, "Invalid config param %04x\n",
 			param);
 		return -ENOTSUPP;
 	}
@@ -798,7 +798,7 @@ static int amd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
 			break;
 
 		default:
-			dev_err(&gpio_dev->pdev->dev,
+			dev_dbg(&gpio_dev->pdev->dev,
 				"Invalid config param %04x\n", param);
 			ret = -ENOTSUPP;
 		}
-- 
2.34.1

Re: [PATCH] pinctrl: amd: Don't show `Invalid config param` errors

[Linus Walleij]

On Mon, Jul 17, 2023 at 10:17 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:

> On some systems amd_pinconf_set() is called with parameters
> 0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
> which are not supported by pinctrl-amd.
>
> Don't show an err message when called with an invalid parameter,
> downgrade this to debug instead.
>
> Cc: stable@vger.kernel.org # 6.1
> Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Applied for nonurgent fixes.

Yours,
Linus Walleij

Re: [PATCH] pinctrl: amd: Don't show `Invalid config param` errors

[Mario Limonciello]

On 7/23/2023 14:41, Linus Walleij wrote:
> On Mon, Jul 17, 2023 at 10:17 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
> 
>> On some systems amd_pinconf_set() is called with parameters
>> 0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
>> which are not supported by pinctrl-amd.
>>
>> Don't show an err message when called with an invalid parameter,
>> downgrade this to debug instead.
>>
>> Cc: stable@vger.kernel.org # 6.1
>> Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> Applied for nonurgent fixes.
> 

Just wanted to check if you'll be sending this out for -rc6.  It 
backported to stable and a few bugs cropped up because it's noisy.

Re: [PATCH] pinctrl: amd: Don't show `Invalid config param` errors

[Linus Walleij]

On Mon, Aug 7, 2023 at 8:17 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
> On 7/23/2023 14:41, Linus Walleij wrote:
> > On Mon, Jul 17, 2023 at 10:17 PM Mario Limonciello
> > <mario.limonciello@amd.com> wrote:
> >
> >> On some systems amd_pinconf_set() is called with parameters
> >> 0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
> >> which are not supported by pinctrl-amd.
> >>
> >> Don't show an err message when called with an invalid parameter,
> >> downgrade this to debug instead.
> >>
> >> Cc: stable@vger.kernel.org # 6.1
> >> Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
> >> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> >
> > Applied for nonurgent fixes.
> >
>
> Just wanted to check if you'll be sending this out for -rc6.  It
> backported to stable and a few bugs cropped up because it's noisy.

No, nonurgent means I queue it for v6.6. Fear of causing regressions
on mainline is the reason to not send fixes unless they are urgent.

Yours,
Linus Walleij

Re: [PATCH] pinctrl: amd: Don't show `Invalid config param` errors

[Mario Limonciello]

On 8/7/2023 15:45, Linus Walleij wrote:
> On Mon, Aug 7, 2023 at 8:17 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>> On 7/23/2023 14:41, Linus Walleij wrote:
>>> On Mon, Jul 17, 2023 at 10:17 PM Mario Limonciello
>>> <mario.limonciello@amd.com> wrote:
>>>
>>>> On some systems amd_pinconf_set() is called with parameters
>>>> 0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
>>>> which are not supported by pinctrl-amd.
>>>>
>>>> Don't show an err message when called with an invalid parameter,
>>>> downgrade this to debug instead.
>>>>
>>>> Cc: stable@vger.kernel.org # 6.1
>>>> Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
>>>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>>>
>>> Applied for nonurgent fixes.
>>>
>>
>> Just wanted to check if you'll be sending this out for -rc6.  It
>> backported to stable and a few bugs cropped up because it's noisy.
> 
> No, nonurgent means I queue it for v6.6. Fear of causing regressions
> on mainline is the reason to not send fixes unless they are urgent.
> 
> Yours,
> Linus Walleij

Understood, thanks.  I'll let reporters know to wait until 6.6 then for 
this particular fix.