From: Greg KH <gregkh@linuxfoundation.org>
To: Gairuboina Sirisha <sirisha.gairuboina@ltts.com>
Cc: linux-kernel@vger.kernel.org, lee@kernel.org, arnd@arndb.de
Subject: Re: [PATCH v1 2/3] drivers: mfd: Add support for TPS65224 i2c driver
Date: Fri, 27 Oct 2023 09:02:37 +0200 [thread overview]
Message-ID: <2023102713-jigsaw-straw-34f2@gregkh> (raw)
In-Reply-To: <20231026133226.290040-3-sirisha.gairuboina@Ltts.com>
On Thu, Oct 26, 2023 at 07:02:25PM +0530, Gairuboina Sirisha wrote:
> From: Gairuboina Sirisha <sirisha.gairuboina@ltts.com>
>
> Added MFD driver that enables I2C communication with and without CRC
>
> Signed-off-by: Gairuboina Sirisha <sirisha.gairuboina@ltts.com>
> ---
> drivers/mfd/Kconfig | 14 +++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/tps65224-i2c.c | 245 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 260 insertions(+)
> create mode 100644 drivers/mfd/tps65224-i2c.c
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 2e4906484eed..943d85d49fc5 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1767,12 +1767,26 @@ config MFD_TPS6594_SPI
>
> This driver can also be built as a module. If so, the module
> will be called tps6594-spi.
> +
That line should have been added in the first patch.
> config MFD_TPS65224
> tristate
> select MFD_CORE
> select REGMAP
> select REGMAP_IRQ
>
> +config MFD_TPS65224_I2C
> + tristate "TI TPS65224 Power Management chip with I2C"
> + select MFD_TPS65224
> + select REGMAP_I2C
> + select CRC8
> + depends on I2C
> + help
> + If you say yes here you get support for the TPS65224 series of
> + PM chips with I2C interface.
> +
> + This driver can also be built as a module. If so, the module
> + will be called tps65224-i2c.
> +
> config TWL4030_CORE
> bool "TI TWL4030/TWL5030/TWL6030/TPS659x0 Support"
> depends on I2C=y
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index ff4e158fa4db..4963fecd3e93 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -103,6 +103,7 @@ obj-$(CONFIG_MFD_TPS6594) += tps6594-core.o
> obj-$(CONFIG_MFD_TPS6594_I2C) += tps6594-i2c.o
> obj-$(CONFIG_MFD_TPS6594_SPI) += tps6594-spi.o
> obj-$(CONFIG_MFD_TPS65224) += tps65224-core.o
> +obj-$(CONFIG_MFD_TPS65224) += tps65224-i2c.o
> obj-$(CONFIG_MENELAUS) += menelaus.o
>
> obj-$(CONFIG_TWL4030_CORE) += twl-core.o twl4030-irq.o twl6030-irq.o
> diff --git a/drivers/mfd/tps65224-i2c.c b/drivers/mfd/tps65224-i2c.c
> new file mode 100644
> index 000000000000..c6300138ce4c
> --- /dev/null
> +++ b/drivers/mfd/tps65224-i2c.c
> @@ -0,0 +1,245 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * I2C access driver for TI TPS65224 PMIC
> + *
> + * Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com/
Again, check your copyright lines please.
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-27 7:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 13:32 [PATCH v1 0/3] TPS65224 PMIC driver Gairuboina Sirisha
2023-10-26 13:32 ` [PATCH v1 1/3] drivers: mfd: Add support for TPS65224 Gairuboina Sirisha
2023-10-27 7:02 ` Greg KH
2023-11-07 11:40 ` Gairuboina Sirisha
2023-10-26 13:32 ` [PATCH v1 2/3] drivers: mfd: Add support for TPS65224 i2c driver Gairuboina Sirisha
2023-10-27 7:02 ` Greg KH [this message]
2023-11-07 11:42 ` Gairuboina Sirisha
2023-10-27 8:08 ` Krzysztof Kozlowski
2023-11-07 11:50 ` Gairuboina Sirisha
2023-10-26 13:32 ` [PATCH v1 3/3] drivers: misc: Add support for TPS65224 pfsm driver Gairuboina Sirisha
2023-10-27 7:05 ` Greg KH
2023-11-07 11:44 ` Gairuboina Sirisha
2023-10-27 8:05 ` Krzysztof Kozlowski
2023-11-07 11:48 ` Gairuboina Sirisha
2023-11-03 8:52 ` [PATCH v1 0/3] TPS65224 PMIC driver Julien Panis
2023-11-07 11:37 ` Gairuboina Sirisha
2023-11-08 9:19 ` Julien Panis
2023-11-09 16:22 ` Shree Ramamoorthy
2023-11-10 4:26 ` Greg KH
2023-11-10 20:07 ` [EXTERNAL] " Shree Ramamoorthy
2023-11-17 11:05 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102713-jigsaw-straw-34f2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sirisha.gairuboina@ltts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).