From: Greg KH <gregkh@linuxfoundation.org>
To: Gairuboina Sirisha <sirisha.gairuboina@ltts.com>
Cc: linux-kernel@vger.kernel.org, lee@kernel.org, arnd@arndb.de
Subject: Re: [PATCH v1 1/3] drivers: mfd: Add support for TPS65224
Date: Fri, 27 Oct 2023 09:02:04 +0200 [thread overview]
Message-ID: <2023102739-absolve-coastal-6b4d@gregkh> (raw)
In-Reply-To: <20231026133226.290040-2-sirisha.gairuboina@Ltts.com>
On Thu, Oct 26, 2023 at 07:02:24PM +0530, Gairuboina Sirisha wrote:
> From: Gairuboina Sirisha <sirisha.gairuboina@ltts.com>
>
> Added support for tps65224 driver pmic core, header, Makefile and Kconfig
What is a "tps65224"? Please provide some more information so we know
how to review this.
>
> Signed-off-by: Gairuboina Sirisha <sirisha.gairuboina@ltts.com>
> ---
> drivers/mfd/Kconfig | 5 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/tps65224-core.c | 291 ++++++++++++++
> include/linux/mfd/tps65224.h | 735 +++++++++++++++++++++++++++++++++++
> 4 files changed, 1032 insertions(+)
> create mode 100644 drivers/mfd/tps65224-core.c
> create mode 100644 include/linux/mfd/tps65224.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 90ce58fd629e..2e4906484eed 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1767,6 +1767,11 @@ config MFD_TPS6594_SPI
>
> This driver can also be built as a module. If so, the module
> will be called tps6594-spi.
> +config MFD_TPS65224
You need a blank line before this, right?
> + tristate
> + select MFD_CORE
> + select REGMAP
> + select REGMAP_IRQ
No help text at all to describe what this is?
> --- /dev/null
> +++ b/drivers/mfd/tps65224-core.c
> @@ -0,0 +1,291 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Core functions for TI TPS65224 PMIC
> + *
> + * Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com/
No changes have happened since 2015 to this code?
> +EXPORT_SYMBOL_GPL(tps65224_device_init);
> +
> +MODULE_AUTHOR("Gairuboina Sirisha <sirisha.gairuboina@ltts.com>");
That dosn't match the copyright line :(
> --- /dev/null
> +++ b/include/linux/mfd/tps65224.h
Why do you need a .h file at all? This is just used in one .c file,
right?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-27 7:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 13:32 [PATCH v1 0/3] TPS65224 PMIC driver Gairuboina Sirisha
2023-10-26 13:32 ` [PATCH v1 1/3] drivers: mfd: Add support for TPS65224 Gairuboina Sirisha
2023-10-27 7:02 ` Greg KH [this message]
2023-11-07 11:40 ` Gairuboina Sirisha
2023-10-26 13:32 ` [PATCH v1 2/3] drivers: mfd: Add support for TPS65224 i2c driver Gairuboina Sirisha
2023-10-27 7:02 ` Greg KH
2023-11-07 11:42 ` Gairuboina Sirisha
2023-10-27 8:08 ` Krzysztof Kozlowski
2023-11-07 11:50 ` Gairuboina Sirisha
2023-10-26 13:32 ` [PATCH v1 3/3] drivers: misc: Add support for TPS65224 pfsm driver Gairuboina Sirisha
2023-10-27 7:05 ` Greg KH
2023-11-07 11:44 ` Gairuboina Sirisha
2023-10-27 8:05 ` Krzysztof Kozlowski
2023-11-07 11:48 ` Gairuboina Sirisha
2023-11-03 8:52 ` [PATCH v1 0/3] TPS65224 PMIC driver Julien Panis
2023-11-07 11:37 ` Gairuboina Sirisha
2023-11-08 9:19 ` Julien Panis
2023-11-09 16:22 ` Shree Ramamoorthy
2023-11-10 4:26 ` Greg KH
2023-11-10 20:07 ` [EXTERNAL] " Shree Ramamoorthy
2023-11-17 11:05 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102739-absolve-coastal-6b4d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sirisha.gairuboina@ltts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).