From: Gairuboina Sirisha <sirisha.gairuboina@Ltts.com>
To: jpanis@baylibre.com
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
linux-kernel@vger.kernel.org, sirisha.gairuboina@Ltts.com,
Gairuboina Sirisha <sirisha.gairuboina@ltts.com>
Subject: Re: [PATCH v1 0/3] TPS65224 PMIC driver
Date: Tue, 7 Nov 2023 17:07:40 +0530 [thread overview]
Message-ID: <20231107113740.1034738-1-sirisha.gairuboina@Ltts.com> (raw)
In-Reply-To: <b9449689-73da-41a8-a94e-f82686ab0bb0@baylibre.com>
From: Gairuboina Sirisha <sirisha.gairuboina@ltts.com>
> On 10/26/23 15:32, Gairuboina Sirisha wrote:
> > Added support for TPS65224 PMIC in linux.
> > This patch set includes driver for core, i2c and pfsm.
> > The driver was tested on TI's custom AM62A EVM.
> >
> > Gairuboina Sirisha (3):
> > drivers: mfd: Add support for TPS65224
> > drivers: mfd: Add support for TPS65224 i2c driver
> > drivers: misc: Add support for TPS65224 pfsm driver
> >
> > drivers/mfd/Kconfig | 19 +
> > drivers/mfd/Makefile | 2 +
> > drivers/mfd/tps65224-core.c | 291 ++++++++++++
> > drivers/mfd/tps65224-i2c.c | 245 ++++++++++
> > drivers/misc/Kconfig | 12 +
> > drivers/misc/Makefile | 1 +
> > drivers/misc/tps65224-pfsm.c | 290 ++++++++++++
> > include/linux/mfd/tps65224.h | 735 +++++++++++++++++++++++++++++
> > include/uapi/linux/tps65224_pfsm.h | 36 ++
> > 9 files changed, 1631 insertions(+)
> > create mode 100644 drivers/mfd/tps65224-core.c
> > create mode 100644 drivers/mfd/tps65224-i2c.c
> > create mode 100644 drivers/misc/tps65224-pfsm.c
> > create mode 100644 include/linux/mfd/tps65224.h
> > create mode 100644 include/uapi/linux/tps65224_pfsm.h
>
> Hi Sirisha,
>
> These drivers strongly look like TPS6594 drivers.
>
> Instead of submitting new drivers, you should consider reusing and
> modifying the existing ones for TPS6594. You might add your new 'compatible'
> entry ("ti,tps65224-q1") in TPS6594 dt-bindings (see 'ti,tps6594.yaml' file)
> to identify your TPS65224 PMIC. This new 'compatible' would also be added
> in the existing 'tps6594_i2c_of_match_table'. You can have a look at
> 'tps->chip_id' in 'tps6594-core.c' and see how we use it to deal with slight
> differences between different PMIC IDs.
Thanks for the response. While the TPS65224 drivers follow the format and
structure of TPS6594, the register maps, masks, and ADC feature differ.
The two PMICs have overlapping features but TPS65224 is not treated as a subset.
TPS65224 is treated as a separate and independent driver instead of adding
compatibility to the existing TPS6594 driver that would then support 3 PMICS.
This separation will better support our differing PMICs.
Thanks & Regards,
Sirisha G.
next prev parent reply other threads:[~2023-11-07 11:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 13:32 [PATCH v1 0/3] TPS65224 PMIC driver Gairuboina Sirisha
2023-10-26 13:32 ` [PATCH v1 1/3] drivers: mfd: Add support for TPS65224 Gairuboina Sirisha
2023-10-27 7:02 ` Greg KH
2023-11-07 11:40 ` Gairuboina Sirisha
2023-10-26 13:32 ` [PATCH v1 2/3] drivers: mfd: Add support for TPS65224 i2c driver Gairuboina Sirisha
2023-10-27 7:02 ` Greg KH
2023-11-07 11:42 ` Gairuboina Sirisha
2023-10-27 8:08 ` Krzysztof Kozlowski
2023-11-07 11:50 ` Gairuboina Sirisha
2023-10-26 13:32 ` [PATCH v1 3/3] drivers: misc: Add support for TPS65224 pfsm driver Gairuboina Sirisha
2023-10-27 7:05 ` Greg KH
2023-11-07 11:44 ` Gairuboina Sirisha
2023-10-27 8:05 ` Krzysztof Kozlowski
2023-11-07 11:48 ` Gairuboina Sirisha
2023-11-03 8:52 ` [PATCH v1 0/3] TPS65224 PMIC driver Julien Panis
2023-11-07 11:37 ` Gairuboina Sirisha [this message]
2023-11-08 9:19 ` Julien Panis
2023-11-09 16:22 ` Shree Ramamoorthy
2023-11-10 4:26 ` Greg KH
2023-11-10 20:07 ` [EXTERNAL] " Shree Ramamoorthy
2023-11-17 11:05 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107113740.1034738-1-sirisha.gairuboina@Ltts.com \
--to=sirisha.gairuboina@ltts.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jpanis@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).