From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] eventfsfs: initialize the tracefs inode properly
Date: Tue, 30 Jan 2024 14:56:55 -0500 [thread overview]
Message-ID: <20240130145655.073ff344@gandalf.local.home> (raw)
In-Reply-To: <20240130144802.6e1a8cf8@gandalf.local.home>
On Tue, 30 Jan 2024 14:48:02 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> The ti is allocated from fs/tracefs/inode.c that has:
>
> static struct inode *tracefs_alloc_inode(struct super_block *sb)
> {
> struct tracefs_inode *ti;
>
> ti = kmem_cache_alloc(tracefs_inode_cachep, GFP_KERNEL);
I could also just add __GFP_ZERO so that all of it is initialized to zero,
and then we don't need to assign NULL to any part of it.
-- Steve
> if (!ti)
> return NULL;
>
> ti->flags = 0;
>
> return &ti->vfs_inode;
> }
>
>
next prev parent reply other threads:[~2024-01-30 19:56 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 19:03 [PATCH 1/6] tracefs: avoid using the ei->dentry pointer unnecessarily Linus Torvalds
2024-01-30 19:03 ` [PATCH 2/6] eventfsfs: initialize the tracefs inode properly Linus Torvalds
2024-01-30 19:48 ` Steven Rostedt
2024-01-30 19:56 ` Steven Rostedt [this message]
2024-01-30 19:49 ` Steven Rostedt
2024-01-30 19:03 ` [PATCH 3/6] tracefs: dentry lookup crapectomy Linus Torvalds
2024-01-30 23:26 ` Al Viro
2024-01-30 23:55 ` Steven Rostedt
2024-01-31 0:07 ` Al Viro
2024-01-31 0:23 ` Al Viro
2024-01-31 0:39 ` Linus Torvalds
2024-01-30 19:03 ` [PATCH 4/6] eventfs: remove unused 'd_parent' pointer field Linus Torvalds
2024-01-30 19:03 ` [PATCH 5/6] eventfs: get rid of dentry pointers without refcounts Linus Torvalds
2024-01-30 20:55 ` Steven Rostedt
2024-01-30 21:52 ` Linus Torvalds
2024-01-30 22:56 ` Steven Rostedt
2024-01-30 22:58 ` Linus Torvalds
2024-01-30 23:04 ` Steven Rostedt
2024-01-30 22:56 ` Linus Torvalds
2024-01-30 23:06 ` Linus Torvalds
2024-01-30 23:10 ` Steven Rostedt
2024-01-30 23:25 ` Linus Torvalds
2024-01-31 0:48 ` Al Viro
2024-01-31 5:09 ` Steven Rostedt
2024-01-31 5:25 ` Linus Torvalds
2024-01-31 5:33 ` Steven Rostedt
2024-01-31 5:57 ` Linus Torvalds
2024-01-31 6:20 ` Linus Torvalds
2024-01-31 12:57 ` Steven Rostedt
2024-01-31 13:14 ` Steven Rostedt
2024-01-31 18:08 ` Linus Torvalds
2024-01-31 18:39 ` Steven Rostedt
2024-01-30 19:03 ` [PATCH 6/6] eventfs: clean up dentry ops and add revalidate function Linus Torvalds
2024-01-30 21:25 ` Steven Rostedt
2024-01-30 21:36 ` Linus Torvalds
2024-01-31 1:12 ` Al Viro
2024-01-31 2:37 ` Linus Torvalds
2024-01-31 2:46 ` Al Viro
2024-01-31 3:39 ` Linus Torvalds
2024-01-31 4:28 ` Al Viro
2024-01-31 18:00 ` Steven Rostedt
2024-01-31 23:07 ` Masami Hiramatsu
2024-01-31 23:23 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130145655.073ff344@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).