From: Linus Torvalds <torvalds@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] eventfs: get rid of dentry pointers without refcounts
Date: Tue, 30 Jan 2024 15:25:07 -0800 [thread overview]
Message-ID: <CAHk-=wgtX3aLPVLeSbyXEz7BGJGFbhXeH-788Nad=swajW72Wg@mail.gmail.com> (raw)
In-Reply-To: <20240130181057.278ac05c@gandalf.local.home>
On Tue, 30 Jan 2024 at 15:10, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > At which point a name pointer would *just* fit in 96 bytes.
>
> Does that mean I should keep the kstrdup_const()?
You should check that my math matches reality and relevant
configurations, but yes, at 96 bytes that should fit exactly in one
slab entry on both x86-64 and arm64 (now that arm finally does sane
kmalloc sizes - for the longest time they were all 128-byte aligned
due to historical horrible DMA coherency issues).
But you might also add a comment to the eventfs_inode definition,
because if that ever changes, the math changes again. For example,
adding just one more attribute data would make it all fall apart.
If you *really* want to optimize that data structure, I think you can
make the child list be a 'hlist'. That makes the list head ('children'
becomes a 'hlist_head') smaller, even if the list entry ('list'
becomes a 'hlist_node') stays the same size.
Linus
next prev parent reply other threads:[~2024-01-30 23:25 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 19:03 [PATCH 1/6] tracefs: avoid using the ei->dentry pointer unnecessarily Linus Torvalds
2024-01-30 19:03 ` [PATCH 2/6] eventfsfs: initialize the tracefs inode properly Linus Torvalds
2024-01-30 19:48 ` Steven Rostedt
2024-01-30 19:56 ` Steven Rostedt
2024-01-30 19:49 ` Steven Rostedt
2024-01-30 19:03 ` [PATCH 3/6] tracefs: dentry lookup crapectomy Linus Torvalds
2024-01-30 23:26 ` Al Viro
2024-01-30 23:55 ` Steven Rostedt
2024-01-31 0:07 ` Al Viro
2024-01-31 0:23 ` Al Viro
2024-01-31 0:39 ` Linus Torvalds
2024-01-30 19:03 ` [PATCH 4/6] eventfs: remove unused 'd_parent' pointer field Linus Torvalds
2024-01-30 19:03 ` [PATCH 5/6] eventfs: get rid of dentry pointers without refcounts Linus Torvalds
2024-01-30 20:55 ` Steven Rostedt
2024-01-30 21:52 ` Linus Torvalds
2024-01-30 22:56 ` Steven Rostedt
2024-01-30 22:58 ` Linus Torvalds
2024-01-30 23:04 ` Steven Rostedt
2024-01-30 22:56 ` Linus Torvalds
2024-01-30 23:06 ` Linus Torvalds
2024-01-30 23:10 ` Steven Rostedt
2024-01-30 23:25 ` Linus Torvalds [this message]
2024-01-31 0:48 ` Al Viro
2024-01-31 5:09 ` Steven Rostedt
2024-01-31 5:25 ` Linus Torvalds
2024-01-31 5:33 ` Steven Rostedt
2024-01-31 5:57 ` Linus Torvalds
2024-01-31 6:20 ` Linus Torvalds
2024-01-31 12:57 ` Steven Rostedt
2024-01-31 13:14 ` Steven Rostedt
2024-01-31 18:08 ` Linus Torvalds
2024-01-31 18:39 ` Steven Rostedt
2024-01-30 19:03 ` [PATCH 6/6] eventfs: clean up dentry ops and add revalidate function Linus Torvalds
2024-01-30 21:25 ` Steven Rostedt
2024-01-30 21:36 ` Linus Torvalds
2024-01-31 1:12 ` Al Viro
2024-01-31 2:37 ` Linus Torvalds
2024-01-31 2:46 ` Al Viro
2024-01-31 3:39 ` Linus Torvalds
2024-01-31 4:28 ` Al Viro
2024-01-31 18:00 ` Steven Rostedt
2024-01-31 23:07 ` Masami Hiramatsu
2024-01-31 23:23 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgtX3aLPVLeSbyXEz7BGJGFbhXeH-788Nad=swajW72Wg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).