From: Linus Torvalds <torvalds@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH 4/6] eventfs: remove unused 'd_parent' pointer field
Date: Tue, 30 Jan 2024 11:03:53 -0800 [thread overview]
Message-ID: <20240130190355.11486-4-torvalds@linux-foundation.org> (raw)
In-Reply-To: <20240130190355.11486-1-torvalds@linux-foundation.org>
It's never used
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
fs/tracefs/event_inode.c | 4 +---
fs/tracefs/internal.h | 2 --
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
index ad11063bdd53..1d0102bfd7da 100644
--- a/fs/tracefs/event_inode.c
+++ b/fs/tracefs/event_inode.c
@@ -685,10 +685,8 @@ struct eventfs_inode *eventfs_create_dir(const char *name, struct eventfs_inode
INIT_LIST_HEAD(&ei->list);
mutex_lock(&eventfs_mutex);
- if (!parent->is_freed) {
+ if (!parent->is_freed)
list_add_tail(&ei->list, &parent->children);
- ei->d_parent = parent->dentry;
- }
mutex_unlock(&eventfs_mutex);
/* Was the parent freed? */
diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
index 91c2bf0b91d9..8f38740bfb5b 100644
--- a/fs/tracefs/internal.h
+++ b/fs/tracefs/internal.h
@@ -35,7 +35,6 @@ struct eventfs_attr {
* @name: the name of the directory to create
* @children: link list into the child eventfs_inode
* @dentry: the dentry of the directory
- * @d_parent: pointer to the parent's dentry
* @d_children: The array of dentries to represent the files when created
* @entry_attrs: Saved mode and ownership of the @d_children
* @attr: Saved mode and ownership of eventfs_inode itself
@@ -50,7 +49,6 @@ struct eventfs_inode {
const char *name;
struct list_head children;
struct dentry *dentry; /* Check is_freed to access */
- struct dentry *d_parent;
struct dentry **d_children;
struct eventfs_attr *entry_attrs;
struct eventfs_attr attr;
--
2.43.0.5.g38fb137bdb
next prev parent reply other threads:[~2024-01-30 19:04 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 19:03 [PATCH 1/6] tracefs: avoid using the ei->dentry pointer unnecessarily Linus Torvalds
2024-01-30 19:03 ` [PATCH 2/6] eventfsfs: initialize the tracefs inode properly Linus Torvalds
2024-01-30 19:48 ` Steven Rostedt
2024-01-30 19:56 ` Steven Rostedt
2024-01-30 19:49 ` Steven Rostedt
2024-01-30 19:03 ` [PATCH 3/6] tracefs: dentry lookup crapectomy Linus Torvalds
2024-01-30 23:26 ` Al Viro
2024-01-30 23:55 ` Steven Rostedt
2024-01-31 0:07 ` Al Viro
2024-01-31 0:23 ` Al Viro
2024-01-31 0:39 ` Linus Torvalds
2024-01-30 19:03 ` Linus Torvalds [this message]
2024-01-30 19:03 ` [PATCH 5/6] eventfs: get rid of dentry pointers without refcounts Linus Torvalds
2024-01-30 20:55 ` Steven Rostedt
2024-01-30 21:52 ` Linus Torvalds
2024-01-30 22:56 ` Steven Rostedt
2024-01-30 22:58 ` Linus Torvalds
2024-01-30 23:04 ` Steven Rostedt
2024-01-30 22:56 ` Linus Torvalds
2024-01-30 23:06 ` Linus Torvalds
2024-01-30 23:10 ` Steven Rostedt
2024-01-30 23:25 ` Linus Torvalds
2024-01-31 0:48 ` Al Viro
2024-01-31 5:09 ` Steven Rostedt
2024-01-31 5:25 ` Linus Torvalds
2024-01-31 5:33 ` Steven Rostedt
2024-01-31 5:57 ` Linus Torvalds
2024-01-31 6:20 ` Linus Torvalds
2024-01-31 12:57 ` Steven Rostedt
2024-01-31 13:14 ` Steven Rostedt
2024-01-31 18:08 ` Linus Torvalds
2024-01-31 18:39 ` Steven Rostedt
2024-01-30 19:03 ` [PATCH 6/6] eventfs: clean up dentry ops and add revalidate function Linus Torvalds
2024-01-30 21:25 ` Steven Rostedt
2024-01-30 21:36 ` Linus Torvalds
2024-01-31 1:12 ` Al Viro
2024-01-31 2:37 ` Linus Torvalds
2024-01-31 2:46 ` Al Viro
2024-01-31 3:39 ` Linus Torvalds
2024-01-31 4:28 ` Al Viro
2024-01-31 18:00 ` Steven Rostedt
2024-01-31 23:07 ` Masami Hiramatsu
2024-01-31 23:23 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130190355.11486-4-torvalds@linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).