From: Jan Kara <jack@suse.cz>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] fs/writeback: only calculate dirtied_before when b_io is empty
Date: Fri, 23 Feb 2024 14:58:09 +0100 [thread overview]
Message-ID: <20240223135809.5bvyl7ex3zm6bnta@quack3> (raw)
In-Reply-To: <20240208172024.23625-6-shikemeng@huaweicloud.com>
On Fri 09-02-24 01:20:22, Kemeng Shi wrote:
> The dirtied_before is only used when b_io is not empty, so only calculate
> when b_io is not empty.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> ---
> fs/fs-writeback.c | 25 +++++++++++++------------
> 1 file changed, 13 insertions(+), 12 deletions(-)
OK, but please wrap the comment at 80 columns as well.
Honza
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index b61bf2075931..e8868e814e0a 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2118,20 +2118,21 @@ static long wb_writeback(struct bdi_writeback *wb,
>
> spin_lock(&wb->list_lock);
>
> - /*
> - * Kupdate and background works are special and we want to
> - * include all inodes that need writing. Livelock avoidance is
> - * handled by these works yielding to any other work so we are
> - * safe.
> - */
> - if (work->for_kupdate) {
> - dirtied_before = jiffies -
> - msecs_to_jiffies(dirty_expire_interval * 10);
> - } else if (work->for_background)
> - dirtied_before = jiffies;
> -
> trace_writeback_start(wb, work);
> if (list_empty(&wb->b_io)) {
> + /*
> + * Kupdate and background works are special and we want to
> + * include all inodes that need writing. Livelock avoidance is
> + * handled by these works yielding to any other work so we are
> + * safe.
> + */
> + if (work->for_kupdate) {
> + dirtied_before = jiffies -
> + msecs_to_jiffies(dirty_expire_interval *
> + 10);
> + } else if (work->for_background)
> + dirtied_before = jiffies;
> +
> queue_io(wb, work, dirtied_before);
> queued = true;
> }
> --
> 2.30.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-02-23 13:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 17:20 [PATCH 0/7] Fixes and cleanups to fs-writeback Kemeng Shi
2024-02-08 17:20 ` [PATCH 1/7] fs/writeback: avoid to writeback non-expired inode in kupdate writeback Kemeng Shi
2024-02-08 18:29 ` Tim Chen
2024-02-18 2:01 ` Kemeng Shi
2024-02-28 1:46 ` Kemeng Shi
2024-02-23 13:42 ` Jan Kara
2024-02-26 11:47 ` Kemeng Shi
2024-02-08 17:20 ` [PATCH 2/7] fs/writeback: bail out if there is no more inodes for IO and queued once Kemeng Shi
2024-02-08 19:21 ` Tim Chen
2024-02-18 2:11 ` Kemeng Shi
2024-02-23 13:49 ` Jan Kara
2024-02-08 17:20 ` [PATCH 3/7] fs/writeback: remove unused parameter wb of finish_writeback_work Kemeng Shi
2024-02-08 19:26 ` Tim Chen
2024-02-23 13:49 ` Jan Kara
2024-02-08 17:20 ` [PATCH 4/7] fs/writeback: remove unneeded check in writeback_single_inode Kemeng Shi
2024-02-08 19:34 ` Tim Chen
2024-02-10 0:46 ` Dave Chinner
2024-02-18 2:37 ` Kemeng Shi
2024-02-08 17:20 ` [PATCH 5/7] fs/writeback: only calculate dirtied_before when b_io is empty Kemeng Shi
2024-02-23 13:58 ` Jan Kara [this message]
2024-02-26 11:50 ` Kemeng Shi
2024-02-08 17:20 ` [PATCH 6/7] fs/writeback: correct comment of __wakeup_flusher_threads_bdi Kemeng Shi
2024-02-23 13:59 ` Jan Kara
2024-02-08 17:20 ` [PATCH 7/7] fs/writeback: remove unnecessary return in writeback_inodes_sb Kemeng Shi
2024-02-23 13:59 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223135809.5bvyl7ex3zm6bnta@quack3 \
--to=jack@suse.cz \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).