From: Kemeng Shi <shikemeng@huaweicloud.com>
To: Tim Chen <tim.c.chen@linux.intel.com>,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] fs/writeback: bail out if there is no more inodes for IO and queued once
Date: Sun, 18 Feb 2024 10:11:40 +0800 [thread overview]
Message-ID: <b79993fb-6413-4de7-a38f-c75a281d1762@huaweicloud.com> (raw)
In-Reply-To: <acc5ebbcd6a378b090d7ce56c47ed66fd1e0ccdc.camel@linux.intel.com>
on 2/9/2024 3:21 AM, Tim Chen wrote:
> On Fri, 2024-02-09 at 01:20 +0800, Kemeng Shi wrote:
>> For case there is no more inodes for IO in io list from last wb_writeback,
>> We may bail out early even there is inode in dirty list should be written
>> back. Only bail out when we queued once to avoid missing dirtied inode.
>>
>> This is from code reading...
>>
>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
>> ---
>> fs/fs-writeback.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
>> index a9a918972719..edb0cff51673 100644
>> --- a/fs/fs-writeback.c
>> +++ b/fs/fs-writeback.c
>> @@ -2086,6 +2086,7 @@ static long wb_writeback(struct bdi_writeback *wb,
>> struct inode *inode;
>> long progress;
>> struct blk_plug plug;
>> + bool queued = false;
>>
>> if (work->for_kupdate)
>> filter_expired_io(wb);
>> @@ -2131,8 +2132,10 @@ static long wb_writeback(struct bdi_writeback *wb,
>> dirtied_before = jiffies;
>>
>> trace_writeback_start(wb, work);
>> - if (list_empty(&wb->b_io))
>> + if (list_empty(&wb->b_io)) {
>> queue_io(wb, work, dirtied_before);
>> + queued = true;
>> + }
>> if (work->sb)
>> progress = writeback_sb_inodes(work->sb, wb, work);
>> else
>> @@ -2155,7 +2158,7 @@ static long wb_writeback(struct bdi_writeback *wb,
>> /*
>> * No more inodes for IO, bail
>> */
>> - if (list_empty(&wb->b_more_io)) {
>> + if (list_empty(&wb->b_more_io) && queued) {
>
> Wonder if we can simply do
> if (list_empty(&wb->b_more_io) && list_empty(&wb->b_io)) {
>
> if the intention is to not bail if there are still inodes to be be flushed.
I suppose not as there may be inodes in wb->b_dirty should be flushed.
For case that there is a inode in wb->b_io which is not flushed in last
wb_writeback and there are a lot of inodes in wb->dirty, the next background
flush is supposed to make dirty pages under threshold however only the inode
in wb->b_io is flushed.
>
> Tim
>
>> spin_unlock(&wb->list_lock);
>> break;
>> }
>
next prev parent reply other threads:[~2024-02-18 2:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 17:20 [PATCH 0/7] Fixes and cleanups to fs-writeback Kemeng Shi
2024-02-08 17:20 ` [PATCH 1/7] fs/writeback: avoid to writeback non-expired inode in kupdate writeback Kemeng Shi
2024-02-08 18:29 ` Tim Chen
2024-02-18 2:01 ` Kemeng Shi
2024-02-28 1:46 ` Kemeng Shi
2024-02-23 13:42 ` Jan Kara
2024-02-26 11:47 ` Kemeng Shi
2024-02-08 17:20 ` [PATCH 2/7] fs/writeback: bail out if there is no more inodes for IO and queued once Kemeng Shi
2024-02-08 19:21 ` Tim Chen
2024-02-18 2:11 ` Kemeng Shi [this message]
2024-02-23 13:49 ` Jan Kara
2024-02-08 17:20 ` [PATCH 3/7] fs/writeback: remove unused parameter wb of finish_writeback_work Kemeng Shi
2024-02-08 19:26 ` Tim Chen
2024-02-23 13:49 ` Jan Kara
2024-02-08 17:20 ` [PATCH 4/7] fs/writeback: remove unneeded check in writeback_single_inode Kemeng Shi
2024-02-08 19:34 ` Tim Chen
2024-02-10 0:46 ` Dave Chinner
2024-02-18 2:37 ` Kemeng Shi
2024-02-08 17:20 ` [PATCH 5/7] fs/writeback: only calculate dirtied_before when b_io is empty Kemeng Shi
2024-02-23 13:58 ` Jan Kara
2024-02-26 11:50 ` Kemeng Shi
2024-02-08 17:20 ` [PATCH 6/7] fs/writeback: correct comment of __wakeup_flusher_threads_bdi Kemeng Shi
2024-02-23 13:59 ` Jan Kara
2024-02-08 17:20 ` [PATCH 7/7] fs/writeback: remove unnecessary return in writeback_inodes_sb Kemeng Shi
2024-02-23 13:59 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b79993fb-6413-4de7-a38f-c75a281d1762@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).