* [PATCH 1/2] cpufreq: scpi: add thermal dependency
@ 2018-03-13 11:45 Arnd Bergmann
2018-03-13 11:45 ` [PATCH 2/2] cpufreq: scmi: " Arnd Bergmann
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-03-13 11:45 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar
Cc: Arnd Bergmann, Sudeep Holla, linux-pm, linux-kernel
A built-in scpi cpufreq driver cannot link against a modular
thermal framework:
drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_ready':
scpi-cpufreq.c:(.text+0x4c): undefined reference to `of_cpufreq_cooling_register'
drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_exit':
scpi-cpufreq.c:(.text+0x9c): undefined reference to `cpufreq_cooling_unregister'
This adds a Kconfig dependency that makes sure this configuration
is not possible, while allowing all configurations that can work.
Note that disabling CPU_THERMAL means we don't care about the
THERMAL dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/cpufreq/Kconfig.arm | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 9bbb5b39d18a..d9457d1e535c 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -45,6 +45,7 @@ config ARM_DT_BL_CPUFREQ
config ARM_SCPI_CPUFREQ
tristate "SCPI based CPUfreq driver"
depends on ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
+ depends on !CPU_THERMAL || THERMAL
help
This adds the CPUfreq driver support for ARM platforms using SCPI
protocol for CPU power management.
--
2.9.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] cpufreq: scmi: add thermal dependency
2018-03-13 11:45 [PATCH 1/2] cpufreq: scpi: add thermal dependency Arnd Bergmann
@ 2018-03-13 11:45 ` Arnd Bergmann
2018-03-13 14:09 ` Sudeep Holla
2018-03-14 5:10 ` Viresh Kumar
2018-03-13 14:06 ` [PATCH 1/2] cpufreq: scpi: " Sudeep Holla
2018-03-14 5:09 ` Viresh Kumar
2 siblings, 2 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-03-13 11:45 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar
Cc: Arnd Bergmann, Sudeep Holla, linux-pm, linux-kernel
A built-in scmi cpufreq driver cannot link against a modular
thermal framework:
drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_ready':
scmi-cpufreq.c:(.text+0x40): undefined reference to `of_cpufreq_cooling_register'
drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_exit':
scmi-cpufreq.c:(.text+0x88): undefined reference to `cpufreq_cooling_unregister'
This adds a Kconfig dependency that makes sure this configuration
is not possible, while allowing all configurations that can work.
Note that disabling CPU_THERMAL means we don't care about the
THERMAL dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/cpufreq/Kconfig.arm | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index d9457d1e535c..7f56fe5183f2 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -242,6 +242,7 @@ config ARM_SA1110_CPUFREQ
config ARM_SCMI_CPUFREQ
tristate "SCMI based CPUfreq driver"
depends on ARM_SCMI_PROTOCOL || COMPILE_TEST
+ depends on !CPU_THERMAL || THERMAL
select PM_OPP
help
This adds the CPUfreq driver support for ARM platforms using SCMI
--
2.9.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] cpufreq: scmi: add thermal dependency
2018-03-13 11:45 ` [PATCH 2/2] cpufreq: scmi: " Arnd Bergmann
@ 2018-03-13 14:09 ` Sudeep Holla
2018-03-13 14:27 ` Arnd Bergmann
2018-03-14 5:10 ` Viresh Kumar
1 sibling, 1 reply; 8+ messages in thread
From: Sudeep Holla @ 2018-03-13 14:09 UTC (permalink / raw)
To: Arnd Bergmann, Rafael J. Wysocki, Viresh Kumar
Cc: Sudeep Holla, linux-pm, linux-kernel
On 13/03/18 11:45, Arnd Bergmann wrote:
> A built-in scmi cpufreq driver cannot link against a modular
> thermal framework:
>
> drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_ready':
> scmi-cpufreq.c:(.text+0x40): undefined reference to `of_cpufreq_cooling_register'
> drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_exit':
> scmi-cpufreq.c:(.text+0x88): undefined reference to `cpufreq_cooling_unregister'
>
> This adds a Kconfig dependency that makes sure this configuration
> is not possible, while allowing all configurations that can work.
> Note that disabling CPU_THERMAL means we don't care about the
> THERMAL dependency.
>
This newly added entry is only in arm-soc linux-next. Let me know if you
want pull request with other possible fixes or you want to merge
directly as it might be need to suppress these errors in your build
system. For now I assume you will merge this directly in your tree, so
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] cpufreq: scmi: add thermal dependency
2018-03-13 14:09 ` Sudeep Holla
@ 2018-03-13 14:27 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2018-03-13 14:27 UTC (permalink / raw)
To: Sudeep Holla
Cc: Rafael J. Wysocki, Viresh Kumar, linux-pm, Linux Kernel Mailing List
On Tue, Mar 13, 2018 at 3:09 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>
>
> On 13/03/18 11:45, Arnd Bergmann wrote:
>> A built-in scmi cpufreq driver cannot link against a modular
>> thermal framework:
>>
>> drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_ready':
>> scmi-cpufreq.c:(.text+0x40): undefined reference to `of_cpufreq_cooling_register'
>> drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_exit':
>> scmi-cpufreq.c:(.text+0x88): undefined reference to `cpufreq_cooling_unregister'
>>
>> This adds a Kconfig dependency that makes sure this configuration
>> is not possible, while allowing all configurations that can work.
>> Note that disabling CPU_THERMAL means we don't care about the
>> THERMAL dependency.
>>
>
> This newly added entry is only in arm-soc linux-next. Let me know if you
> want pull request with other possible fixes or you want to merge
> directly as it might be need to suppress these errors in your build
> system. For now I assume you will merge this directly in your tree, so
>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
I've applied it into my next/drivers branch now. Thanks for the Ack.
I assume the cpufreq maintainers will pick up the other one. I'm not
sure why I didn't run into that problem earlier, but today I saw both
for the first time.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] cpufreq: scmi: add thermal dependency
2018-03-13 11:45 ` [PATCH 2/2] cpufreq: scmi: " Arnd Bergmann
2018-03-13 14:09 ` Sudeep Holla
@ 2018-03-14 5:10 ` Viresh Kumar
1 sibling, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2018-03-14 5:10 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Rafael J. Wysocki, Sudeep Holla, linux-pm, linux-kernel
On 13-03-18, 12:45, Arnd Bergmann wrote:
> A built-in scmi cpufreq driver cannot link against a modular
> thermal framework:
>
> drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_ready':
> scmi-cpufreq.c:(.text+0x40): undefined reference to `of_cpufreq_cooling_register'
> drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_exit':
> scmi-cpufreq.c:(.text+0x88): undefined reference to `cpufreq_cooling_unregister'
>
> This adds a Kconfig dependency that makes sure this configuration
> is not possible, while allowing all configurations that can work.
> Note that disabling CPU_THERMAL means we don't care about the
> THERMAL dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/cpufreq/Kconfig.arm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index d9457d1e535c..7f56fe5183f2 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -242,6 +242,7 @@ config ARM_SA1110_CPUFREQ
> config ARM_SCMI_CPUFREQ
> tristate "SCMI based CPUfreq driver"
> depends on ARM_SCMI_PROTOCOL || COMPILE_TEST
> + depends on !CPU_THERMAL || THERMAL
> select PM_OPP
> help
> This adds the CPUfreq driver support for ARM platforms using SCMI
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] cpufreq: scpi: add thermal dependency
2018-03-13 11:45 [PATCH 1/2] cpufreq: scpi: add thermal dependency Arnd Bergmann
2018-03-13 11:45 ` [PATCH 2/2] cpufreq: scmi: " Arnd Bergmann
@ 2018-03-13 14:06 ` Sudeep Holla
2018-03-14 5:09 ` Viresh Kumar
2 siblings, 0 replies; 8+ messages in thread
From: Sudeep Holla @ 2018-03-13 14:06 UTC (permalink / raw)
To: Arnd Bergmann, Rafael J. Wysocki, Viresh Kumar
Cc: Sudeep Holla, linux-pm, linux-kernel
On 13/03/18 11:45, Arnd Bergmann wrote:
> A built-in scpi cpufreq driver cannot link against a modular
> thermal framework:
>
> drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_ready':
> scpi-cpufreq.c:(.text+0x4c): undefined reference to `of_cpufreq_cooling_register'
> drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_exit':
> scpi-cpufreq.c:(.text+0x9c): undefined reference to `cpufreq_cooling_unregister'
>
> This adds a Kconfig dependency that makes sure this configuration
> is not possible, while allowing all configurations that can work.
> Note that disabling CPU_THERMAL means we don't care about the
> THERMAL dependency.
>
Makes sense,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] cpufreq: scpi: add thermal dependency
2018-03-13 11:45 [PATCH 1/2] cpufreq: scpi: add thermal dependency Arnd Bergmann
2018-03-13 11:45 ` [PATCH 2/2] cpufreq: scmi: " Arnd Bergmann
2018-03-13 14:06 ` [PATCH 1/2] cpufreq: scpi: " Sudeep Holla
@ 2018-03-14 5:09 ` Viresh Kumar
2018-03-22 23:27 ` Rafael J. Wysocki
2 siblings, 1 reply; 8+ messages in thread
From: Viresh Kumar @ 2018-03-14 5:09 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Rafael J. Wysocki, Sudeep Holla, linux-pm, linux-kernel
On 13-03-18, 12:45, Arnd Bergmann wrote:
> A built-in scpi cpufreq driver cannot link against a modular
> thermal framework:
>
> drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_ready':
> scpi-cpufreq.c:(.text+0x4c): undefined reference to `of_cpufreq_cooling_register'
> drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_exit':
> scpi-cpufreq.c:(.text+0x9c): undefined reference to `cpufreq_cooling_unregister'
>
> This adds a Kconfig dependency that makes sure this configuration
> is not possible, while allowing all configurations that can work.
> Note that disabling CPU_THERMAL means we don't care about the
> THERMAL dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/cpufreq/Kconfig.arm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 9bbb5b39d18a..d9457d1e535c 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -45,6 +45,7 @@ config ARM_DT_BL_CPUFREQ
> config ARM_SCPI_CPUFREQ
> tristate "SCPI based CPUfreq driver"
> depends on ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
> + depends on !CPU_THERMAL || THERMAL
> help
> This adds the CPUfreq driver support for ARM platforms using SCPI
> protocol for CPU power management.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] cpufreq: scpi: add thermal dependency
2018-03-14 5:09 ` Viresh Kumar
@ 2018-03-22 23:27 ` Rafael J. Wysocki
0 siblings, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2018-03-22 23:27 UTC (permalink / raw)
To: Viresh Kumar, Arnd Bergmann; +Cc: Sudeep Holla, linux-pm, linux-kernel
On Wednesday, March 14, 2018 6:09:54 AM CET Viresh Kumar wrote:
> On 13-03-18, 12:45, Arnd Bergmann wrote:
> > A built-in scpi cpufreq driver cannot link against a modular
> > thermal framework:
> >
> > drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_ready':
> > scpi-cpufreq.c:(.text+0x4c): undefined reference to `of_cpufreq_cooling_register'
> > drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_exit':
> > scpi-cpufreq.c:(.text+0x9c): undefined reference to `cpufreq_cooling_unregister'
> >
> > This adds a Kconfig dependency that makes sure this configuration
> > is not possible, while allowing all configurations that can work.
> > Note that disabling CPU_THERMAL means we don't care about the
> > THERMAL dependency.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/cpufreq/Kconfig.arm | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> > index 9bbb5b39d18a..d9457d1e535c 100644
> > --- a/drivers/cpufreq/Kconfig.arm
> > +++ b/drivers/cpufreq/Kconfig.arm
> > @@ -45,6 +45,7 @@ config ARM_DT_BL_CPUFREQ
> > config ARM_SCPI_CPUFREQ
> > tristate "SCPI based CPUfreq driver"
> > depends on ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
> > + depends on !CPU_THERMAL || THERMAL
> > help
> > This adds the CPUfreq driver support for ARM platforms using SCPI
> > protocol for CPU power management.
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-03-22 23:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-13 11:45 [PATCH 1/2] cpufreq: scpi: add thermal dependency Arnd Bergmann
2018-03-13 11:45 ` [PATCH 2/2] cpufreq: scmi: " Arnd Bergmann
2018-03-13 14:09 ` Sudeep Holla
2018-03-13 14:27 ` Arnd Bergmann
2018-03-14 5:10 ` Viresh Kumar
2018-03-13 14:06 ` [PATCH 1/2] cpufreq: scpi: " Sudeep Holla
2018-03-14 5:09 ` Viresh Kumar
2018-03-22 23:27 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).