From: Arnd Bergmann <arnd@arndb.de>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Timur Tabi <timur@codeaurora.org>,
dmaengine@vger.kernel.org,
Christopher Covington <cov@codeaurora.org>,
"jcm@redhat.com" <jcm@redhat.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/3] dma: add Qualcomm Technologies HIDMA management driver
Date: Mon, 02 Nov 2015 23:00:38 +0100 [thread overview]
Message-ID: <21289988.98iBsIZliz@wuerfel> (raw)
In-Reply-To: <5637B03F.9090905@codeaurora.org>
On Monday 02 November 2015 13:49:35 Sinan Kaya wrote:
> On 11/2/2015 12:42 PM, Rob Herring wrote:
> > Except I was suggesting not using 1.0 or 1.1. There is one main
> > exception and that is Xilinx blocks, but they are releasing versions
> > of blocks to customers. If "1.0" is not a well defined number, then
> > don't use that. I'd be surprised if any SOC vendor had such well
> > defined process around versioning of their IP blocks such that they
> > are well documented and guaranteed such that every change will change
> > the version.
>
> Here is one.
>
> I have two versions of the same IP. The first version in one chip has
> sw_version register that returns 1.0. The second version which has more
> capabilities has 1.1 in it.
>
> Is it OK to use?
>
> compatible="qcom,hidma-mgmt-1.0", "qcom,hidma-mgmt"
>
> for now and
>
> compatible="qcom,hidma-mgmt-1.1", "qcom,hidma-mgmt"
>
> later for the second chip? 1.1 is backwards compatible with 1.0 BTW.
I think this is fine. As they are backwards compatible, I would even make the
latter one
compatible = "qcom,hidma-mgmt-1.1", "qcom,hidma-mgmt-1.0", "qcom,hidma-mgmt";
> Since the same IP goes into multiple chips, why would you list the chip
> name here and submit patches multiple times for each single chip.
>
> or to follow what Timur did, I can do this.
>
> "qcom,qdf2xxx-hidma-mgmt-1.0"
>
> qdf2xxx would become the chip family.
We really don't want wildcards in here, but want to use the most specific
name you have for it, so we can add quirks to the driver later if it
turns out that they are not fully compatible after all.
Arnd
next prev parent reply other threads:[~2015-11-02 22:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446444460-21600-1-git-send-email-okaya@codeaurora.org>
2015-11-02 6:07 ` [PATCH V2 1/3] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya
2015-11-02 15:57 ` Rob Herring
2015-11-02 16:20 ` Sinan Kaya
2015-11-02 17:26 ` Timur Tabi
2015-11-02 17:42 ` Rob Herring
2015-11-02 17:48 ` Timur Tabi
2015-11-02 18:25 ` Rob Herring
2015-11-02 18:30 ` Timur Tabi
2015-11-05 14:31 ` Rob Herring
2015-11-05 14:43 ` Timur Tabi
2015-11-02 18:49 ` Sinan Kaya
2015-11-02 22:00 ` Arnd Bergmann [this message]
2015-11-03 5:18 ` Sinan Kaya
2015-11-03 10:22 ` Andy Shevchenko
2015-11-04 0:47 ` Sinan Kaya
2015-11-02 6:07 ` [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya
2015-11-03 4:15 ` Vinod Koul
2015-11-03 4:18 ` Sinan Kaya
2015-11-03 6:30 ` Vinod Koul
2015-11-03 7:44 ` Dan Williams
2015-11-03 8:22 ` Andy Shevchenko
2015-11-03 16:08 ` Vinod Koul
2015-11-05 2:42 ` Sinan Kaya
2015-11-05 12:05 ` Vinod Koul
2015-11-05 16:17 ` Sinan Kaya
2015-11-07 6:23 ` Sinan Kaya
2015-11-08 13:53 ` Vinod Koul
2015-11-13 20:20 ` okaya
2015-11-03 15:51 ` Sinan Kaya
2015-11-03 16:06 ` Vinod Koul
2015-11-03 14:31 ` Timur Tabi
2015-11-03 16:10 ` Vinod Koul
2015-11-03 16:28 ` Sinan Kaya
2015-11-03 16:46 ` Timur Tabi
2015-11-03 16:57 ` Sinan Kaya
2015-11-03 16:48 ` Timur Tabi
2015-11-02 6:07 ` [PATCH V2 3/3] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya
2015-11-03 10:10 ` Andy Shevchenko
2015-11-04 0:07 ` Sinan Kaya
2015-11-04 17:44 ` Andy Shevchenko
2015-11-05 2:22 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21289988.98iBsIZliz@wuerfel \
--to=arnd@arndb.de \
--cc=cov@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jcm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=okaya@codeaurora.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=timur@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).