linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Joe Perches <joe@perches.com>,
	linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org
Cc: "Andrew F. Davis" <afd@ti.com>,
	Arvind Yadav <arvind.yadav.cs@gmail.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Ladislav Michl <ladis@linux-mips.org>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions
Date: Sun, 3 Dec 2017 19:20:47 +0100	[thread overview]
Message-ID: <21554e23-e714-3f6f-cd70-4c277823bab3@users.sourceforge.net> (raw)
In-Reply-To: <1511856244.19952.14.camel@perches.com>

> How many times have I told you to include the reason for your patches
> in your proposed commit message?

Will it be useful to look again at the involved circumstances?


> Too often.

Did I answer any concerns partly?


> Many people do not know that a generic kmalloc does a dump_stack() on OOM.

Do you see a need to represent such information better?

Is it expected that the function “devm_kzalloc” has got a similar property?


> That information should be part of the commit message.

How do you think about to share it also from any reference documentation
in a clearer way?

Do we stumble on a target conflict in this case?

I am generally trying to improve the software situation to some degree.
I prefer then to work with safe information sources.
Unfortunately, I might have not reached a desired confidence level here
for a more detailed commit message. I assume that software development
efforts could increase in significant ways if something should be improved
further in a direction I hope. But this could mean that time frames will
grow for corresponding clarifications.

* Does such a situation block progress on the deletion of other remaining
  questionable error messages?

* Would you like to increase the software development attention anyhow?



By the way:
It seems that my update suggestion for the directory “omapfb/dss”
could be superseded by the patch “omapfb: dss: Do not duplicate features data”
from Ladislav Michl.
https://patchwork.kernel.org/patch/10082027/
https://lkml.kernel.org/r/<20171129123308.GA26578@lenoch>

Regards,
Markus

      parent reply	other threads:[~2017-12-03 18:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-26 18:55 [PATCH] omapfb/dss: Delete an error message for a failed memory allocation in three functions SF Markus Elfring
2017-11-27 16:43 ` Andrew F. Davis
2017-11-27 17:27   ` SF Markus Elfring
2017-11-27 17:44     ` Ladislav Michl
2017-11-27 18:12       ` SF Markus Elfring
2017-11-27 18:56         ` Geert Uytterhoeven
2017-11-27 19:22         ` Ladislav Michl
2017-11-27 22:20           ` Ladislav Michl
2017-11-27 19:07   ` [PATCH] " Joe Perches
2017-11-27 21:33     ` Andrew F. Davis
2017-11-27 21:45       ` Ladislav Michl
2017-11-27 21:48     ` SF Markus Elfring
2017-11-28  1:45       ` Joe Perches
2017-11-28  7:41         ` SF Markus Elfring
2017-11-28  7:49           ` Julia Lawall
2017-11-28  8:49             ` SF Markus Elfring
2017-11-28  9:26               ` Julia Lawall
2017-11-28  9:56                 ` SF Markus Elfring
2017-11-28  8:04           ` Joe Perches
2017-11-28  8:49             ` Ladislav Michl
2017-11-28  9:11             ` SF Markus Elfring
2017-11-28  9:28               ` Julia Lawall
2017-11-28 10:15                 ` SF Markus Elfring
2017-11-28 10:23                   ` Ladislav Michl
2017-11-28 10:50                     ` SF Markus Elfring
2017-11-28 11:41                       ` Ladislav Michl
2017-11-28 12:13                         ` SF Markus Elfring
2017-11-28 17:50                           ` Ladislav Michl
2017-11-28 18:09                             ` SF Markus Elfring
2017-11-28 14:36                     ` Joe Perches
2017-12-03 18:20             ` SF Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21554e23-e714-3f6f-cd70-4c277823bab3@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=afd@ti.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=ladis@linux-mips.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).