Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Ladislav Michl <ladis@linux-mips.org>,
	linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Cc: "Andrew F. Davis" <afd@ti.com>,
	Arvind Yadav <arvind.yadav.cs@gmail.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions
Date: Mon, 27 Nov 2017 19:12:50 +0100	[thread overview]
Message-ID: <5e90409f-fcb0-cdb6-9bc3-26ad30a1f7c9@users.sourceforge.net> (raw)
In-Reply-To: <20171127174454.GA18851@lenoch>

>> Can a default allocation failure report provide the information
>> which you might expect so far?
> 
> You should be able to answer that question yourself.

I can not answer this detail completely myself because my knowledge
is incomplete about your concrete expectations for the exception handling
which can lead to different views for the need of additional error messages.

> And if you are unable to do so, just do not sent changes pointed
> by any code analysis tools.

They can point aspects out for further software development considerations,
can't they?

> As a side note, if you look at whole call chain, you'll find quite some
> room for optimizations - look how dev and pdev are used. That also applies
> to other patches.

Would you prefer to improve the source code in other ways?

Regards,
Markus