linux-next: Signed-off-by missing for commits in the staging tree

linux-next: Signed-off-by missing for commits in the staging tree

[Stephen Rothwell]

Hi Greg,

Commits

  2525ef557c73 ("staging: most: update driver usage file")
  e7e3ce04588c ("staging: most: core: fix list traversing")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Greg KH]

On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> Commits
> 
>   2525ef557c73 ("staging: most: update driver usage file")
>   e7e3ce04588c ("staging: most: core: fix list traversing")
> 
> are missing a Signed-off-by from their author.

Ugh, I missed that.  Christian, please be more careful.

I need to set up a git hook for this :(

greg k-h

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

Hi Greg,

On Tue, 28 Nov 2017 20:41:39 +0100 Greg KH <greg@kroah.com> wrote:
>
> I need to set up a git hook for this :(

I couldn't find an appropriate hook for fetching or merging other
trees :-( Instead I run the attached script below after each fetch.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: check_commits --]
[-- Type: application/x-shellscript, Size: 1142 bytes --]

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Michael Ellerman]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Greg,
>
> On Tue, 28 Nov 2017 20:41:39 +0100 Greg KH <greg@kroah.com> wrote:
>>
>> I need to set up a git hook for this :(
>
> I couldn't find an appropriate hook for fetching or merging other
> trees :-( Instead I run the attached script below after each fetch.

Isn't the update hook what you want?

Called by git-receive-pack:

   Before each ref is updated, if $GIT_DIR/hooks/update file exists and
   is executable, it is invoked once per ref, with three parameters:

       $GIT_DIR/hooks/update refname sha1-old sha1-new

cheers

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Stephen Rothwell]

Hi Michael,

On Wed, 29 Nov 2017 11:09:04 +1100 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Isn't the update hook what you want?
> 
> Called by git-receive-pack:
> 
>    Before each ref is updated, if $GIT_DIR/hooks/update file exists and
>    is executable, it is invoked once per ref, with three parameters:
> 
>        $GIT_DIR/hooks/update refname sha1-old sha1-new

"This hook is invoked by git-receive-pack on the remote repository,
 which happens when a git push is done on a local repository."

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Greg KH]

On Wed, Nov 29, 2017 at 09:59:16AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Tue, 28 Nov 2017 20:41:39 +0100 Greg KH <greg@kroah.com> wrote:
> >
> > I need to set up a git hook for this :(
> 
> I couldn't find an appropriate hook for fetching or merging other
> trees :-( Instead I run the attached script below after each fetch.

Ok, instead of just running this every so often (obviously I was
forgetting to), I've now added it to my main "commit this set of
patches" script so that I will be notified of any problems _before_ you
ever see them.

Sorry for taking so long with this, ugh.

greg k-h

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Christian Gromm]

On 28.11.2017 20:41, Greg KH wrote:
> On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> Commits
>>
>>    2525ef557c73 ("staging: most: update driver usage file")
>>    e7e3ce04588c ("staging: most: core: fix list traversing")
>>
>> are missing a Signed-off-by from their author.
> 
> Ugh, I missed that.  Christian, please be more careful.
> 

Hmm, am I missing something here? I have it in.
Here are copies of the patches in question and both have
a "Signed-off-by" line in.

---snip---
Received: from muaddib.microchip.com (10.10.76.4) by 
chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id 
14.3.352.0; Tue, 21 Nov 2017 07:05:31 -0700
From: Christian Gromm <christian.gromm@microchip.com>
To: gregkh@linuxfoundation.org
CC: driverdev-devel@linuxdriverproject.org, Andrey Shvetsov 
<andrey.shvetsov@k2l.de>, Christian Gromm <christian.gromm@microchip.com>
Subject: [PATCH 48/50] staging: most: core: fix list traversing
Date: Tue, 21 Nov 2017 15:05:22 +0100
Message-ID: 
<1511273124-7840-49-git-send-email-christian.gromm@microchip.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: 
<1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
References: <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
Content-Type: text/plain
Return-Path: christian.gromm@microchip.com
X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
X-MS-Exchange-Organization-AuthAs: Internal
X-MS-Exchange-Organization-AuthMechanism: 10
X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
MIME-Version: 1.0

From: Andrey Shvetsov <andrey.shvetsov@k2l.de>
This patch fixes the offset and data handling when traversing
the list of devices that are attached to the bus.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
---
  drivers/staging/most/core.c | 17 +++++++++++++----
  1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index d03ff97..9729206 100644
--- a/drivers/staging/most/core.c
+++ b/drivers/staging/most/core.c
@@ -535,10 +535,16 @@ static struct core_component *match_component(char 
*name)
  	return NULL;
  }

+struct show_links_data {
+	int offs;
+	char *buf;
+};
+
  int print_links(struct device *dev, void *data)
  {
-	int offs = 0;
-	char *buf = data;
+	struct show_links_data *d = data;
+	int offs = d->offs;
+	char *buf = d->buf;
  	struct most_channel *c;
  	struct most_interface *iface = to_most_interface(dev);

@@ -560,13 +566,16 @@ int print_links(struct device *dev, void *data)
  					 dev_name(&c->dev));
  		}
  	}
+	d->offs = offs;
  	return 0;
  }

  static ssize_t links_show(struct device_driver *drv, char *buf)
  {
-	bus_for_each_dev(&mc.bus, NULL, buf, print_links);
-	return strlen(buf);
+	struct show_links_data d = { .buf = buf };
+
+	bus_for_each_dev(&mc.bus, NULL, &d, print_links);
+	return d.offs;
  }

  static ssize_t components_show(struct device_driver *drv, char *buf)
-- 
2.7.4


and


Received: from muaddib.microchip.com (10.10.76.4) by 
chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id 
14.3.352.0; Tue, 21 Nov 2017 07:05:26 -0700
From: Christian Gromm <christian.gromm@microchip.com>
To: gregkh@linuxfoundation.org
CC: driverdev-devel@linuxdriverproject.org, Andrey Shvetsov 
<andrey.shvetsov@k2l.de>, Christian Gromm <christian.gromm@microchip.com>
Subject: [PATCH 44/50] staging: most: update driver usage file
Date: Tue, 21 Nov 2017 15:05:18 +0100
Message-ID: 
<1511273124-7840-45-git-send-email-christian.gromm@microchip.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: 
<1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
References: <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
Content-Type: text/plain
Return-Path: christian.gromm@microchip.com
X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
X-MS-Exchange-Organization-AuthAs: Internal
X-MS-Exchange-Organization-AuthMechanism: 10
X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
MIME-Version: 1.0

From: Andrey Shvetsov <andrey.shvetsov@k2l.de>

This patch keeps the usage file up to date.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
---
  .../staging/most/Documentation/driver_usage.txt    | 192 
+++++++++++----------
  1 file changed, 105 insertions(+), 87 deletions(-)

diff --git a/drivers/staging/most/Documentation/driver_usage.txt 
b/drivers/staging/most/Documentation/driver_usage.txt
index a4dc0c3..bb9b4e8 100644
--- a/drivers/staging/most/Documentation/driver_usage.txt
+++ b/drivers/staging/most/Documentation/driver_usage.txt
@@ -23,20 +23,29 @@ audio/video streaming. Therefore, the driver 
perfectly fits to the mission
  of Automotive Grade Linux to create open source software solutions for
  automotive applications.

-The driver consists basically of three layers. The hardware layer, the
-core layer and the application layer. The core layer consists of the core
-module only. This module handles the communication flow through all three
-layers, the configuration of the driver, the configuration interface
-representation in sysfs, and the buffer management.
-For each of the other two layers a selection of modules is provided. These
-modules can arbitrarily be combined to meet the needs of the desired
-system architecture. A module of the hardware layer is referred to as an
-HDM (hardware dependent module). Each module of this layer handles exactly
-one of the peripheral interfaces of a network interface controller (e.g.
-USB, MediaLB, I2C). A module of the application layer is referred to as an
-AIM (application interfacing module). The modules of this layer give access
-to MOST via one the following ways: character devices, ALSA, Networking or
..........

regards,
Chris


> I need to set up a git hook for this :(
> 
> greg k-h
> 

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Greg KH]

On Wed, Nov 29, 2017 at 09:44:44AM +0100, Christian Gromm wrote:
> On 28.11.2017 20:41, Greg KH wrote:
> > On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
> > > Hi Greg,
> > > 
> > > Commits
> > > 
> > >    2525ef557c73 ("staging: most: update driver usage file")
> > >    e7e3ce04588c ("staging: most: core: fix list traversing")
> > > 
> > > are missing a Signed-off-by from their author.
> > 
> > Ugh, I missed that.  Christian, please be more careful.
> > 
> 
> Hmm, am I missing something here? I have it in.
> Here are copies of the patches in question and both have
> a "Signed-off-by" line in.
> 
> ---snip---
> Received: from muaddib.microchip.com (10.10.76.4) by
> chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
> 14.3.352.0; Tue, 21 Nov 2017 07:05:31 -0700
> From: Christian Gromm <christian.gromm@microchip.com>
> To: gregkh@linuxfoundation.org
> CC: driverdev-devel@linuxdriverproject.org, Andrey Shvetsov
> <andrey.shvetsov@k2l.de>, Christian Gromm <christian.gromm@microchip.com>
> Subject: [PATCH 48/50] staging: most: core: fix list traversing
> Date: Tue, 21 Nov 2017 15:05:22 +0100
> Message-ID:
> <1511273124-7840-49-git-send-email-christian.gromm@microchip.com>
> X-Mailer: git-send-email 2.7.4
> In-Reply-To:
> <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
> References: <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
> Content-Type: text/plain
> Return-Path: christian.gromm@microchip.com
> X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
> X-MS-Exchange-Organization-AuthAs: Internal
> X-MS-Exchange-Organization-AuthMechanism: 10
> X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
> MIME-Version: 1.0
> 
> From: Andrey Shvetsov <andrey.shvetsov@k2l.de>
> This patch fixes the offset and data handling when traversing
> the list of devices that are attached to the bus.
> 
> Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
> ---
>  drivers/staging/most/core.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
> index d03ff97..9729206 100644
> --- a/drivers/staging/most/core.c
> +++ b/drivers/staging/most/core.c
> @@ -535,10 +535,16 @@ static struct core_component *match_component(char
> *name)
>  	return NULL;
>  }
> 
> +struct show_links_data {
> +	int offs;
> +	char *buf;
> +};
> +
>  int print_links(struct device *dev, void *data)
>  {
> -	int offs = 0;
> -	char *buf = data;
> +	struct show_links_data *d = data;
> +	int offs = d->offs;
> +	char *buf = d->buf;
>  	struct most_channel *c;
>  	struct most_interface *iface = to_most_interface(dev);
> 
> @@ -560,13 +566,16 @@ int print_links(struct device *dev, void *data)
>  					 dev_name(&c->dev));
>  		}
>  	}
> +	d->offs = offs;
>  	return 0;
>  }
> 
>  static ssize_t links_show(struct device_driver *drv, char *buf)
>  {
> -	bus_for_each_dev(&mc.bus, NULL, buf, print_links);
> -	return strlen(buf);
> +	struct show_links_data d = { .buf = buf };
> +
> +	bus_for_each_dev(&mc.bus, NULL, &d, print_links);
> +	return d.offs;
>  }
> 
>  static ssize_t components_show(struct device_driver *drv, char *buf)
> -- 
> 2.7.4
> 
> 
> and
> 
> 
> Received: from muaddib.microchip.com (10.10.76.4) by
> chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
> 14.3.352.0; Tue, 21 Nov 2017 07:05:26 -0700
> From: Christian Gromm <christian.gromm@microchip.com>
> To: gregkh@linuxfoundation.org
> CC: driverdev-devel@linuxdriverproject.org, Andrey Shvetsov
> <andrey.shvetsov@k2l.de>, Christian Gromm <christian.gromm@microchip.com>
> Subject: [PATCH 44/50] staging: most: update driver usage file
> Date: Tue, 21 Nov 2017 15:05:18 +0100
> Message-ID:
> <1511273124-7840-45-git-send-email-christian.gromm@microchip.com>
> X-Mailer: git-send-email 2.7.4
> In-Reply-To:
> <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
> References: <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
> Content-Type: text/plain
> Return-Path: christian.gromm@microchip.com
> X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
> X-MS-Exchange-Organization-AuthAs: Internal
> X-MS-Exchange-Organization-AuthMechanism: 10
> X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
> MIME-Version: 1.0
> 
> From: Andrey Shvetsov <andrey.shvetsov@k2l.de>
> 
> This patch keeps the usage file up to date.
> 
> Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
> ---

Why is there no signed-off-by from Andrey?

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Christian Gromm]

On 29.11.2017 10:14, Greg KH wrote:
> On Wed, Nov 29, 2017 at 09:44:44AM +0100, Christian Gromm wrote:
>> On 28.11.2017 20:41, Greg KH wrote:
>>> On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
>>>> Hi Greg,
>>>>
>>>> Commits
>>>>
>>>>     2525ef557c73 ("staging: most: update driver usage file")
>>>>     e7e3ce04588c ("staging: most: core: fix list traversing")
>>>>
>>>> are missing a Signed-off-by from their author.
>>>
>>> Ugh, I missed that.  Christian, please be more careful.
>>>
>>
>> Hmm, am I missing something here? I have it in.
>> Here are copies of the patches in question and both have
>> a "Signed-off-by" line in.
>>
>> ---snip---
>> Received: from muaddib.microchip.com (10.10.76.4) by
>> chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
>> 14.3.352.0; Tue, 21 Nov 2017 07:05:31 -0700
>> From: Christian Gromm <christian.gromm@microchip.com>
>> To: gregkh@linuxfoundation.org
>> CC: driverdev-devel@linuxdriverproject.org, Andrey Shvetsov
>> <andrey.shvetsov@k2l.de>, Christian Gromm <christian.gromm@microchip.com>
>> Subject: [PATCH 48/50] staging: most: core: fix list traversing
>> Date: Tue, 21 Nov 2017 15:05:22 +0100
>> Message-ID:
>> <1511273124-7840-49-git-send-email-christian.gromm@microchip.com>
>> X-Mailer: git-send-email 2.7.4
>> In-Reply-To:
>> <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
>> References: <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
>> Content-Type: text/plain
>> Return-Path: christian.gromm@microchip.com
>> X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
>> X-MS-Exchange-Organization-AuthAs: Internal
>> X-MS-Exchange-Organization-AuthMechanism: 10
>> X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
>> MIME-Version: 1.0
>>
>> From: Andrey Shvetsov <andrey.shvetsov@k2l.de>
>> This patch fixes the offset and data handling when traversing
>> the list of devices that are attached to the bus.
>>
>> Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
>> ---
>>   drivers/staging/most/core.c | 17 +++++++++++++----
>>   1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
>> index d03ff97..9729206 100644
>> --- a/drivers/staging/most/core.c
>> +++ b/drivers/staging/most/core.c
>> @@ -535,10 +535,16 @@ static struct core_component *match_component(char
>> *name)
>>   	return NULL;
>>   }
>>
>> +struct show_links_data {
>> +	int offs;
>> +	char *buf;
>> +};
>> +
>>   int print_links(struct device *dev, void *data)
>>   {
>> -	int offs = 0;
>> -	char *buf = data;
>> +	struct show_links_data *d = data;
>> +	int offs = d->offs;
>> +	char *buf = d->buf;
>>   	struct most_channel *c;
>>   	struct most_interface *iface = to_most_interface(dev);
>>
>> @@ -560,13 +566,16 @@ int print_links(struct device *dev, void *data)
>>   					 dev_name(&c->dev));
>>   		}
>>   	}
>> +	d->offs = offs;
>>   	return 0;
>>   }
>>
>>   static ssize_t links_show(struct device_driver *drv, char *buf)
>>   {
>> -	bus_for_each_dev(&mc.bus, NULL, buf, print_links);
>> -	return strlen(buf);
>> +	struct show_links_data d = { .buf = buf };
>> +
>> +	bus_for_each_dev(&mc.bus, NULL, &d, print_links);
>> +	return d.offs;
>>   }
>>
>>   static ssize_t components_show(struct device_driver *drv, char *buf)
>> -- 
>> 2.7.4
>>
>>
>> and
>>
>>
>> Received: from muaddib.microchip.com (10.10.76.4) by
>> chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
>> 14.3.352.0; Tue, 21 Nov 2017 07:05:26 -0700
>> From: Christian Gromm <christian.gromm@microchip.com>
>> To: gregkh@linuxfoundation.org
>> CC: driverdev-devel@linuxdriverproject.org, Andrey Shvetsov
>> <andrey.shvetsov@k2l.de>, Christian Gromm <christian.gromm@microchip.com>
>> Subject: [PATCH 44/50] staging: most: update driver usage file
>> Date: Tue, 21 Nov 2017 15:05:18 +0100
>> Message-ID:
>> <1511273124-7840-45-git-send-email-christian.gromm@microchip.com>
>> X-Mailer: git-send-email 2.7.4
>> In-Reply-To:
>> <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
>> References: <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
>> Content-Type: text/plain
>> Return-Path: christian.gromm@microchip.com
>> X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
>> X-MS-Exchange-Organization-AuthAs: Internal
>> X-MS-Exchange-Organization-AuthMechanism: 10
>> X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
>> MIME-Version: 1.0
>>
>> From: Andrey Shvetsov <andrey.shvetsov@k2l.de>
>>
>> This patch keeps the usage file up to date.
>>
>> Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
>> ---
> 
> Why is there no signed-off-by from Andrey?
> 

Ah, his "Signed-off-by" is missing. Understood. Wasn't aware that
this is a prerequisite. Thought the patches need at least one
person that signs them off.

This is because we both develop on the driver. And I take the
patches from our internal gitlab server, prepare them and send
them upstream. And those two patches missed his Signed-off
obvioulsy.

Should I resend?

regards,
Chris

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Greg KH]

On Wed, Nov 29, 2017 at 10:25:10AM +0100, Christian Gromm wrote:
> On 29.11.2017 10:14, Greg KH wrote:
> > On Wed, Nov 29, 2017 at 09:44:44AM +0100, Christian Gromm wrote:
> > > On 28.11.2017 20:41, Greg KH wrote:
> > > > On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
> > > > > Hi Greg,
> > > > > 
> > > > > Commits
> > > > > 
> > > > >     2525ef557c73 ("staging: most: update driver usage file")
> > > > >     e7e3ce04588c ("staging: most: core: fix list traversing")
> > > > > 
> > > > > are missing a Signed-off-by from their author.
> > > > 
> > > > Ugh, I missed that.  Christian, please be more careful.
> > > > 
> > > 
> > > Hmm, am I missing something here? I have it in.
> > > Here are copies of the patches in question and both have
> > > a "Signed-off-by" line in.
> > > 
> > > ---snip---
> > > Received: from muaddib.microchip.com (10.10.76.4) by
> > > chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
> > > 14.3.352.0; Tue, 21 Nov 2017 07:05:31 -0700
> > > From: Christian Gromm <christian.gromm@microchip.com>
> > > To: gregkh@linuxfoundation.org
> > > CC: driverdev-devel@linuxdriverproject.org, Andrey Shvetsov
> > > <andrey.shvetsov@k2l.de>, Christian Gromm <christian.gromm@microchip.com>
> > > Subject: [PATCH 48/50] staging: most: core: fix list traversing
> > > Date: Tue, 21 Nov 2017 15:05:22 +0100
> > > Message-ID:
> > > <1511273124-7840-49-git-send-email-christian.gromm@microchip.com>
> > > X-Mailer: git-send-email 2.7.4
> > > In-Reply-To:
> > > <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
> > > References: <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
> > > Content-Type: text/plain
> > > Return-Path: christian.gromm@microchip.com
> > > X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
> > > X-MS-Exchange-Organization-AuthAs: Internal
> > > X-MS-Exchange-Organization-AuthMechanism: 10
> > > X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
> > > MIME-Version: 1.0
> > > 
> > > From: Andrey Shvetsov <andrey.shvetsov@k2l.de>
> > > This patch fixes the offset and data handling when traversing
> > > the list of devices that are attached to the bus.
> > > 
> > > Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
> > > ---
> > >   drivers/staging/most/core.c | 17 +++++++++++++----
> > >   1 file changed, 13 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
> > > index d03ff97..9729206 100644
> > > --- a/drivers/staging/most/core.c
> > > +++ b/drivers/staging/most/core.c
> > > @@ -535,10 +535,16 @@ static struct core_component *match_component(char
> > > *name)
> > >   	return NULL;
> > >   }
> > > 
> > > +struct show_links_data {
> > > +	int offs;
> > > +	char *buf;
> > > +};
> > > +
> > >   int print_links(struct device *dev, void *data)
> > >   {
> > > -	int offs = 0;
> > > -	char *buf = data;
> > > +	struct show_links_data *d = data;
> > > +	int offs = d->offs;
> > > +	char *buf = d->buf;
> > >   	struct most_channel *c;
> > >   	struct most_interface *iface = to_most_interface(dev);
> > > 
> > > @@ -560,13 +566,16 @@ int print_links(struct device *dev, void *data)
> > >   					 dev_name(&c->dev));
> > >   		}
> > >   	}
> > > +	d->offs = offs;
> > >   	return 0;
> > >   }
> > > 
> > >   static ssize_t links_show(struct device_driver *drv, char *buf)
> > >   {
> > > -	bus_for_each_dev(&mc.bus, NULL, buf, print_links);
> > > -	return strlen(buf);
> > > +	struct show_links_data d = { .buf = buf };
> > > +
> > > +	bus_for_each_dev(&mc.bus, NULL, &d, print_links);
> > > +	return d.offs;
> > >   }
> > > 
> > >   static ssize_t components_show(struct device_driver *drv, char *buf)
> > > -- 
> > > 2.7.4
> > > 
> > > 
> > > and
> > > 
> > > 
> > > Received: from muaddib.microchip.com (10.10.76.4) by
> > > chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id
> > > 14.3.352.0; Tue, 21 Nov 2017 07:05:26 -0700
> > > From: Christian Gromm <christian.gromm@microchip.com>
> > > To: gregkh@linuxfoundation.org
> > > CC: driverdev-devel@linuxdriverproject.org, Andrey Shvetsov
> > > <andrey.shvetsov@k2l.de>, Christian Gromm <christian.gromm@microchip.com>
> > > Subject: [PATCH 44/50] staging: most: update driver usage file
> > > Date: Tue, 21 Nov 2017 15:05:18 +0100
> > > Message-ID:
> > > <1511273124-7840-45-git-send-email-christian.gromm@microchip.com>
> > > X-Mailer: git-send-email 2.7.4
> > > In-Reply-To:
> > > <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
> > > References: <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
> > > Content-Type: text/plain
> > > Return-Path: christian.gromm@microchip.com
> > > X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
> > > X-MS-Exchange-Organization-AuthAs: Internal
> > > X-MS-Exchange-Organization-AuthMechanism: 10
> > > X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
> > > MIME-Version: 1.0
> > > 
> > > From: Andrey Shvetsov <andrey.shvetsov@k2l.de>
> > > 
> > > This patch keeps the usage file up to date.
> > > 
> > > Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
> > > ---
> > 
> > Why is there no signed-off-by from Andrey?
> > 
> 
> Ah, his "Signed-off-by" is missing. Understood. Wasn't aware that
> this is a prerequisite. Thought the patches need at least one
> person that signs them off.

They do, but that should always be the patch author at the least :)

> This is because we both develop on the driver. And I take the
> patches from our internal gitlab server, prepare them and send
> them upstream. And those two patches missed his Signed-off
> obvioulsy.

You should sign off on your internal patches, to make this more obvious
and easier.

> Should I resend?

It's already in my tree, no need.

thanks,

greg k-h

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Stephen Rothwell]

Hi Christian,

On Wed, 29 Nov 2017 09:44:44 +0100 Christian Gromm <christian.gromm@microchip.com> wrote:
>
> Hmm, am I missing something here? I have it in.
> Here are copies of the patches in question and both have
> a "Signed-off-by" line in.

According to the From: line in the body of these emails, the author of
this patch is Andrey Shvetsov <andrey.shvetsov@k2l.de>, and there is no
Signed-off-by line from Andrey.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Stephen Rothwell]

Hi all,

On Wed, 29 Nov 2017 23:24:46 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Wed, 29 Nov 2017 09:44:44 +0100 Christian Gromm <christian.gromm@microchip.com> wrote:
> >
> > Hmm, am I missing something here? I have it in.
> > Here are copies of the patches in question and both have
> > a "Signed-off-by" line in.  
> 
> According to the From: line in the body of these emails, the author of
> this patch is Andrey Shvetsov <andrey.shvetsov@k2l.de>, and there is no
> Signed-off-by line from Andrey.

I should read further ahead in my email ... sorry for the noise.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Christian Gromm]

On 29.11.2017 13:24, Stephen Rothwell wrote:
> Hi Christian,
> 
> On Wed, 29 Nov 2017 09:44:44 +0100 Christian Gromm <christian.gromm@microchip.com> wrote:
>>
>> Hmm, am I missing something here? I have it in.
>> Here are copies of the patches in question and both have
>> a "Signed-off-by" line in.
> 
> According to the From: line in the body of these emails, the author of
> this patch is Andrey Shvetsov <andrey.shvetsov@k2l.de>, and there is no
> Signed-off-by line from Andrey.
> 
Got it. Thanks! We will fix our process so it won't happen again :)

regards,
Chris

linux-next: Signed-off-by missing for commits in the staging tree

[Stephen Rothwell]

Hi Greg,

Commits

  97c6166001ef ("Staging: rtlwifi: Remove unused variable and the code")
  357f862bd214 ("staging: comedi: adv_pci1760: fix typo in comments")
  23cb746b5e9d ("staging: rtl8192u: Replace mdelay with msleep in rtl8192_usb_probe")
  beac4303532f ("Staging: vt6656: Fix unnecessary 'out of memory' message")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Greg KH]

On Wed, Jan 10, 2018 at 07:18:30AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> Commits
> 
>   97c6166001ef ("Staging: rtlwifi: Remove unused variable and the code")
>   357f862bd214 ("staging: comedi: adv_pci1760: fix typo in comments")
>   23cb746b5e9d ("staging: rtl8192u: Replace mdelay with msleep in rtl8192_usb_probe")
>   beac4303532f ("Staging: vt6656: Fix unnecessary 'out of memory' message")
> 
> are missing a Signed-off-by from their committer.

Crap, this has been a long month, sorry about that.  I'll go work on
getting that git hook in place to prevent this from happening again...

greg k-h

linux-next: Signed-off-by missing for commits in the staging tree

[Stephen Rothwell]

Hi Greg,

Commits

  688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment")
  85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply")
  f216f6cdeb1d ("staging: rtlwifi: remove unused functions")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Greg KH]

On Tue, Sep 19, 2017 at 07:54:55AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> Commits
> 
>   688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment")
>   85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply")
>   f216f6cdeb1d ("staging: rtlwifi: remove unused functions")
> 
> are missing a Signed-off-by from their author.

Ugh, I totally missed that, Tobin, what went wrong here?

I can't go rewrite my tree, so I'll just accept this as an implicit "ok"
for these patches, any objection?

thanks,

greg k-h

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Tobin Harding]

On Tue, Sep 19, 2017, at 16:09, Greg KH wrote:
> On Tue, Sep 19, 2017 at 07:54:55AM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > Commits
> > 
> >   688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment")
> >   85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply")
> >   f216f6cdeb1d ("staging: rtlwifi: remove unused functions")
> > 
> > are missing a Signed-off-by from their author.
> 
> Ugh, I totally missed that, Tobin, what went wrong here?

Apologies, I bet I didn't set up my environment on the laptop fully.
Usual dev machine is a desktop, I did these patches as prep for OSS. 

> I can't go rewrite my tree, so I'll just accept this as an implicit "ok"
> for these patches, any objection?

Ok by me.

Thanks,
Tobin.

Re: linux-next: Signed-off-by missing for commits in the staging tree

[Tobin Harding]

On Wed, Sep 20, 2017, at 01:34, Tobin Harding wrote:
> 
> On Tue, Sep 19, 2017, at 16:09, Greg KH wrote:
> > On Tue, Sep 19, 2017 at 07:54:55AM +1000, Stephen Rothwell wrote:
> > > Hi Greg,
> > > 
> > > Commits
> > > 
> > >   688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment")
> > >   85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply")
> > >   f216f6cdeb1d ("staging: rtlwifi: remove unused functions")
> > > 
> > > are missing a Signed-off-by from their author.
> > 
> > Ugh, I totally missed that, Tobin, what went wrong here?
> 
> Apologies, I bet I didn't set up my environment on the laptop fully.
> Usual dev machine is a desktop, I did these patches as prep for OSS. 

I've got a strong feeling I didn't enable the driver before I 'built'
this patch series also.  Bad Tobin.

Luckily the kbot didn't punish me.