[PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM

[PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM

[Randy Dunlap]

From: Randy Dunlap <rdunlap@infradead.org>

Fix build error when the driver is built for arch/um, which does not
support HAS_IOMEM. Furthermore, the in-tree SYSCON drivers also require
HAS_IOMEM.

drivers/built-in.o: In function `img_ascii_lcd_probe':
drivers/auxdisplay/img-ascii-lcd.c:384: undefined reference to `devm_ioremap_resource'

Paul: there is no SYSCON kconfig symbol in the kernel tree. Should that
be MFD_SYSCON or GPIO_SYSCON?
Also, there is no MIPS_SEAD3 kconfig symbol either. Please fix that.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc:	Paul Burton <paul.burton@imgtec.com>
Cc:	Jeff Dike <jdike@addtoit.com>
Cc:	Richard Weinberger <richard@nod.at>
Cc:	user-mode-linux-devel@lists.sourceforge.net
Cc:	Lee Jones <lee.jones@linaro.org>
Cc:	Arnd Bergmann <arnd@arndb.de>
Cc:	Geert Uytterhoeven <geert@linux-m68k.org>
Cc:	Ralf Baechle <ralf@linux-mips.org>
---
 drivers/auxdisplay/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- lnx-410-rc2.orig/drivers/auxdisplay/Kconfig
+++ lnx-410-rc2/drivers/auxdisplay/Kconfig
@@ -121,6 +121,7 @@ config CFAG12864B_RATE
 
 config IMG_ASCII_LCD
 	tristate "Imagination Technologies ASCII LCD Display"
+	depends on HAS_IOMEM
 	default y if MIPS_MALTA || MIPS_SEAD3
 	select SYSCON
 	help

Re: [PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM

[Arnd Bergmann]

On Sunday, January 1, 2017 6:42:38 PM CET Randy Dunlap wrote:
> --- lnx-410-rc2.orig/drivers/auxdisplay/Kconfig
> +++ lnx-410-rc2/drivers/auxdisplay/Kconfig
> @@ -121,6 +121,7 @@ config CFAG12864B_RATE
>  
>  config IMG_ASCII_LCD
>         tristate "Imagination Technologies ASCII LCD Display"
> +       depends on HAS_IOMEM
>         default y if MIPS_MALTA || MIPS_SEAD3
>         select SYSCON
>         help

Maybe "depends on MIPS || COMPILE_TEST" instead?

That hides the symbol for most people that don't really want the driver
anyway, and it takes care of HAS_IOMEM for UML as well.

	Arnd