* [PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM
@ 2017-01-02 2:42 Randy Dunlap
2017-01-02 8:32 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2017-01-02 2:42 UTC (permalink / raw)
To: LKML
Cc: kbuild test robot, Paul Burton, Jeff Dike, Richard Weinberger,
user-mode-linux-devel, Lee Jones, Arnd Bergmann,
Geert Uytterhoeven, Ralf Baechle
From: Randy Dunlap <rdunlap@infradead.org>
Fix build error when the driver is built for arch/um, which does not
support HAS_IOMEM. Furthermore, the in-tree SYSCON drivers also require
HAS_IOMEM.
drivers/built-in.o: In function `img_ascii_lcd_probe':
drivers/auxdisplay/img-ascii-lcd.c:384: undefined reference to `devm_ioremap_resource'
Paul: there is no SYSCON kconfig symbol in the kernel tree. Should that
be MFD_SYSCON or GPIO_SYSCON?
Also, there is no MIPS_SEAD3 kconfig symbol either. Please fix that.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
drivers/auxdisplay/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- lnx-410-rc2.orig/drivers/auxdisplay/Kconfig
+++ lnx-410-rc2/drivers/auxdisplay/Kconfig
@@ -121,6 +121,7 @@ config CFAG12864B_RATE
config IMG_ASCII_LCD
tristate "Imagination Technologies ASCII LCD Display"
+ depends on HAS_IOMEM
default y if MIPS_MALTA || MIPS_SEAD3
select SYSCON
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM
2017-01-02 2:42 [PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM Randy Dunlap
@ 2017-01-02 8:32 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2017-01-02 8:32 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, kbuild test robot, Paul Burton, Jeff Dike,
Richard Weinberger, user-mode-linux-devel, Lee Jones,
Geert Uytterhoeven, Ralf Baechle
On Sunday, January 1, 2017 6:42:38 PM CET Randy Dunlap wrote:
> --- lnx-410-rc2.orig/drivers/auxdisplay/Kconfig
> +++ lnx-410-rc2/drivers/auxdisplay/Kconfig
> @@ -121,6 +121,7 @@ config CFAG12864B_RATE
>
> config IMG_ASCII_LCD
> tristate "Imagination Technologies ASCII LCD Display"
> + depends on HAS_IOMEM
> default y if MIPS_MALTA || MIPS_SEAD3
> select SYSCON
> help
Maybe "depends on MIPS || COMPILE_TEST" instead?
That hides the symbol for most people that don't really want the driver
anyway, and it takes care of HAS_IOMEM for UML as well.
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-02 8:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-02 2:42 [PATCH] auxdisplay: img-ascii-lcd: don't build without HAS_IOMEM Randy Dunlap
2017-01-02 8:32 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).