From: Jacky Huang <ychuang3@nuvoton.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <ychuang570808@gmail.com>
Cc: <robh+dt@kernel.org>, <sboyd@kernel.org>, <krzk+dt@kernel.org>,
<arnd@arndb.de>, <olof@lixom.net>, <catalin.marinas@arm.com>,
<will@kernel.org>, <soc@kernel.org>, <cfli0@nuvoton.com>
Subject: Re: [PATCH V4 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings
Date: Fri, 13 May 2022 14:25:59 +0800 [thread overview]
Message-ID: <2786221c-d0a5-9bce-70d3-385dc419591a@nuvoton.com> (raw)
In-Reply-To: <f0969769-9f24-7e48-6a60-adeea94404e1@linaro.org>
On 2022/5/12 下午 10:04, Krzysztof Kozlowski wrote:
> On 10/05/2022 05:25, Jacky Huang wrote:
>> Add documentation to describe Nuvoton MA35D1 clock driver bindings.
>>
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
>> +
>> + clk: clock-controller@40460200 {
>> + compatible = "nuvoton,ma35d1-clk";
>> + reg = <0x0 0x40460200 0x0 0x100>;
> I don't think you tested your bindings. This fails.
>
> clock-names below as well. Please do not send untested code.
>
> Testing is explained here:
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.18-rc6%2Fsource%2FDocumentation%2Fdevicetree%2Fbindings%2Fwriting-schema.rst%23L111&data=05%7C01%7Cychuang3%40nuvoton.com%7C7f9b081f94a642e8b40b08da34204e53%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637879610603173566%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kqInjscLvZpOSWtsN%2BPW3s%2BPeaK5KCD1weTH2JiHqxg%3D&reserved=0
>
> Best regards,
> Krzysztof
I run the test make DT_CHECKER_FLAGS=-m dt_binding_check, but not run
dtbs_check.
I will fix it. Thank you.
Sincerely,
Jacky Huang
next prev parent reply other threads:[~2022-05-13 6:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 3:25 [PATCH V4 0/5] Add initial support for MA35D1 SoC Jacky Huang
2022-05-10 3:25 ` [PATCH V4 1/5] dt-bindings: clock: add binding for MA35D1 clock controller Jacky Huang
2022-05-10 3:25 ` [PATCH V4 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings Jacky Huang
2022-05-12 14:04 ` Krzysztof Kozlowski
2022-05-13 6:25 ` Jacky Huang [this message]
2022-05-13 6:54 ` Krzysztof Kozlowski
2022-05-10 3:25 ` [PATCH V4 3/5] arm64: dts: nuvoton: Add initial support for MA35D1 Jacky Huang
2022-05-10 7:01 ` Arnd Bergmann
2022-05-10 8:50 ` Jacky Huang
2022-05-12 14:10 ` Krzysztof Kozlowski
2022-05-13 6:48 ` Jacky Huang
2022-05-13 6:57 ` Krzysztof Kozlowski
2022-05-15 5:53 ` Jacky Huang
2022-05-15 9:54 ` Krzysztof Kozlowski
2022-05-10 3:25 ` [PATCH V4 4/5] arm64: Kconfig: nuvoton: Introduce CONFIG_ARCH_NUVOTON Jacky Huang
2022-05-10 3:25 ` [PATCH V4 5/5] dt-bindings: arm: Add initial bindings for Nuvoton Platform Jacky Huang
2022-05-11 15:23 ` Rob Herring
2022-05-10 7:07 ` [PATCH V4 0/5] Add initial support for MA35D1 SoC Arnd Bergmann
2022-05-10 8:40 ` Jacky Huang
2022-05-10 12:45 ` Arnd Bergmann
2022-05-11 2:31 ` Jacky Huang
2022-05-12 14:11 ` Krzysztof Kozlowski
2022-05-12 14:35 ` Arnd Bergmann
2022-05-13 6:53 ` Jacky Huang
2022-05-13 6:55 ` Krzysztof Kozlowski
2022-05-13 7:00 ` Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2786221c-d0a5-9bce-70d3-385dc419591a@nuvoton.com \
--to=ychuang3@nuvoton.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cfli0@nuvoton.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).