From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jacky Huang <ychuang570808@gmail.com>,
Jacky Huang <ychuang3@nuvoton.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: robh+dt@kernel.org, sboyd@kernel.org, krzk+dt@kernel.org,
arnd@arndb.de, olof@lixom.net, catalin.marinas@arm.com,
will@kernel.org, soc@kernel.org, cfli0@nuvoton.com
Subject: Re: [PATCH V4 3/5] arm64: dts: nuvoton: Add initial support for MA35D1
Date: Sun, 15 May 2022 11:54:38 +0200 [thread overview]
Message-ID: <c3b8a28d-087f-f973-17db-da9c0fed10dd@linaro.org> (raw)
In-Reply-To: <db333ce4-6b21-7807-15fa-384619cde6f8@gmail.com>
On 15/05/2022 07:53, Jacky Huang wrote:
>
> On 2022/5/13 下午 02:57, Krzysztof Kozlowski wrote:
>> On 13/05/2022 08:48, Jacky Huang wrote:
>>>>> +
>>>>> + hxt_24m: hxt_24mhz {
>>>> No underscores in node name. Generic node names, so "clock-X" or
>>>> "clock-some-suffix"
>>> OK, I will modify it as
>>> hxt-24m: hxt-24mhz
>> No, it is not a generic node name. Please read my reply again.
>
> I would modify it as
>
> clock-hxt: clock-hspd-ext-crystal
>
>
>>
>>>>> + compatible = "fixed-clock";
>>>>> + #clock-cells = <0>;
>>>>> + clock-frequency = <24000000>;
>>>> This does not look like property of SoC. Where is this clock defined? In
>>>> the SoC or on the board?
>>> It's an external crystal on the board.
>>> I add this node, because it's the clock source of clock controller.
>>> It always present on all ma35d1 boards.
>>>
Then such clock is not a property of a SoC, but a board. Feel free to
simplify DTS by storing most of the clock node in DTSI, but frequency
should be defined by each board.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-15 9:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 3:25 [PATCH V4 0/5] Add initial support for MA35D1 SoC Jacky Huang
2022-05-10 3:25 ` [PATCH V4 1/5] dt-bindings: clock: add binding for MA35D1 clock controller Jacky Huang
2022-05-10 3:25 ` [PATCH V4 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings Jacky Huang
2022-05-12 14:04 ` Krzysztof Kozlowski
2022-05-13 6:25 ` Jacky Huang
2022-05-13 6:54 ` Krzysztof Kozlowski
2022-05-10 3:25 ` [PATCH V4 3/5] arm64: dts: nuvoton: Add initial support for MA35D1 Jacky Huang
2022-05-10 7:01 ` Arnd Bergmann
2022-05-10 8:50 ` Jacky Huang
2022-05-12 14:10 ` Krzysztof Kozlowski
2022-05-13 6:48 ` Jacky Huang
2022-05-13 6:57 ` Krzysztof Kozlowski
2022-05-15 5:53 ` Jacky Huang
2022-05-15 9:54 ` Krzysztof Kozlowski [this message]
2022-05-10 3:25 ` [PATCH V4 4/5] arm64: Kconfig: nuvoton: Introduce CONFIG_ARCH_NUVOTON Jacky Huang
2022-05-10 3:25 ` [PATCH V4 5/5] dt-bindings: arm: Add initial bindings for Nuvoton Platform Jacky Huang
2022-05-11 15:23 ` Rob Herring
2022-05-10 7:07 ` [PATCH V4 0/5] Add initial support for MA35D1 SoC Arnd Bergmann
2022-05-10 8:40 ` Jacky Huang
2022-05-10 12:45 ` Arnd Bergmann
2022-05-11 2:31 ` Jacky Huang
2022-05-12 14:11 ` Krzysztof Kozlowski
2022-05-12 14:35 ` Arnd Bergmann
2022-05-13 6:53 ` Jacky Huang
2022-05-13 6:55 ` Krzysztof Kozlowski
2022-05-13 7:00 ` Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3b8a28d-087f-f973-17db-da9c0fed10dd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cfli0@nuvoton.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
--cc=ychuang3@nuvoton.com \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).