linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacky Huang <ychuang3@nuvoton.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	DTML <devicetree@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	<ychuang570808@gmail.com>, "Rob Herring" <robh+dt@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	Olof Johansson <olof@lixom.net>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, SoC Team <soc@kernel.org>,
	<cfli0@nuvoton.com>
Subject: Re: [PATCH V4 3/5] arm64: dts: nuvoton: Add initial support for MA35D1
Date: Tue, 10 May 2022 16:50:17 +0800	[thread overview]
Message-ID: <47b7ec9f-1ed5-642e-5acc-b1398ca31774@nuvoton.com> (raw)
In-Reply-To: <CAK8P3a1tbvE+PTB-qy2y7o3_i3VP0zkgMueDy3zBd64BsGKssw@mail.gmail.com>



On 2022/5/10 下午 03:01, Arnd Bergmann wrote:
> On Tue, May 10, 2022 at 5:25 AM Jacky Huang <ychuang3@nuvoton.com> wrote:
>> Add the initial device tree files for Nuvoton MA35D1 Soc.
>>
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>> ---
>> +
>> +/ {
>> +       model = "Nuvoton MA35D1-EVB";
>> +       compatible = "nuvoton,ma35d1-evb", "nuvoton,ma35d1";
>> +
>> +       chosen {
>> +               stdout-path = "serial0:115200n8";
>> +       };
> Something seems to be missing here: you set the console to the serial0
> alias, but that is not defined anywhere, and the ma35d1.dtsi file does not
> appear to define any UART at all. Are you still missing the driver for this?
>
> Please add a more detailed description in the changelog text above that
> explains what kind of SoC this is (maybe a link to the product web page,
> if there is one), and a status of how complete the support is: which drivers
> are already merged, and which ones are still being worked on?
>
>          Arnd

Hi Arnd,

The serial driver is ready 
(https://github.com/OpenNuvoton/MA35D1_linux-5.4.y/blob/master/drivers/tty/serial/ma35d1_serial.c),
but we have to review the coding style and porting it from Linux 5.4.y 
to 5.18.

In the next patch version, I will added a brief introduction about 
MA35D1 in the cover-letter [PATCH 0/5].

Thanks for your review.

Sincerely,
Jacky Huang




  reply	other threads:[~2022-05-10  8:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10  3:25 [PATCH V4 0/5] Add initial support for MA35D1 SoC Jacky Huang
2022-05-10  3:25 ` [PATCH V4 1/5] dt-bindings: clock: add binding for MA35D1 clock controller Jacky Huang
2022-05-10  3:25 ` [PATCH V4 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings Jacky Huang
2022-05-12 14:04   ` Krzysztof Kozlowski
2022-05-13  6:25     ` Jacky Huang
2022-05-13  6:54       ` Krzysztof Kozlowski
2022-05-10  3:25 ` [PATCH V4 3/5] arm64: dts: nuvoton: Add initial support for MA35D1 Jacky Huang
2022-05-10  7:01   ` Arnd Bergmann
2022-05-10  8:50     ` Jacky Huang [this message]
2022-05-12 14:10   ` Krzysztof Kozlowski
2022-05-13  6:48     ` Jacky Huang
2022-05-13  6:57       ` Krzysztof Kozlowski
2022-05-15  5:53         ` Jacky Huang
2022-05-15  9:54           ` Krzysztof Kozlowski
2022-05-10  3:25 ` [PATCH V4 4/5] arm64: Kconfig: nuvoton: Introduce CONFIG_ARCH_NUVOTON Jacky Huang
2022-05-10  3:25 ` [PATCH V4 5/5] dt-bindings: arm: Add initial bindings for Nuvoton Platform Jacky Huang
2022-05-11 15:23   ` Rob Herring
2022-05-10  7:07 ` [PATCH V4 0/5] Add initial support for MA35D1 SoC Arnd Bergmann
2022-05-10  8:40   ` Jacky Huang
2022-05-10 12:45     ` Arnd Bergmann
2022-05-11  2:31       ` Jacky Huang
2022-05-12 14:11   ` Krzysztof Kozlowski
2022-05-12 14:35     ` Arnd Bergmann
2022-05-13  6:53       ` Jacky Huang
2022-05-13  6:55         ` Krzysztof Kozlowski
2022-05-13  7:00           ` Jacky Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47b7ec9f-1ed5-642e-5acc-b1398ca31774@nuvoton.com \
    --to=ychuang3@nuvoton.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=cfli0@nuvoton.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=soc@kernel.org \
    --cc=will@kernel.org \
    --cc=ychuang570808@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).