From: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy@lists.linux.dev, vireshk@kernel.org, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis
Date: Sat, 11 Mar 2023 16:06:51 +0200 [thread overview]
Message-ID: <27dfe880-35f7-cbc1-cf8b-7bbd7f1c7301@gmail.com> (raw)
In-Reply-To: <61dab579-f10b-5538-8b61-ebe73ae5b4f1@gmail.com>
On ١١/٣/٢٠٢٣ ١٤:٥٧, Menna Mahmoud wrote:
>
> On ١١/٣/٢٠٢٣ ١٤:٥٥, Julia Lawall wrote:
>>
>> On Sat, 11 Mar 2023, Menna Mahmoud wrote:
>>
>>> On ١١/٣/٢٠٢٣ ١٠:٥٩, Julia Lawall wrote:
>>>> On Fri, 10 Mar 2023, Menna Mahmoud wrote:
>>>>
>>>>> Fix " CHECK: Alignment should match open parenthesis "
>>>>> Reported by checkpath
>>>> See the message in the other mail about the log message.
>>>>
>>>> Also, you should not have two patches with the same subject. Here,
>>>> the
>>>> changes are on the same file and are essentially the same, even
>>>> involving
>>>> the same function call. So they can be together in one patch.
>>>>
>>>> julia
>>> okay, I will. appreciate your feedback. thanks.
>> Please put some blank lines around your response, so it is easier to
>> find.
>>
>> thanks,
>> julia
>
>
> Okay, I will.
>
> thanks,
>
> Menna
Hi Julia,
according to Alex feedback
" I think this type of alignment is not a major problem,
and alignment isn't done this way in general in this
driver, it's probably OK to keep it that way. - Alex "
,I won't resubmit these patches, right?
-Menna
>
>
>>>>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>>>>> ---
>>>>> drivers/staging/greybus/fw-core.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/staging/greybus/fw-core.c
>>>>> b/drivers/staging/greybus/fw-core.c
>>>>> index 57bebf24636b..f562cb12d5ad 100644
>>>>> --- a/drivers/staging/greybus/fw-core.c
>>>>> +++ b/drivers/staging/greybus/fw-core.c
>>>>> @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle
>>>>> *bundle,
>>>>> }
>>>>>
>>>>> connection = gb_connection_create(bundle, cport_id,
>>>>> - gb_fw_mgmt_request_handler);
>>>>> +
>>>>> gb_fw_mgmt_request_handler);
>>>>> if (IS_ERR(connection)) {
>>>>> ret = PTR_ERR(connection);
>>>>> dev_err(&bundle->dev,
>>>>> --
>>>>> 2.34.1
>>>>>
>>>>>
>>>>>
>> >
next prev parent reply other threads:[~2023-03-11 14:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 15:51 [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis Menna Mahmoud
2023-03-10 15:51 ` [PATCH 2/2] " Menna Mahmoud
2023-03-11 8:57 ` Julia Lawall
2023-03-11 12:50 ` Menna Mahmoud
2023-03-10 16:16 ` [PATCH 1/2] " Alex Elder
2023-03-10 19:29 ` Menna Mahmoud
2023-03-11 8:59 ` Julia Lawall
2023-03-11 12:52 ` Menna Mahmoud
2023-03-11 12:55 ` Julia Lawall
2023-03-11 12:57 ` Menna Mahmoud
2023-03-11 14:06 ` Menna Mahmoud [this message]
2023-03-11 14:23 ` Dan Carpenter
2023-03-11 14:26 ` Dan Carpenter
2023-03-11 14:57 ` Menna Mahmoud
2023-03-11 14:38 ` Julia Lawall
2023-03-11 14:58 ` Menna Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27dfe880-35f7-cbc1-cf8b-7bbd7f1c7301@gmail.com \
--to=eng.mennamahmoud.mm@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).