Re: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis

From: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Julia Lawall <julia.lawall@inria.fr>,
	outreachy@lists.linux.dev, vireshk@kernel.org, johan@kernel.org,
	elder@kernel.org, gregkh@linuxfoundation.org,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis
Date: Sat, 11 Mar 2023 16:57:29 +0200	[thread overview]
Message-ID: <59077252-02e4-dd43-77b5-2d2cfd114762@gmail.com> (raw)
In-Reply-To: <e0d7928e-854e-4d10-a90f-db87a7d60569@kili.mountain>

On ١١‏/٣‏/٢٠٢٣ ١٦:٢٣, Dan Carpenter wrote:
> On Sat, Mar 11, 2023 at 04:06:51PM +0200, Menna Mahmoud wrote:
>> according to Alex feedback
>>
>> " I think this type of alignment is not a major problem,
>> and alignment isn't done this way in general in this
>> driver, it's probably OK to keep it that way. - Alex "
>>
>>
>> ,I won't resubmit these patches, right?
> Yeah.  Find something else to fix.
>
> I feel like in outreachy and similar that people send a first patch and
> then they get a bunch of different feedback.  And it's like checkpatch
> is complaining and it's staging code so probably the code is actually
> ugly in a way.  But often it's better to abandon the project instead of
> getting obsessed with it.  Zoom out a bit.  Find something else where
> it's obvious how to improve the code from a readability perspective.
>
> People are giving you feedback to help you and not because they are
> about that particular line of code.  They won't care if you work on
> something else instead.
>
> regards,
> dan carpenter

Got it, thanks Dan.

>