From: Julia Lawall <julia.lawall@inria.fr>
To: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
Cc: outreachy@lists.linux.dev, vireshk@kernel.org, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: greybus: Fix Alignment with parenthesis
Date: Sat, 11 Mar 2023 09:57:45 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2303110956591.2802@hadrien> (raw)
In-Reply-To: <ccd27442c1ad9a33b0b7564176fa68f7b153fa20.1678462486.git.eng.mennamahmoud.mm@gmail.com>
On Fri, 10 Mar 2023, Menna Mahmoud wrote:
> Fix " CHECK: Alignment should match open parenthesis "
> Reported by checkpath
The log message could be better, to explain what you have done and why.
The word "fix" doesn't express any of that, and should be avoided if
possible.
julia
>
> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
> ---
> drivers/staging/greybus/fw-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c
> index f562cb12d5ad..0fb15a60412f 100644
> --- a/drivers/staging/greybus/fw-core.c
> +++ b/drivers/staging/greybus/fw-core.c
> @@ -110,7 +110,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle,
> }
>
> connection = gb_connection_create(bundle, cport_id,
> - gb_fw_download_request_handler);
> + gb_fw_download_request_handler);
> if (IS_ERR(connection)) {
> dev_err(&bundle->dev, "failed to create download connection (%ld)\n",
> PTR_ERR(connection));
> --
> 2.34.1
>
>
>
next prev parent reply other threads:[~2023-03-11 8:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 15:51 [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis Menna Mahmoud
2023-03-10 15:51 ` [PATCH 2/2] " Menna Mahmoud
2023-03-11 8:57 ` Julia Lawall [this message]
2023-03-11 12:50 ` Menna Mahmoud
2023-03-10 16:16 ` [PATCH 1/2] " Alex Elder
2023-03-10 19:29 ` Menna Mahmoud
2023-03-11 8:59 ` Julia Lawall
2023-03-11 12:52 ` Menna Mahmoud
2023-03-11 12:55 ` Julia Lawall
2023-03-11 12:57 ` Menna Mahmoud
2023-03-11 14:06 ` Menna Mahmoud
2023-03-11 14:23 ` Dan Carpenter
2023-03-11 14:26 ` Dan Carpenter
2023-03-11 14:57 ` Menna Mahmoud
2023-03-11 14:38 ` Julia Lawall
2023-03-11 14:58 ` Menna Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2303110956591.2802@hadrien \
--to=julia.lawall@inria.fr \
--cc=elder@kernel.org \
--cc=eng.mennamahmoud.mm@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).