From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "andy@kernel.org" <andy@kernel.org>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"javierm@redhat.com" <javierm@redhat.com>,
"robin@protonic.nl" <robin@protonic.nl>,
"lee@kernel.org" <lee@kernel.org>, "pavel@ucw.cz" <pavel@ucw.cz>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 0/4] auxdisplay: 7 segment LED display
Date: Wed, 28 Feb 2024 00:25:30 +0000 [thread overview]
Message-ID: <2ad735ed-963c-4e75-b83e-687ea2c0aef5@alliedtelesis.co.nz> (raw)
In-Reply-To: <CAHp75Vc7yFX6TLhc0ADx+76_+2Li=WgQiSqpcwkFSpP3pPdC5Q@mail.gmail.com>
On 28/02/24 13:05, Andy Shevchenko wrote:
> On Tue, Feb 27, 2024 at 11:22 PM Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
>> This series adds a driver for a 7 segment LED display.
>>
>> At this point I've decided not to pursue supporting >1 character. I had
>> a look at what would be required to add a devm_fwnode_gpiod_get_array()
>> and got bogged down in OF and ACPI code for counting GPIOs.
> Out of curiosity, why did it happen? gpiod_count() works in an agnostic way.
>
At first I though I could create a fwnode_gpiod_count() out of the body
of gpiod_count(). But both of_gpio_get_count() and acpi_gpio_count()
take the dev not the fwnode. It looks like gpiod_count() (and
of_gpio_spi_cs_get_count()) could probably be re-written (or abstracted)
to take the device_node instead of the device. I started looking at
acpi_gpio_count() but I couldn't quite see how I could adapt this.
I'm definitely not saying it can't be done. Just that you probably don't
want an occasional contributor like me messing with some of these core
device abstractions.
next prev parent reply other threads:[~2024-02-28 0:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 21:22 [PATCH v2 0/4] auxdisplay: 7 segment LED display Chris Packham
2024-02-27 21:22 ` [PATCH v2 1/4] auxdisplay: Add 7 segment LED display driver Chris Packham
2024-02-27 22:13 ` Randy Dunlap
2024-02-27 23:56 ` Andy Shevchenko
2024-02-27 21:22 ` [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED Chris Packham
2024-02-27 22:19 ` Rob Herring
2024-02-28 0:03 ` Andy Shevchenko
2024-02-28 1:53 ` Chris Packham
2024-02-28 17:22 ` Andy Shevchenko
2024-02-28 14:04 ` Rob Herring
2024-02-28 14:57 ` Andy Shevchenko
2024-02-29 9:23 ` Geert Uytterhoeven
2024-02-29 10:42 ` Andy Shevchenko
2024-02-28 20:01 ` Chris Packham
2024-02-29 9:24 ` Geert Uytterhoeven
2024-02-29 10:44 ` andy
2024-02-27 21:22 ` [PATCH v2 3/4] ARM: dts: marvell: Add 7 segment LED display on x530 Chris Packham
2024-02-28 0:12 ` Andy Shevchenko
2024-02-27 21:22 ` [PATCH v2 4/4] ARM: dts: marvell: Indicate USB activity " Chris Packham
2024-02-28 0:09 ` Andy Shevchenko
2024-02-28 1:11 ` Chris Packham
2024-02-28 0:05 ` [PATCH v2 0/4] auxdisplay: 7 segment LED display Andy Shevchenko
2024-02-28 0:25 ` Chris Packham [this message]
2024-02-28 18:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ad735ed-963c-4e75-b83e-687ea2c0aef5@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregory.clement@bootlin.com \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).