From: "andy@kernel.org" <andy@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
Rob Herring <robh@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"javierm@redhat.com" <javierm@redhat.com>,
"robin@protonic.nl" <robin@protonic.nl>,
"lee@kernel.org" <lee@kernel.org>, "pavel@ucw.cz" <pavel@ucw.cz>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED
Date: Thu, 29 Feb 2024 12:44:25 +0200 [thread overview]
Message-ID: <ZeBgCSsO0FH1jb7h@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdXJT5THun7XG8ig746Bh+paAP5uSMg33aa=Csui4Dkb4g@mail.gmail.com>
On Thu, Feb 29, 2024 at 10:24:33AM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 28, 2024 at 9:02 PM Chris Packham
> <Chris.Packham@alliedtelesis.co.nz> wrote:
> > On 29/02/24 03:04, Rob Herring wrote:
> > > On Wed, Feb 28, 2024 at 10:22:42AM +1300, Chris Packham wrote:
...
> > > How does one know which GPIO is which segment?
> >
> > I've expanded the description in v3.
> >
> > + An array of GPIOs one per segment. The first GPIO corresponds to the A
> > + segment the last GPIO corresponds to the G segment.
> >
> > Do you think that's sufficient or do I need to add more? In the driver
> > itself I've put a little ascii art diagram of the segments.
>
> Given users are reading the bindings rather than the driver source,
> I would move the diagram to the bindings.
+1 here. We have a diagram already in UAPI headers, but that won't be (quickly)
visible for the real users, duplicating in the code doesn't add any value, but
adding it to DT description will be beneficial.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-29 10:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 21:22 [PATCH v2 0/4] auxdisplay: 7 segment LED display Chris Packham
2024-02-27 21:22 ` [PATCH v2 1/4] auxdisplay: Add 7 segment LED display driver Chris Packham
2024-02-27 22:13 ` Randy Dunlap
2024-02-27 23:56 ` Andy Shevchenko
2024-02-27 21:22 ` [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED Chris Packham
2024-02-27 22:19 ` Rob Herring
2024-02-28 0:03 ` Andy Shevchenko
2024-02-28 1:53 ` Chris Packham
2024-02-28 17:22 ` Andy Shevchenko
2024-02-28 14:04 ` Rob Herring
2024-02-28 14:57 ` Andy Shevchenko
2024-02-29 9:23 ` Geert Uytterhoeven
2024-02-29 10:42 ` Andy Shevchenko
2024-02-28 20:01 ` Chris Packham
2024-02-29 9:24 ` Geert Uytterhoeven
2024-02-29 10:44 ` andy [this message]
2024-02-27 21:22 ` [PATCH v2 3/4] ARM: dts: marvell: Add 7 segment LED display on x530 Chris Packham
2024-02-28 0:12 ` Andy Shevchenko
2024-02-27 21:22 ` [PATCH v2 4/4] ARM: dts: marvell: Indicate USB activity " Chris Packham
2024-02-28 0:09 ` Andy Shevchenko
2024-02-28 1:11 ` Chris Packham
2024-02-28 0:05 ` [PATCH v2 0/4] auxdisplay: 7 segment LED display Andy Shevchenko
2024-02-28 0:25 ` Chris Packham
2024-02-28 18:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeBgCSsO0FH1jb7h@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregory.clement@bootlin.com \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=robin@protonic.nl \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).