From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: andy@kernel.org, geert@linux-m68k.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, ojeda@kernel.org,
tzimmermann@suse.de, javierm@redhat.com, robin@protonic.nl,
lee@kernel.org, pavel@ucw.cz, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED
Date: Wed, 28 Feb 2024 02:03:59 +0200 [thread overview]
Message-ID: <CAHp75Vdi2c=s_z9wwxWzVcL+4tx5ZnXymbiN4O1FS+D3kz5vqw@mail.gmail.com> (raw)
In-Reply-To: <20240227212244.262710-3-chris.packham@alliedtelesis.co.nz>
On Tue, Feb 27, 2024 at 11:22 PM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
...
> + segment-gpios:
> + description:
> + An array of GPIOs one per segment.
This is a vague description. Please explain the order (e.g., LSB =
'a', MSB = 'g'), use of DP (optional?), etc.
> + minItems: 7
maxItems?
...
> + led-7seg {
Probably it should be more human readable. DT people might suggest
something better.
> + compatible = "generic-gpio-7seg";
> + segment-gpios = <&gpio 0 GPIO_ACTIVE_LOW
> + &gpio 1 GPIO_ACTIVE_LOW
> + &gpio 2 GPIO_ACTIVE_LOW
> + &gpio 3 GPIO_ACTIVE_LOW
> + &gpio 4 GPIO_ACTIVE_LOW
> + &gpio 5 GPIO_ACTIVE_LOW
> + &gpio 6 GPIO_ACTIVE_LOW>;
Dunno how to handle DP. Either we always expect it to be here (as
placeholder) or with additional property.
> + };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-28 0:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 21:22 [PATCH v2 0/4] auxdisplay: 7 segment LED display Chris Packham
2024-02-27 21:22 ` [PATCH v2 1/4] auxdisplay: Add 7 segment LED display driver Chris Packham
2024-02-27 22:13 ` Randy Dunlap
2024-02-27 23:56 ` Andy Shevchenko
2024-02-27 21:22 ` [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED Chris Packham
2024-02-27 22:19 ` Rob Herring
2024-02-28 0:03 ` Andy Shevchenko [this message]
2024-02-28 1:53 ` Chris Packham
2024-02-28 17:22 ` Andy Shevchenko
2024-02-28 14:04 ` Rob Herring
2024-02-28 14:57 ` Andy Shevchenko
2024-02-29 9:23 ` Geert Uytterhoeven
2024-02-29 10:42 ` Andy Shevchenko
2024-02-28 20:01 ` Chris Packham
2024-02-29 9:24 ` Geert Uytterhoeven
2024-02-29 10:44 ` andy
2024-02-27 21:22 ` [PATCH v2 3/4] ARM: dts: marvell: Add 7 segment LED display on x530 Chris Packham
2024-02-28 0:12 ` Andy Shevchenko
2024-02-27 21:22 ` [PATCH v2 4/4] ARM: dts: marvell: Indicate USB activity " Chris Packham
2024-02-28 0:09 ` Andy Shevchenko
2024-02-28 1:11 ` Chris Packham
2024-02-28 0:05 ` [PATCH v2 0/4] auxdisplay: 7 segment LED display Andy Shevchenko
2024-02-28 0:25 ` Chris Packham
2024-02-28 18:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vdi2c=s_z9wwxWzVcL+4tx5ZnXymbiN4O1FS+D3kz5vqw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregory.clement@bootlin.com \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).