linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jason A . Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
	"Thomas Gleixner" <tglx@linutronix.de>,
	linux-crypto@vger.kernel.org, linux-api@vger.kernel.org,
	x86@kernel.org, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Adhemerval Zanella Netto" <adhemerval.zanella@linaro.org>,
	"Carlos O'Donell" <carlos@redhat.com>,
	"Florian Weimer" <fweimer@redhat.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Samuel Neves" <sneves@dei.uc.pt>
Subject: Re: [PATCH v8 3/3] x86: vdso: Wire up getrandom() vDSO implementation
Date: Mon, 28 Nov 2022 22:12:45 +0100	[thread overview]
Message-ID: <2cb4b4a7-1d39-4f63-aee0-b4fc43efa68d@app.fastmail.com> (raw)
In-Reply-To: <CAHmME9rp+Nx_S8OgABzadc1+j_FrSRbUvGu2r9W_svrr+HMjSg@mail.gmail.com>

On Mon, Nov 28, 2022, at 21:02, Jason A. Donenfeld wrote:
> On Mon, Nov 28, 2022 at 8:57 PM Arnd Bergmann <arnd@arndb.de> wrote:

> Okay, I can split it that way. If I gather your meaning correctly:
>
> 1) generic syscall C code
> 2) #define __NR_... in asm-generic/unistd.h x86/.../unistd.h,
> x86/.../syscall_64.tbl

I mean all syscall*.tbl files, not just x86. There are currently
eight architectures using asm-generic/unistd.h, the rest use
syscall.tbl.

> 3) generic vdso C code
> 4) hook up x86 vdso, and select the right Kconfig symbol to start
> compiling the code
>
> Is that what you have in mind? If so, I'll name (2) "arch: wire up
> vgetrandom_alloc() syscall number".

That sounds good, yes.

      Arnd

  parent reply	other threads:[~2022-11-28 21:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 11:18 [PATCH v8 0/3] implement getrandom() in vDSO Jason A. Donenfeld
2022-11-28 11:18 ` [PATCH v8 1/3] random: add vgetrandom_alloc() syscall Jason A. Donenfeld
2022-11-28 11:18 ` [PATCH v8 2/3] random: introduce generic vDSO getrandom() implementation Jason A. Donenfeld
2022-11-28 11:18 ` [PATCH v8 3/3] x86: vdso: Wire up getrandom() vDSO implementation Jason A. Donenfeld
2022-11-28 19:18   ` Arnd Bergmann
2022-11-28 19:23     ` Jason A. Donenfeld
2022-11-28 19:57       ` Arnd Bergmann
2022-11-28 20:02         ` Jason A. Donenfeld
2022-11-28 20:41           ` Jason A. Donenfeld
2022-11-28 21:12           ` Arnd Bergmann [this message]
2022-11-28 21:29             ` Jason A. Donenfeld
2022-11-28 21:39               ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cb4b4a7-1d39-4f63-aee0-b4fc43efa68d@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=Jason@zx2c4.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=brauner@kernel.org \
    --cc=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=sneves@dei.uc.pt \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).