Re: [PATCH v8 3/3] x86: vdso: Wire up getrandom() vDSO implementation

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-crypto@vger.kernel.org, linux-api@vger.kernel.org,
	x86@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
	Carlos O'Donell <carlos@redhat.com>,
	Florian Weimer <fweimer@redhat.com>,
	Christian Brauner <brauner@kernel.org>,
	Samuel Neves <sneves@dei.uc.pt>
Subject: Re: [PATCH v8 3/3] x86: vdso: Wire up getrandom() vDSO implementation
Date: Mon, 28 Nov 2022 22:39:54 +0100	[thread overview]
Message-ID: <Y4Uqqv4X2j/+dFww@zx2c4.com> (raw)
In-Reply-To: <CAHmME9r6Hqy3KTJoNpXzJ4weUyFs=5xEPQEe94x4hO6QZWo-5g@mail.gmail.com>

On Mon, Nov 28, 2022 at 10:29:29PM +0100, Jason A. Donenfeld wrote:
> On Mon, Nov 28, 2022 at 10:13 PM Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > On Mon, Nov 28, 2022, at 21:02, Jason A. Donenfeld wrote:
> > > On Mon, Nov 28, 2022 at 8:57 PM Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > > Okay, I can split it that way. If I gather your meaning correctly:
> > >
> > > 1) generic syscall C code
> > > 2) #define __NR_... in asm-generic/unistd.h x86/.../unistd.h,
> > > x86/.../syscall_64.tbl
> >
> > I mean all syscall*.tbl files, not just x86. There are currently
> > eight architectures using asm-generic/unistd.h, the rest use
> > syscall.tbl.
> 
> Oh okay, I'll add this to all of the *.tbl files.

Alright, so, it's looking like this now:

commit 16751c0ac4efaf1cefd793a79c469f9d62ddb3ed
Author: Jason A. Donenfeld <Jason@zx2c4.com>
Date:   Mon Nov 28 21:37:14 2022

    arch: allocate vgetrandom_alloc() syscall number

    Add vgetrandom_alloc() as syscall 451 (or 561 on alpha) by adding it to
    all of the various syscall.tbl an unistd.h files.

    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

 arch/alpha/kernel/syscalls/syscall.tbl              | 1 +
 arch/arm/tools/syscall.tbl                          | 1 +
 arch/arm64/include/asm/unistd32.h                   | 2 ++
 arch/ia64/kernel/syscalls/syscall.tbl               | 1 +
 arch/m68k/kernel/syscalls/syscall.tbl               | 1 +
 arch/microblaze/kernel/syscalls/syscall.tbl         | 1 +
 arch/mips/kernel/syscalls/syscall_n32.tbl           | 1 +
 arch/mips/kernel/syscalls/syscall_n64.tbl           | 1 +
 arch/mips/kernel/syscalls/syscall_o32.tbl           | 1 +
 arch/parisc/kernel/syscalls/syscall.tbl             | 1 +
 arch/powerpc/kernel/syscalls/syscall.tbl            | 1 +
 arch/s390/kernel/syscalls/syscall.tbl               | 1 +
 arch/sh/kernel/syscalls/syscall.tbl                 | 1 +
 arch/sparc/kernel/syscalls/syscall.tbl              | 1 +
 arch/x86/entry/syscalls/syscall_32.tbl              | 1 +
 arch/x86/entry/syscalls/syscall_64.tbl              | 1 +
 arch/xtensa/kernel/syscalls/syscall.tbl             | 1 +
 include/uapi/asm-generic/unistd.h                   | 5 ++++-
 tools/include/uapi/asm-generic/unistd.h             | 5 ++++-
 tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl | 1 +
 tools/perf/arch/powerpc/entry/syscalls/syscall.tbl  | 1 +
 tools/perf/arch/s390/entry/syscalls/syscall.tbl     | 1 +
 tools/perf/arch/x86/entry/syscalls/syscall_64.tbl   | 1 +
 23 files changed, 30 insertions(+), 2 deletions(-)