From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jason A . Donenfeld" <Jason@zx2c4.com>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
"Thomas Gleixner" <tglx@linutronix.de>
Cc: linux-crypto@vger.kernel.org, linux-api@vger.kernel.org,
x86@kernel.org, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Adhemerval Zanella Netto" <adhemerval.zanella@linaro.org>,
"Carlos O'Donell" <carlos@redhat.com>,
"Florian Weimer" <fweimer@redhat.com>,
"Christian Brauner" <brauner@kernel.org>,
"Samuel Neves" <sneves@dei.uc.pt>
Subject: Re: [PATCH v8 3/3] x86: vdso: Wire up getrandom() vDSO implementation
Date: Mon, 28 Nov 2022 20:18:12 +0100 [thread overview]
Message-ID: <8f9326ba-f879-4b9e-9e5d-b65cad7cd726@app.fastmail.com> (raw)
In-Reply-To: <20221128111829.2477505-4-Jason@zx2c4.com>
On Mon, Nov 28, 2022, at 12:18, Jason A. Donenfeld wrote:
> Hook up the generic vDSO implementation to the x86 vDSO data page. Since
> the existing vDSO infrastructure is heavily based on the timekeeping
> functionality, which works over arrays of bases, a new macro is
> introduced for vvars that are not arrays.
>
> Also enable the vgetrandom_alloc() syscall, which the vDSO
> implementation relies on.
>
> The vDSO function requires a ChaCha20 implementation that does not write
> to the stack, yet can still do an entire ChaCha20 permutation, so
> provide this using SSE2, since this is userland code that must work on
> all x86-64 processors.
>
> Reviewed-by: Samuel Neves <sneves@dei.uc.pt> # for vgetrandom-chacha.S
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> arch/x86/Kconfig | 1 +
> arch/x86/entry/syscalls/syscall_64.tbl | 1 +
I see that this enables the syscall in x86-64, while patch 1
adds it to the eight architecures that use
include/uapi/asm-generic/unistd.h (with the __ARCH_WANT_*
guard at the moment, but you already said that will be removed)
I think ideally the syscall.tbl and unistd.h changes should be done
in one patch for all architectures that doesn't mix it with
any other changes. In particular I think it should be separate
from the vdso changes, but could be in the patch that implements
the syscall.
Arnd
next prev parent reply other threads:[~2022-11-28 19:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 11:18 [PATCH v8 0/3] implement getrandom() in vDSO Jason A. Donenfeld
2022-11-28 11:18 ` [PATCH v8 1/3] random: add vgetrandom_alloc() syscall Jason A. Donenfeld
2022-11-28 11:18 ` [PATCH v8 2/3] random: introduce generic vDSO getrandom() implementation Jason A. Donenfeld
2022-11-28 11:18 ` [PATCH v8 3/3] x86: vdso: Wire up getrandom() vDSO implementation Jason A. Donenfeld
2022-11-28 19:18 ` Arnd Bergmann [this message]
2022-11-28 19:23 ` Jason A. Donenfeld
2022-11-28 19:57 ` Arnd Bergmann
2022-11-28 20:02 ` Jason A. Donenfeld
2022-11-28 20:41 ` Jason A. Donenfeld
2022-11-28 21:12 ` Arnd Bergmann
2022-11-28 21:29 ` Jason A. Donenfeld
2022-11-28 21:39 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f9326ba-f879-4b9e-9e5d-b65cad7cd726@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Jason@zx2c4.com \
--cc=adhemerval.zanella@linaro.org \
--cc=brauner@kernel.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=sneves@dei.uc.pt \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).