From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, airlied@linux.ie,
daniel.vetter@intel.com, seanpaul@chromium.org,
gustavo@padovan.org, jgross@suse.com, konrad.wilk@oracle.com
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH 8/9] drm/xen-front: Implement GEM operations
Date: Fri, 23 Feb 2018 10:26:56 -0500 [thread overview]
Message-ID: <2f2c6fea-c0cb-e244-41f3-269db07986fc@oracle.com> (raw)
In-Reply-To: <1519200222-20623-9-git-send-email-andr2000@gmail.com>
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote:
> +static struct xen_gem_object *gem_create(struct drm_device *dev, size_t size)
> +{
> + struct xen_drm_front_drm_info *drm_info = dev->dev_private;
> + struct xen_gem_object *xen_obj;
> + int ret;
> +
> + size = round_up(size, PAGE_SIZE);
> + xen_obj = gem_create_obj(dev, size);
> + if (IS_ERR_OR_NULL(xen_obj))
> + return xen_obj;
> +
> + if (drm_info->cfg->be_alloc) {
> + /*
> + * backend will allocate space for this buffer, so
> + * only allocate array of pointers to pages
> + */
> + xen_obj->be_alloc = true;
If be_alloc is a flag (which I am not sure about) --- should it be set
to true *after* you've successfully allocated your things?
> + ret = gem_alloc_pages_array(xen_obj, size);
> + if (ret < 0) {
> + gem_free_pages_array(xen_obj);
> + goto fail;
> + }
> +
> + ret = alloc_xenballooned_pages(xen_obj->num_pages,
> + xen_obj->pages);
Why are you allocating balloon pages?
-boris
> + if (ret < 0) {
> + DRM_ERROR("Cannot allocate %zu ballooned pages: %d\n",
> + xen_obj->num_pages, ret);
> + goto fail;
> + }
> +
> + return xen_obj;
> + }
> + /*
> + * need to allocate backing pages now, so we can share those
> + * with the backend
> + */
> + xen_obj->num_pages = DIV_ROUND_UP(size, PAGE_SIZE);
> + xen_obj->pages = drm_gem_get_pages(&xen_obj->base);
> + if (IS_ERR_OR_NULL(xen_obj->pages)) {
> + ret = PTR_ERR(xen_obj->pages);
> + xen_obj->pages = NULL;
> + goto fail;
> + }
> +
> + return xen_obj;
> +
> +fail:
> + DRM_ERROR("Failed to allocate buffer with size %zu\n", size);
> + return ERR_PTR(ret);
> +}
> +
>
next prev parent reply other threads:[~2018-02-23 15:26 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 8:03 [PATCH 0/9] drm/xen-front: Add support for Xen PV display frontend Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver Oleksandr Andrushchenko
2018-02-21 8:19 ` Juergen Gross
2018-02-21 8:47 ` Oleksandr Andrushchenko
2018-02-21 9:09 ` Juergen Gross
2018-02-21 9:11 ` Oleksandr Andrushchenko
2018-02-21 9:17 ` [Xen-devel] " Roger Pau Monné
2018-02-21 9:42 ` Oleksandr Andrushchenko
2018-02-21 10:19 ` Roger Pau Monné
2018-02-21 10:25 ` Oleksandr Andrushchenko
2018-02-22 22:23 ` Boris Ostrovsky
2018-02-23 6:37 ` Oleksandr Andrushchenko
2018-02-23 14:39 ` Boris Ostrovsky
2018-02-23 14:51 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 2/9] drm/xen-front: Implement Xen bus state handling Oleksandr Andrushchenko
2018-02-21 8:23 ` Juergen Gross
2018-02-21 8:50 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 3/9] drm/xen-front: Read driver configuration from Xen store Oleksandr Andrushchenko
2018-02-22 23:20 ` Boris Ostrovsky
2018-02-23 6:46 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 4/9] drm/xen-front: Implement Xen event channel handling Oleksandr Andrushchenko
2018-02-22 23:50 ` Boris Ostrovsky
2018-02-23 7:00 ` Oleksandr Andrushchenko
2018-02-23 14:44 ` Boris Ostrovsky
2018-02-23 14:49 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers Oleksandr Andrushchenko
2018-02-23 0:25 ` Boris Ostrovsky
2018-02-23 7:53 ` Oleksandr Andrushchenko
2018-02-23 14:36 ` Boris Ostrovsky
2018-02-23 14:45 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 6/9] drm/xen-front: Introduce DRM/KMS virtual display driver Oleksandr Andrushchenko
2018-02-23 15:12 ` Boris Ostrovsky
2018-02-23 15:19 ` Oleksandr Andrushchenko
2018-03-05 9:13 ` Daniel Vetter
2018-03-05 9:19 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 7/9] drm/xen-front: Implement KMS/connector handling Oleksandr Andrushchenko
2018-03-05 9:23 ` Daniel Vetter
2018-03-05 12:59 ` Oleksandr Andrushchenko
2018-03-06 7:22 ` Daniel Vetter
2018-03-06 7:29 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 8/9] drm/xen-front: Implement GEM operations Oleksandr Andrushchenko
2018-02-23 15:26 ` Boris Ostrovsky [this message]
2018-02-23 15:35 ` Oleksandr Andrushchenko
2018-02-26 23:47 ` Boris Ostrovsky
2018-02-27 6:52 ` Oleksandr Andrushchenko
2018-02-28 19:46 ` Boris Ostrovsky
2018-02-28 19:52 ` Oleksandr Andrushchenko
2018-03-05 9:32 ` Daniel Vetter
2018-03-05 13:46 ` Oleksandr Andrushchenko
2018-03-06 7:26 ` Daniel Vetter
2018-03-06 7:43 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 9/9] drm/xen-front: Implement communication with backend Oleksandr Andrushchenko
2018-03-05 9:25 ` Daniel Vetter
2018-03-05 9:30 ` Oleksandr Andrushchenko
2018-03-06 9:26 ` Daniel Vetter
2018-03-06 9:45 ` Oleksandr Andrushchenko
2018-02-26 8:21 ` [PATCH 0/9] drm/xen-front: Add support for Xen PV display frontend Oleksandr Andrushchenko
2018-02-27 12:40 ` Oleksandr Andrushchenko
2018-02-28 14:08 ` [Xen-devel] " Julien Grall
2018-03-01 1:42 ` Stefano Stabellini
2018-03-01 8:26 ` Gerd Hoffmann
2018-03-01 8:49 ` Oleksandr Andrushchenko
2018-03-01 1:14 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f2c6fea-c0cb-e244-41f3-269db07986fc@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=airlied@linux.ie \
--cc=andr2000@gmail.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=seanpaul@chromium.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).