From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Juergen Gross <jgross@suse.com>,
Oleksandr Andrushchenko <andr2000@gmail.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, airlied@linux.ie,
daniel.vetter@intel.com, seanpaul@chromium.org,
gustavo@padovan.org, boris.ostrovsky@oracle.com,
konrad.wilk@oracle.com
Subject: Re: [PATCH 2/9] drm/xen-front: Implement Xen bus state handling
Date: Wed, 21 Feb 2018 10:50:01 +0200 [thread overview]
Message-ID: <ca79a556-54bc-4ea7-e708-614269b11d5b@epam.com> (raw)
In-Reply-To: <7b302293-a4ca-0225-576f-0cc33f6f56cb@suse.com>
On 02/21/2018 10:23 AM, Juergen Gross wrote:
> On 21/02/18 09:03, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>
>> Initial handling for Xen bus states: implement
>> Xen bus state machine for the frontend driver according to
>> the state diagram and recovery flow from display para-virtualized
>> protocol: xen/interface/io/displif.h.
>>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>> ---
>> drivers/gpu/drm/xen/xen_drm_front.c | 124 +++++++++++++++++++++++++++++++++++-
>> drivers/gpu/drm/xen/xen_drm_front.h | 26 ++++++++
>> 2 files changed, 149 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/gpu/drm/xen/xen_drm_front.h
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
>> index fd372fb464a1..d0306f9d660d 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
>> @@ -24,19 +24,141 @@
>>
>> #include <xen/interface/io/displif.h>
>>
>> +#include "xen_drm_front.h"
>> +
>> +static void xen_drv_remove_internal(struct xen_drm_front_info *front_info)
>> +{
>> +}
>> +
>> +static int backend_on_initwait(struct xen_drm_front_info *front_info)
>> +{
>> + return 0;
>> +}
>> +
>> +static int backend_on_connected(struct xen_drm_front_info *front_info)
>> +{
>> + return 0;
>> +}
>> +
>> +static void backend_on_disconnected(struct xen_drm_front_info *front_info)
>> +{
>> + xenbus_switch_state(front_info->xb_dev, XenbusStateInitialising);
>> +}
>> +
>> static void backend_on_changed(struct xenbus_device *xb_dev,
>> enum xenbus_state backend_state)
>> {
>> + struct xen_drm_front_info *front_info = dev_get_drvdata(&xb_dev->dev);
>> + int ret;
>> +
>> + DRM_DEBUG("Backend state is %s, front is %s\n",
>> + xenbus_strstate(backend_state),
>> + xenbus_strstate(xb_dev->state));
>> +
>> + switch (backend_state) {
>> + case XenbusStateReconfiguring:
>> + /* fall through */
>> + case XenbusStateReconfigured:
>> + /* fall through */
>> + case XenbusStateInitialised:
>> + break;
>> +
>> + case XenbusStateInitialising:
>> + /* recovering after backend unexpected closure */
>> + backend_on_disconnected(front_info);
>> + break;
>> +
>> + case XenbusStateInitWait:
>> + /* recovering after backend unexpected closure */
>> + backend_on_disconnected(front_info);
>> + if (xb_dev->state != XenbusStateInitialising)
>> + break;
>> +
>> + ret = backend_on_initwait(front_info);
>> + if (ret < 0)
>> + xenbus_dev_fatal(xb_dev, ret, "initializing frontend");
>> + else
>> + xenbus_switch_state(xb_dev, XenbusStateInitialised);
>> + break;
>> +
>> + case XenbusStateConnected:
>> + if (xb_dev->state != XenbusStateInitialised)
>> + break;
>> +
>> + ret = backend_on_connected(front_info);
>> + if (ret < 0)
>> + xenbus_dev_fatal(xb_dev, ret, "initializing DRM driver");
>> + else
>> + xenbus_switch_state(xb_dev, XenbusStateConnected);
>> + break;
>> +
>> + case XenbusStateClosing:
>> + /*
>> + * in this state backend starts freeing resources,
>> + * so let it go into closed state, so we can also
>> + * remove ours
>> + */
>> + break;
>> +
>> + case XenbusStateUnknown:
>> + /* fall through */
>> + case XenbusStateClosed:
>> + if (xb_dev->state == XenbusStateClosed)
>> + break;
>> +
>> + backend_on_disconnected(front_info);
>> + break;
>> + }
>> }
>>
>> static int xen_drv_probe(struct xenbus_device *xb_dev,
>> const struct xenbus_device_id *id)
>> {
>> - return 0;
>> + struct xen_drm_front_info *front_info;
>> +
>> + front_info = devm_kzalloc(&xb_dev->dev,
>> + sizeof(*front_info), GFP_KERNEL);
>> + if (!front_info) {
>> + xenbus_dev_fatal(xb_dev, -ENOMEM, "allocating device memory");
> No need for message in case of allocation failure: this is
> handled in memory allocation already.
Will remove, thank you
>
> Juergen
next prev parent reply other threads:[~2018-02-21 8:50 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 8:03 [PATCH 0/9] drm/xen-front: Add support for Xen PV display frontend Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver Oleksandr Andrushchenko
2018-02-21 8:19 ` Juergen Gross
2018-02-21 8:47 ` Oleksandr Andrushchenko
2018-02-21 9:09 ` Juergen Gross
2018-02-21 9:11 ` Oleksandr Andrushchenko
2018-02-21 9:17 ` [Xen-devel] " Roger Pau Monné
2018-02-21 9:42 ` Oleksandr Andrushchenko
2018-02-21 10:19 ` Roger Pau Monné
2018-02-21 10:25 ` Oleksandr Andrushchenko
2018-02-22 22:23 ` Boris Ostrovsky
2018-02-23 6:37 ` Oleksandr Andrushchenko
2018-02-23 14:39 ` Boris Ostrovsky
2018-02-23 14:51 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 2/9] drm/xen-front: Implement Xen bus state handling Oleksandr Andrushchenko
2018-02-21 8:23 ` Juergen Gross
2018-02-21 8:50 ` Oleksandr Andrushchenko [this message]
2018-02-21 8:03 ` [PATCH 3/9] drm/xen-front: Read driver configuration from Xen store Oleksandr Andrushchenko
2018-02-22 23:20 ` Boris Ostrovsky
2018-02-23 6:46 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 4/9] drm/xen-front: Implement Xen event channel handling Oleksandr Andrushchenko
2018-02-22 23:50 ` Boris Ostrovsky
2018-02-23 7:00 ` Oleksandr Andrushchenko
2018-02-23 14:44 ` Boris Ostrovsky
2018-02-23 14:49 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers Oleksandr Andrushchenko
2018-02-23 0:25 ` Boris Ostrovsky
2018-02-23 7:53 ` Oleksandr Andrushchenko
2018-02-23 14:36 ` Boris Ostrovsky
2018-02-23 14:45 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 6/9] drm/xen-front: Introduce DRM/KMS virtual display driver Oleksandr Andrushchenko
2018-02-23 15:12 ` Boris Ostrovsky
2018-02-23 15:19 ` Oleksandr Andrushchenko
2018-03-05 9:13 ` Daniel Vetter
2018-03-05 9:19 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 7/9] drm/xen-front: Implement KMS/connector handling Oleksandr Andrushchenko
2018-03-05 9:23 ` Daniel Vetter
2018-03-05 12:59 ` Oleksandr Andrushchenko
2018-03-06 7:22 ` Daniel Vetter
2018-03-06 7:29 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 8/9] drm/xen-front: Implement GEM operations Oleksandr Andrushchenko
2018-02-23 15:26 ` Boris Ostrovsky
2018-02-23 15:35 ` Oleksandr Andrushchenko
2018-02-26 23:47 ` Boris Ostrovsky
2018-02-27 6:52 ` Oleksandr Andrushchenko
2018-02-28 19:46 ` Boris Ostrovsky
2018-02-28 19:52 ` Oleksandr Andrushchenko
2018-03-05 9:32 ` Daniel Vetter
2018-03-05 13:46 ` Oleksandr Andrushchenko
2018-03-06 7:26 ` Daniel Vetter
2018-03-06 7:43 ` Oleksandr Andrushchenko
2018-02-21 8:03 ` [PATCH 9/9] drm/xen-front: Implement communication with backend Oleksandr Andrushchenko
2018-03-05 9:25 ` Daniel Vetter
2018-03-05 9:30 ` Oleksandr Andrushchenko
2018-03-06 9:26 ` Daniel Vetter
2018-03-06 9:45 ` Oleksandr Andrushchenko
2018-02-26 8:21 ` [PATCH 0/9] drm/xen-front: Add support for Xen PV display frontend Oleksandr Andrushchenko
2018-02-27 12:40 ` Oleksandr Andrushchenko
2018-02-28 14:08 ` [Xen-devel] " Julien Grall
2018-03-01 1:42 ` Stefano Stabellini
2018-03-01 8:26 ` Gerd Hoffmann
2018-03-01 8:49 ` Oleksandr Andrushchenko
2018-03-01 1:14 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca79a556-54bc-4ea7-e708-614269b11d5b@epam.com \
--to=oleksandr_andrushchenko@epam.com \
--cc=airlied@linux.ie \
--cc=andr2000@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).