linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH char-misc-next 0/2] misc: mic: bug fixes
@ 2015-06-10  3:58 Sudeep Dutt
  2015-06-10  3:58 ` [PATCH char-misc-next 1/2] misc: mic: Fix randconfig build error by including errno.h Sudeep Dutt
  2015-06-10  3:58 ` [PATCH char-misc-next 2/2] misc: mic: Fix reported static checker warning Sudeep Dutt
  0 siblings, 2 replies; 3+ messages in thread
From: Sudeep Dutt @ 2015-06-10  3:58 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-kernel, Jim Davis, Dan Carpenter, Nikhil Rao,
	Ashutosh Dixit, Sudeep Dutt

This patch series fixes reported issues including a
randconfig build error and a warning from a static checker.

Sudeep Dutt (2):
  misc: mic: Fix randconfig build error by including errno.h
  misc: mic: Fix reported static checker warning

 drivers/misc/mic/scif/scif_main.c | 4 ----
 drivers/misc/mic/scif/scif_rb.c   | 1 +
 2 files changed, 1 insertion(+), 4 deletions(-)

-- 
1.8.2.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH char-misc-next 1/2] misc: mic: Fix randconfig build error by including errno.h
  2015-06-10  3:58 [PATCH char-misc-next 0/2] misc: mic: bug fixes Sudeep Dutt
@ 2015-06-10  3:58 ` Sudeep Dutt
  2015-06-10  3:58 ` [PATCH char-misc-next 2/2] misc: mic: Fix reported static checker warning Sudeep Dutt
  1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Dutt @ 2015-06-10  3:58 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-kernel, Jim Davis, Dan Carpenter, Nikhil Rao,
	Ashutosh Dixit, Sudeep Dutt

This issue was reported @ https://lkml.org/lkml/2015/6/9/731

Reported-by: Jim Davis <jim.epost@gmail.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com>
---
 drivers/misc/mic/scif/scif_rb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/mic/scif/scif_rb.c b/drivers/misc/mic/scif/scif_rb.c
index 47de222..637cc46 100644
--- a/drivers/misc/mic/scif/scif_rb.c
+++ b/drivers/misc/mic/scif/scif_rb.c
@@ -18,6 +18,7 @@
 #include <linux/circ_buf.h>
 #include <linux/types.h>
 #include <linux/io.h>
+#include <linux/errno.h>
 
 #include "scif_rb.h"
 
-- 
1.8.2.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH char-misc-next 2/2] misc: mic: Fix reported static checker warning
  2015-06-10  3:58 [PATCH char-misc-next 0/2] misc: mic: bug fixes Sudeep Dutt
  2015-06-10  3:58 ` [PATCH char-misc-next 1/2] misc: mic: Fix randconfig build error by including errno.h Sudeep Dutt
@ 2015-06-10  3:58 ` Sudeep Dutt
  1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Dutt @ 2015-06-10  3:58 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-kernel, Jim Davis, Dan Carpenter, Nikhil Rao,
	Ashutosh Dixit, Sudeep Dutt

Delete unnecessary prints resulting in an "spdev could be null"
warning from a static checker in scif_peer_remove(..).

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com>
---
 drivers/misc/mic/scif/scif_main.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/misc/mic/scif/scif_main.c b/drivers/misc/mic/scif/scif_main.c
index f7187dc..6ce851f 100644
--- a/drivers/misc/mic/scif/scif_main.c
+++ b/drivers/misc/mic/scif/scif_main.c
@@ -91,8 +91,6 @@ static int scif_peer_probe(struct scif_peer_dev *spdev)
 	rcu_assign_pointer(scifdev->spdev, spdev);
 
 	/* In the future SCIF kernel client devices will be added here */
-	dev_info(&spdev->dev, "Peer added dnode %d\n",
-		 spdev->dnode);
 	return 0;
 }
 
@@ -109,8 +107,6 @@ static void scif_peer_remove(struct scif_peer_dev *spdev)
 	mutex_lock(&scif_info.conflock);
 	scif_info.total--;
 	mutex_unlock(&scif_info.conflock);
-	dev_info(&spdev->dev, "Peer removed dnode %d\n",
-		 spdev->dnode);
 }
 
 static void scif_qp_setup_handler(struct work_struct *work)
-- 
1.8.2.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-10  4:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-10  3:58 [PATCH char-misc-next 0/2] misc: mic: bug fixes Sudeep Dutt
2015-06-10  3:58 ` [PATCH char-misc-next 1/2] misc: mic: Fix randconfig build error by including errno.h Sudeep Dutt
2015-06-10  3:58 ` [PATCH char-misc-next 2/2] misc: mic: Fix reported static checker warning Sudeep Dutt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).