From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Samin Guo <samin.guo@starfivetech.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 01/12] dt-bindings: net: snps,dwmac: Allow exclusive usage of ahb reset
Date: Sun, 29 Oct 2023 12:25:03 +0100 [thread overview]
Message-ID: <3016eff2-fce5-4b5e-bbb2-d56cbb45df85@linaro.org> (raw)
In-Reply-To: <20231029042712.520010-2-cristian.ciocaltea@collabora.com>
On 29/10/2023 05:27, Cristian Ciocaltea wrote:
> The Synopsys DesignWare MAC found on the StarFive JH7100 SoC requires
> just the 'ahb' reset name, but the binding allows selecting it only in
> conjunction with 'stmmaceth'.
>
> Fix the issue by permitting exclusive usage of the 'ahb' reset name.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 5c2769dc689a..a4d7172ea701 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -146,7 +146,7 @@ properties:
> reset-names:
> minItems: 1
> items:
> - - const: stmmaceth
> + - enum: [stmmaceth, ahb]
Also, this makes sense only with patch #4, so this should be squashed there.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-29 11:25 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 4:27 [PATCH v2 00/12] Enable networking support for StarFive JH7100 SoC Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 01/12] dt-bindings: net: snps,dwmac: Allow exclusive usage of ahb reset Cristian Ciocaltea
2023-10-29 11:21 ` Krzysztof Kozlowski
2023-10-29 21:55 ` Cristian Ciocaltea
2023-10-29 22:02 ` Cristian Ciocaltea
2023-10-29 11:25 ` Krzysztof Kozlowski [this message]
2023-10-29 22:24 ` Cristian Ciocaltea
2023-10-30 7:26 ` Krzysztof Kozlowski
2023-10-30 19:07 ` Cristian Ciocaltea
2023-10-31 5:48 ` Krzysztof Kozlowski
2023-10-31 11:00 ` Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 02/12] dt-bindings: net: starfive,jh7110-dwmac: Drop superfluous select Cristian Ciocaltea
2023-10-29 11:18 ` Krzysztof Kozlowski
2023-10-29 21:08 ` Cristian Ciocaltea
2023-10-30 7:27 ` Krzysztof Kozlowski
2023-10-30 19:25 ` Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 03/12] dt-bindings: net: starfive,jh7110-dwmac: Drop redundant reset description Cristian Ciocaltea
2023-10-29 11:19 ` Krzysztof Kozlowski
2023-10-29 21:23 ` Cristian Ciocaltea
2023-10-30 7:29 ` Krzysztof Kozlowski
2023-10-30 19:35 ` Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 04/12] dt-bindings: net: starfive,jh7110-dwmac: Add JH7100 SoC compatible Cristian Ciocaltea
2023-10-29 11:24 ` Krzysztof Kozlowski
2023-10-29 22:15 ` Cristian Ciocaltea
2023-10-30 7:30 ` Krzysztof Kozlowski
2023-10-30 20:02 ` Cristian Ciocaltea
2023-10-30 1:37 ` Rob Herring
2023-10-30 7:29 ` Krzysztof Kozlowski
2023-10-29 4:27 ` [PATCH v2 05/12] net: stmmac: dwmac-starfive: Add support for JH7100 SoC Cristian Ciocaltea
2023-10-31 14:33 ` Emil Renner Berthing
2023-10-31 18:07 ` Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 06/12] riscv: dts: starfive: jh7100: Add dma-noncoherent property Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 07/12] riscv: dts: starfive: jh7100: Add ccache DT node Cristian Ciocaltea
2023-10-31 14:38 ` Emil Renner Berthing
2023-10-31 19:01 ` Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 08/12] riscv: dts: starfive: Add pool for coherent DMA memory on JH7100 boards Cristian Ciocaltea
2023-10-29 18:35 ` Andrew Lunn
2023-10-31 14:56 ` Emil Renner Berthing
2023-10-31 14:40 ` Emil Renner Berthing
2023-10-31 19:16 ` Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 09/12] riscv: dts: starfive: jh7100: Add sysmain and gmac DT nodes Cristian Ciocaltea
2023-11-26 21:15 ` Emil Renner Berthing
2023-11-28 0:46 ` Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 10/12] riscv: dts: starfive: jh7100-common: Setup gmac pinmux Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 11/12] riscv: dts: starfive: visionfive-v1: Enable gmac and setup phy Cristian Ciocaltea
2023-10-29 18:45 ` Andrew Lunn
2023-10-29 22:41 ` Cristian Ciocaltea
2023-10-29 22:50 ` Andrew Lunn
2023-10-29 23:35 ` Cristian Ciocaltea
2023-10-29 4:27 ` [PATCH v2 12/12] [UNTESTED] riscv: dts: starfive: beaglev-starlight: Enable gmac Cristian Ciocaltea
2023-10-29 18:46 ` Andrew Lunn
2023-10-29 22:53 ` Cristian Ciocaltea
2023-11-16 13:15 ` Cristian Ciocaltea
2023-11-16 17:55 ` Conor Dooley
2023-11-16 18:30 ` Cristian Ciocaltea
2023-11-17 8:37 ` Geert Uytterhoeven
2023-11-17 8:49 ` Cristian Ciocaltea
2023-11-17 8:58 ` Cristian Ciocaltea
2023-11-17 9:12 ` Geert Uytterhoeven
2023-11-17 11:19 ` Cristian Ciocaltea
2023-11-17 22:48 ` Cristian Ciocaltea
2023-11-26 21:10 ` Emil Renner Berthing
2023-11-28 0:40 ` Cristian Ciocaltea
2023-11-28 12:08 ` Emil Renner Berthing
2023-11-28 15:47 ` Cristian Ciocaltea
2023-11-28 16:09 ` Emil Renner Berthing
2023-11-28 16:22 ` Cristian Ciocaltea
2023-11-29 14:28 ` Emil Renner Berthing
2023-11-29 14:59 ` Cristian Ciocaltea
2023-12-15 21:13 ` Cristian Ciocaltea
2023-12-16 19:24 ` Emil Renner Berthing
2023-12-18 11:38 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3016eff2-fce5-4b5e-bbb2-d56cbb45df85@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).