From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ben Dooks <ben.dooks@sifive.com>, linux-pwm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
u.kleine-koenig@pengutronix.de,
Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greentime Hu <greentime.hu@sifive.com>
Subject: Re: [[PATCH v2] 2/9] dt-bindings: pwm: snps,pwm add pwm number
Date: Tue, 26 Jul 2022 12:08:20 +0200 [thread overview]
Message-ID: <308d6189-c100-e9fc-e4b2-0639d993e436@linaro.org> (raw)
In-Reply-To: <20220725212140.741644-2-ben.dooks@sifive.com>
On 25/07/2022 23:21, Ben Dooks wrote:
> Add snps,pwm-number property to indicate if the block does not have
> all 8 of the PWM blocks.
>
> Not sure if this should be a general PWM property consider optional
> for all PWM types, so have added a specific one here (there is only
> one other controller with a property for PWM count at the moment)
>
> Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
> ---
> Documentation/devicetree/bindings/pwm/snps,pwm.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/snps,pwm.yaml b/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
> index 594085e5e26f..e95f518b3974 100644
> --- a/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
> @@ -30,11 +30,16 @@ properties:
> - const: bus
> - const: timer
>
> + snps,pwm-number:
> + $ref: '/schemas/types.yaml#/definitions/uint32'
1. No quotes
2. Add minimum and maximum (it looks like there are such).
> + description: u32 value representing the number of PWM devices
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-26 10:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 21:21 [[PATCH v2] 1/9] dt-bindings: pwm: Document Synopsys DesignWare snps,pwm Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 2/9] dt-bindings: pwm: snps,pwm add pwm number Ben Dooks
2022-07-26 10:08 ` Krzysztof Kozlowski [this message]
2022-07-26 10:12 ` Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 3/9] pwm: change &pci->dev to dev in probe Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 4/9] pwm: move dwc memory alloc to own function Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 5/9] pwm: dwc: add of/platform support Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 6/9] pwm: dwc: allow driver to be built with COMPILE_TEST Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 7/9] pwm: dwc: add timer clock Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 8/9] pwm: dwc: add snps,pwm-number to limit pwm count Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 9/9] pwm: dwc: add PWM bit unset in get_state call Ben Dooks
2022-07-25 21:27 ` [[PATCH v2] 1/9] dt-bindings: pwm: Document Synopsys DesignWare snps,pwm Ben Dooks
2022-07-26 10:05 ` Krzysztof Kozlowski
2022-07-26 10:12 ` Ben Dooks
2022-07-26 11:05 ` Krzysztof Kozlowski
2022-07-27 10:32 ` Ben Dooks
2022-07-27 12:02 ` Krzysztof Kozlowski
2022-07-27 13:21 ` Ben Dooks
2022-07-28 7:57 ` Krzysztof Kozlowski
2022-07-27 10:45 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=308d6189-c100-e9fc-e4b2-0639d993e436@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ben.dooks@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=greentime.hu@sifive.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).