From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ben Dooks <ben.dooks@sifive.com>, linux-pwm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
u.kleine-koenig@pengutronix.de,
Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greentime Hu <greentime.hu@sifive.com>
Subject: Re: [[PATCH v2] 1/9] dt-bindings: pwm: Document Synopsys DesignWare snps,pwm
Date: Tue, 26 Jul 2022 13:05:29 +0200 [thread overview]
Message-ID: <6317212b-1fca-65b4-9bce-0b9f7408fdae@linaro.org> (raw)
In-Reply-To: <8bb5103d-803e-90d2-fd93-132bb2aac2d6@sifive.com>
On 26/07/2022 12:12, Ben Dooks wrote:
> On 26/07/2022 11:05, Krzysztof Kozlowski wrote:
>> On 25/07/2022 23:21, Ben Dooks wrote:
>>> Add documentation for the bindings for Synopsys' DesignWare PWM block
>>> as we will be adding DT/platform support to the Linux driver soon.
>>>
>>> Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
>>> --
>>
>> This is not proper delimiter and causes the changelog to end up in commit.
>>
>> Correct also wrong formatting of subject PATCH.
>
> I realised that once sent and forgot the cover letter.
> Maybe I'll try some more post covid recovery.
>
>>> v2:
>>> - fix #pwm-cells to be 3
>>> - fix indentation and ordering issues
>>> ---
>>> .../devicetree/bindings/pwm/snps,pwm.yaml | 40 +++++++++++++++++++
>>> 1 file changed, 40 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/pwm/snps,pwm.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/snps,pwm.yaml b/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
>>> new file mode 100644
>>> index 000000000000..594085e5e26f
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
>>> @@ -0,0 +1,40 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +# Copyright (C) 2022 SiFive, Inc.
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/pwm/snps,pwm.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Synopsys PWM controller
>>> +
>>> +maintainers:
>>> + - Ben Dooks <ben.dooks@sifive.com>
>>> +
>>> +allOf:
>>> + - $ref: pwm.yaml#
>>> +
>>> +properties:
>>> + compatible:
>>> + const: snps,pwm
>>
>> This is very generic compatible. I doubt that you cover here all
>> Synopsys PWM designs, past and future. You need a specific compatible.
>
> From what I can get from the documentation (2.13a) there hasn't been
> a huge external interface change and what has been added is all part
> of synthesis time options.
But you have some specific version, right? Usually these blocks are
versioned, so you must include it. I would even argue that such generic
compatible should not be used as fallback at all, because it is simply
to generic (PWM is not some model name but common acronym),
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-26 11:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 21:21 [[PATCH v2] 1/9] dt-bindings: pwm: Document Synopsys DesignWare snps,pwm Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 2/9] dt-bindings: pwm: snps,pwm add pwm number Ben Dooks
2022-07-26 10:08 ` Krzysztof Kozlowski
2022-07-26 10:12 ` Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 3/9] pwm: change &pci->dev to dev in probe Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 4/9] pwm: move dwc memory alloc to own function Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 5/9] pwm: dwc: add of/platform support Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 6/9] pwm: dwc: allow driver to be built with COMPILE_TEST Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 7/9] pwm: dwc: add timer clock Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 8/9] pwm: dwc: add snps,pwm-number to limit pwm count Ben Dooks
2022-07-25 21:21 ` [[PATCH v2] 9/9] pwm: dwc: add PWM bit unset in get_state call Ben Dooks
2022-07-25 21:27 ` [[PATCH v2] 1/9] dt-bindings: pwm: Document Synopsys DesignWare snps,pwm Ben Dooks
2022-07-26 10:05 ` Krzysztof Kozlowski
2022-07-26 10:12 ` Ben Dooks
2022-07-26 11:05 ` Krzysztof Kozlowski [this message]
2022-07-27 10:32 ` Ben Dooks
2022-07-27 12:02 ` Krzysztof Kozlowski
2022-07-27 13:21 ` Ben Dooks
2022-07-28 7:57 ` Krzysztof Kozlowski
2022-07-27 10:45 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6317212b-1fca-65b4-9bce-0b9f7408fdae@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ben.dooks@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=greentime.hu@sifive.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).