From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Pingfan Liu <kernelfans@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@infradead.org>,
Bjorn Helgaas <helgaas@kernel.org>,
Dave Young <dyoung@redhat.com>,
linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCHv3 3/4] drivers/base: clean up the usage of devices_kset_move_last()
Date: Tue, 03 Jul 2018 16:26:40 +0200 [thread overview]
Message-ID: <3375966.ydPZj5TMVj@aspire.rjw.lan> (raw)
In-Reply-To: <1530600642-25090-4-git-send-email-kernelfans@gmail.com>
On Tuesday, July 3, 2018 8:50:41 AM CEST Pingfan Liu wrote:
> Clean up the referring to the code in commit 52cdbdd49853 ("driver core:
> correct device's shutdown order"). So later we can revert it safely.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Bjorn Helgaas <helgaas@kernel.org>
> Cc: Dave Young <dyoung@redhat.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> ---
> drivers/base/core.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 684b994..db3deb8 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -127,13 +127,6 @@ static int device_reorder_to_tail(struct device *dev, void *not_used)
> {
> struct device_link *link;
>
> - /*
> - * Devices that have not been registered yet will be put to the ends
> - * of the lists during the registration, so skip them here.
> - */
> - if (device_is_registered(dev))
> - devices_kset_move_last(dev);
> -
> if (device_pm_initialized(dev))
> device_pm_move_last(dev);
You can't do this.
If you do it, that will break power management in some situations.
Thanks,
Rafael
next prev parent reply other threads:[~2018-07-03 14:28 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 6:50 [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset Pingfan Liu
2018-07-03 6:50 ` [PATCHv3 1/4] drivers/base: fold the routine of device's shutdown into a func Pingfan Liu
2018-07-03 6:50 ` [PATCHv3 2/4] drivers/base: utilize device tree info to shutdown devices Pingfan Liu
2018-07-03 7:51 ` Lukas Wunner
2018-07-03 9:26 ` Pingfan Liu
2018-07-04 3:10 ` Pingfan Liu
2018-07-03 10:58 ` Andy Shevchenko
2018-07-03 17:03 ` Pavel Tatashin
2018-07-04 17:04 ` kbuild test robot
2018-07-05 10:11 ` Rafael J. Wysocki
2018-07-06 3:02 ` Pingfan Liu
2018-07-06 9:53 ` Rafael J. Wysocki
2018-07-07 4:02 ` Pingfan Liu
2018-07-06 10:00 ` [PATCH] driver core: Drop devices_kset_move_last() call from really_probe() Rafael J. Wysocki
2018-07-09 13:57 ` Bjorn Helgaas
2018-07-09 21:35 ` Rafael J. Wysocki
2018-07-09 22:06 ` Bjorn Helgaas
2018-07-10 6:19 ` Kishon Vijay Abraham I
2018-07-10 10:32 ` Rafael J. Wysocki
2018-07-10 10:29 ` Rafael J. Wysocki
2018-07-10 6:33 ` Pingfan Liu
2018-07-10 11:35 ` [PATCH] driver core: Partially revert "driver core: correct device's shutdown order" Rafael J. Wysocki
2018-07-10 12:22 ` Kishon Vijay Abraham I
2018-07-10 12:38 ` Rafael J. Wysocki
2018-07-10 12:51 ` [PATCH v2] " Rafael J. Wysocki
2018-07-10 12:59 ` Greg Kroah-Hartman
2018-07-10 15:40 ` Rafael J. Wysocki
2018-07-10 15:47 ` Greg Kroah-Hartman
2018-07-10 19:13 ` Kishon Vijay Abraham I
2018-07-03 6:50 ` [PATCHv3 3/4] drivers/base: clean up the usage of devices_kset_move_last() Pingfan Liu
2018-07-03 14:26 ` Rafael J. Wysocki [this message]
2018-07-04 4:40 ` Pingfan Liu
2018-07-04 10:17 ` Rafael J. Wysocki
2018-07-05 2:32 ` Pingfan Liu
2018-07-03 6:50 ` [PATCHv3 4/4] Revert "driver core: correct device's shutdown order" Pingfan Liu
2018-07-03 14:35 ` [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset Rafael J. Wysocki
2018-07-04 2:47 ` Pingfan Liu
2018-07-04 10:21 ` Rafael J. Wysocki
2018-07-05 2:44 ` Pingfan Liu
2018-07-05 9:18 ` Rafael J. Wysocki
2018-07-06 8:36 ` Lukas Wunner
2018-07-06 8:47 ` Rafael J. Wysocki
2018-07-06 13:55 ` Pingfan Liu
2018-07-07 4:24 ` Pingfan Liu
2018-07-08 8:25 ` Rafael J. Wysocki
2018-07-09 6:48 ` Pingfan Liu
2018-07-09 7:48 ` Rafael J. Wysocki
2018-07-09 8:40 ` Pingfan Liu
2018-07-09 8:58 ` Rafael J. Wysocki
2018-07-06 10:02 ` Kishon Vijay Abraham I
2018-07-06 13:52 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3375966.ydPZj5TMVj@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=dyoung@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).