[PATCH] drm/radeon: use list_move in radeon_vm_bo_update

[PATCH] drm/radeon: use list_move in radeon_vm_bo_update

[Geliang Tang]

Use list_move() instead of list_del() + list_add() to simplify the code.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/gpu/drm/radeon/radeon_vm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
index a135874..2f1e372 100644
--- a/drivers/gpu/drm/radeon/radeon_vm.c
+++ b/drivers/gpu/drm/radeon/radeon_vm.c
@@ -933,8 +933,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
 		}
 		list_del_init(&bo_va->vm_status);
 	} else {
-		list_del(&bo_va->vm_status);
-		list_add(&bo_va->vm_status, &vm->cleared);
+		list_move(&bo_va->vm_status, &vm->cleared);
 	}
 	spin_unlock(&vm->status_lock);
 
-- 
2.9.3

[PATCH] HID: intel_ish-hid: use list_move_tail in ishtp_cl_read_start

[Geliang Tang]

Use list_move() instead of list_del() + list_add_tail() to simplify
the code.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/hid/intel-ish-hid/ishtp/client.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c
index aad6132..0979e04 100644
--- a/drivers/hid/intel-ish-hid/ishtp/client.c
+++ b/drivers/hid/intel-ish-hid/ishtp/client.c
@@ -497,12 +497,8 @@ int ishtp_cl_read_start(struct ishtp_cl *cl)
 out:
 	/* if ishtp_hbm_cl_flow_control_req failed, return rb to free list */
 	if (rets && rb) {
-		spin_lock_irqsave(&dev->read_list_spinlock, dev_flags);
-		list_del(&rb->list);
-		spin_unlock_irqrestore(&dev->read_list_spinlock, dev_flags);
-
 		spin_lock_irqsave(&cl->free_list_spinlock, flags);
-		list_add_tail(&rb->list, &cl->free_rb_list.list);
+		list_move_tail(&rb->list, &cl->free_rb_list.list);
 		spin_unlock_irqrestore(&cl->free_list_spinlock, flags);
 	}
 	return rets;
-- 
2.9.3

Re: [PATCH] drm/radeon: use list_move in radeon_vm_bo_update

[Christian König]

Am 11.11.2016 um 13:26 schrieb Geliang Tang:
> Use list_move() instead of list_del() + list_add() to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>

Reviewed-by: Christian König <christian.koenig@amd.com>.

> ---
>   drivers/gpu/drm/radeon/radeon_vm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
> index a135874..2f1e372 100644
> --- a/drivers/gpu/drm/radeon/radeon_vm.c
> +++ b/drivers/gpu/drm/radeon/radeon_vm.c
> @@ -933,8 +933,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
>   		}
>   		list_del_init(&bo_va->vm_status);
>   	} else {
> -		list_del(&bo_va->vm_status);
> -		list_add(&bo_va->vm_status, &vm->cleared);
> +		list_move(&bo_va->vm_status, &vm->cleared);
>   	}
>   	spin_unlock(&vm->status_lock);
>   

Re: [PATCH] HID: intel_ish-hid: use list_move_tail in ishtp_cl_read_start

[Srinivas Pandruvada]

On Fri, 2016-11-11 at 20:26 +0800, Geliang Tang wrote:
> Use list_move() instead of list_del() + list_add_tail() to simplify
> the code.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
>  drivers/hid/intel-ish-hid/ishtp/client.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c
> b/drivers/hid/intel-ish-hid/ishtp/client.c
> index aad6132..0979e04 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/client.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/client.c
> @@ -497,12 +497,8 @@ int ishtp_cl_read_start(struct ishtp_cl *cl)
>  out:
>  	/* if ishtp_hbm_cl_flow_control_req failed, return rb to
> free list */
>  	if (rets && rb) {
> -		spin_lock_irqsave(&dev->read_list_spinlock,
> dev_flags);
> -		list_del(&rb->list);
> -		spin_unlock_irqrestore(&dev->read_list_spinlock,
> dev_flags);
> -
>  		spin_lock_irqsave(&cl->free_list_spinlock, flags);
> -		list_add_tail(&rb->list, &cl->free_rb_list.list);
> +		list_move_tail(&rb->list, &cl->free_rb_list.list);
Logically the result is not same. They were protected under two
spinlocks, now they are not.

Thanks,
Srinivas

>  		spin_unlock_irqrestore(&cl->free_list_spinlock,
> flags);
>  	}
>  	return rets;