From: Dmitry Osipenko <digetx@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>, Rob Herring <robh@kernel.org>
Cc: Viresh Kumar <vireshk@kernel.org>,
Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>,
David Heidelberg <david@ixit.cz>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1] dt-bindings: opp: Allow multi-worded node names
Date: Sat, 23 Oct 2021 16:00:08 +0300 [thread overview]
Message-ID: <356febd2-64a2-0451-2c73-9319e5223c57@gmail.com> (raw)
In-Reply-To: <20211022074551.ro22d7xj3idisvzv@vireshk-i7>
22.10.2021 10:45, Viresh Kumar пишет:
> On 22-10-21, 10:39, Dmitry Osipenko wrote:
>> What we currently have for Tegra is a tegra-opps.dtsi and tegra.dtsi
>> which includes the OPP's dtsi.
>>
>> the tegra-opps.dtsi has this structure:
>>
>> table: devname-opp-table {
>> opp: ...
>> };
>>
>> and tegra.dtsi:
>>
>> #include "tegra-opps.dtsi"
>>
>> device@0000 {
>> operating-points-v2 = <&table>;
>> };
>>
>> It just occurred to me that there is no need to move all tables to
>> tegra.dtsi, but change structure of tegra-opps.dtsi to:
>>
>> device@0000 {
>> operating-points-v2 = <&table>;
>>
>> table: opp-table {
>> opp: ...
>> };
>> };
>
> I thought you would have already thought about that and I was surprised when you
> saw the tables are big enough to be moved. I was wondering what does it really
> mean :)
>
>> Then there no need to change current naming scheme. Let me try to
>> implement it and see how it goes.
>
> That's good then.
>
I implemented that approach and it works, but there are two problems:
1. I had to factor out OPP tables from SPI device-tree nodes because DTC doesn't allow to have them within SPI nodes [1] and dtb fails to compile.
[1] https://elixir.bootlin.com/linux/v5.15-rc6/source/scripts/dtc/checks.c#L1141
2. dtbs_check now warns about every opp-table sub-node, like this:
/home/runner/work/linux/linux/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-E1565.dt.yaml: memory-controller@7000f400: 'opp-table' does not match any of the regexes: '^emc-timings-[0-9]+$', 'pinctrl-[0-9]+'
From schema: /home/runner/work/linux/linux/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml
next prev parent reply other threads:[~2021-10-23 13:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 23:19 [PATCH v1] dt-bindings: opp: Allow multi-worded node names Dmitry Osipenko
2021-10-20 14:46 ` Rob Herring
2021-10-20 14:59 ` Dmitry Osipenko
2021-10-21 5:59 ` Dmitry Osipenko
2021-10-22 4:43 ` Viresh Kumar
2021-10-22 5:58 ` Dmitry Osipenko
2021-10-22 6:40 ` Dmitry Osipenko
2021-10-22 6:50 ` Viresh Kumar
2021-10-22 7:39 ` Dmitry Osipenko
2021-10-22 7:45 ` Viresh Kumar
2021-10-23 13:00 ` Dmitry Osipenko [this message]
2021-10-23 13:46 ` Dmitry Osipenko
2021-10-23 19:01 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=356febd2-64a2-0451-2c73-9319e5223c57@gmail.com \
--to=digetx@gmail.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).