From: Dmitry Osipenko <digetx@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>, Rob Herring <robh@kernel.org>
Cc: Viresh Kumar <vireshk@kernel.org>,
Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>,
David Heidelberg <david@ixit.cz>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1] dt-bindings: opp: Allow multi-worded node names
Date: Fri, 22 Oct 2021 09:40:51 +0300 [thread overview]
Message-ID: <48de7f40-deda-739d-96ca-e61ec5a0b257@gmail.com> (raw)
In-Reply-To: <20211022044334.4yn3i4kwinbrjicd@vireshk-i7>
22.10.2021 07:43, Viresh Kumar пишет:
> On 20-10-21, 09:46, Rob Herring wrote:
>> On Wed, Oct 20, 2021 at 02:19:05AM +0300, Dmitry Osipenko wrote:
>>> Not all OPP table names and OPP entries consist of a single word. In
>>> particular NVIDIA Tegra OPP tables use multi-word names. Allow OPP node
>>> and OPP entry name to have multi-worded names to silence DT checker
>>> warnings about the multi-word names separated by hyphen.
>>>
>>> Reviewed-by: David Heidelberg <david@ixit.cz>
>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>> ---
>>> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>>> index ae3ae4d39843..298cf24af270 100644
>>> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
>>> @@ -22,7 +22,7 @@ select: false
>>>
>>> properties:
>>> $nodename:
>>> - pattern: '^opp-table(-[a-z0-9]+)?$'
>>> + pattern: '^opp-table(-[a-z0-9]+)*$'
>>
>> I don't see how this helps you. What I see needed upstream is a prefix:
>>
>> '-?opp-table(-[0-9]+)?$'
>
> I wonder if we should disallow that to keep naming more
I also think that postfix variant should be disallowed for consistency.
I sent out patches for both variants.
V2 uses pattern that supports both naming schemes. If V2 is less
appropriate, then please take this V1.
next prev parent reply other threads:[~2021-10-22 6:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 23:19 [PATCH v1] dt-bindings: opp: Allow multi-worded node names Dmitry Osipenko
2021-10-20 14:46 ` Rob Herring
2021-10-20 14:59 ` Dmitry Osipenko
2021-10-21 5:59 ` Dmitry Osipenko
2021-10-22 4:43 ` Viresh Kumar
2021-10-22 5:58 ` Dmitry Osipenko
2021-10-22 6:40 ` Dmitry Osipenko [this message]
2021-10-22 6:50 ` Viresh Kumar
2021-10-22 7:39 ` Dmitry Osipenko
2021-10-22 7:45 ` Viresh Kumar
2021-10-23 13:00 ` Dmitry Osipenko
2021-10-23 13:46 ` Dmitry Osipenko
2021-10-23 19:01 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48de7f40-deda-739d-96ca-e61ec5a0b257@gmail.com \
--to=digetx@gmail.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).