From: Janani Ravichandran <janani.rvchndrn@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Janani Ravichandran <janani.rvchndrn@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
riel@surriel.com, akpm@linux-foundation.org, hannes@compxchg.org,
vdavydov@virtuozzo.com, mhocko@suse.com,
mgorman@techsingularity.net, kirill.shutemov@linux.intel.com,
bywxiaobai@163.com, rostedt@goodmis.org
Subject: Re: [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction tracepoints
Date: Sun, 7 Aug 2016 18:02:41 +0530 [thread overview]
Message-ID: <36624B5E-12F3-437D-90B6-E3197D31A0F3@gmail.com> (raw)
In-Reply-To: <7ab4a23a-1311-9579-2d58-263bbcdcd725@suse.cz>
> On Aug 1, 2016, at 6:55 PM, Vlastimil Babka <vbabka@suse.cz> wrote:
>
>
> Yea, this tracepoint has been odd in not printing node/zone in a friendly way (it's possible to determine it from zone_start/zone_end though, so this is good in general. But instead of printing nid and zid like this, it would be nice to unify the output with the other tracepoints, e.g.:
>
> DECLARE_EVENT_CLASS(mm_compaction_suitable_template,
> [...]
> TP_printk("node=%d zone=%-8s order=%d ret=%s",
> __entry->nid,
> __print_symbolic(__entry->idx, ZONE_TYPE),
Sure, I’ll do that in v2. Thanks!
Also, I guess I should have mentioned that the tracepoint added
at the end of the compaction code wasn’t just for deriving latency information.
rc and *contended would give us the result of the compaction attempted,
which I thought would be useful.
I get that begin/end tracepoints aren’t required here, but how about having
trace_mm_compaction_try_to_compact_pages moved to the end to
include compaction status?
Janani.
>
> Thanks,
> Vlastimil
prev parent reply other threads:[~2016-08-07 12:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 14:43 [PATCH 0/2] New tracepoints for slowpath and memory compaction Janani Ravichandran
2016-07-27 14:47 ` [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Janani Ravichandran
2016-07-27 15:23 ` Steven Rostedt
2016-07-27 17:20 ` Dave Hansen
2016-07-27 17:30 ` Steven Rostedt
2016-07-28 20:11 ` Janani Ravichandran
2016-08-04 15:19 ` Steven Rostedt
2016-08-05 16:03 ` Janani Ravichandran
2016-08-05 16:30 ` Steven Rostedt
2016-08-07 10:36 ` Janani Ravichandran
2016-07-27 16:33 ` Michal Hocko
2016-07-27 18:16 ` Rik van Riel
2016-07-27 18:28 ` Steven Rostedt
2016-07-27 18:44 ` Michal Hocko
2016-07-27 18:57 ` Rik van Riel
2016-07-27 14:51 ` [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction tracepoints Janani Ravichandran
2016-07-27 15:24 ` Steven Rostedt
2016-08-01 13:25 ` Vlastimil Babka
2016-08-07 12:32 ` Janani Ravichandran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36624B5E-12F3-437D-90B6-E3197D31A0F3@gmail.com \
--to=janani.rvchndrn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bywxiaobai@163.com \
--cc=hannes@compxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).