From: Dave Hansen <dave.hansen@intel.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Janani Ravichandran <janani.rvchndrn@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
riel@surriel.com, akpm@linux-foundation.org, hannes@compxchg.org,
vdavydov@virtuozzo.com, mhocko@suse.com, vbabka@suse.cz,
mgorman@techsingularity.net, kirill.shutemov@linux.intel.com,
bywxiaobai@163.com
Subject: Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath
Date: Wed, 27 Jul 2016 10:20:28 -0700 [thread overview]
Message-ID: <5798ED5C.1020300@intel.com> (raw)
In-Reply-To: <20160727112303.11409a4e@gandalf.local.home>
On 07/27/2016 08:23 AM, Steven Rostedt wrote:
>> > +
>> > + trace_mm_slowpath_end(page);
>> > +
> I'm thinking you only need one tracepoint, and use function_graph
> tracer for the length of the function call.
>
> # cd /sys/kernel/debug/tracing
> # echo __alloc_pages_nodemask > set_ftrace_filter
> # echo function_graph > current_tracer
> # echo 1 > events/kmem/trace_mm_slowpath/enable
I hesitate to endorse using the function_graph tracer for this kind of
stuff. Tracepoints offer some level of stability in naming, and the
compiler won't ever make them go away. While __alloc_pages_nodemask is
probably more stable than most things, there's no guarantee that it will
be there.
BTW, what's the overhead of the function graph tracer if the filter is
set up to be really restrictive like above? Is the overhead really just
limited to that one function?
next prev parent reply other threads:[~2016-07-27 17:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 14:43 [PATCH 0/2] New tracepoints for slowpath and memory compaction Janani Ravichandran
2016-07-27 14:47 ` [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Janani Ravichandran
2016-07-27 15:23 ` Steven Rostedt
2016-07-27 17:20 ` Dave Hansen [this message]
2016-07-27 17:30 ` Steven Rostedt
2016-07-28 20:11 ` Janani Ravichandran
2016-08-04 15:19 ` Steven Rostedt
2016-08-05 16:03 ` Janani Ravichandran
2016-08-05 16:30 ` Steven Rostedt
2016-08-07 10:36 ` Janani Ravichandran
2016-07-27 16:33 ` Michal Hocko
2016-07-27 18:16 ` Rik van Riel
2016-07-27 18:28 ` Steven Rostedt
2016-07-27 18:44 ` Michal Hocko
2016-07-27 18:57 ` Rik van Riel
2016-07-27 14:51 ` [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction tracepoints Janani Ravichandran
2016-07-27 15:24 ` Steven Rostedt
2016-08-01 13:25 ` Vlastimil Babka
2016-08-07 12:32 ` Janani Ravichandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5798ED5C.1020300@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bywxiaobai@163.com \
--cc=hannes@compxchg.org \
--cc=janani.rvchndrn@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).