From: Steven Rostedt <rostedt@goodmis.org>
To: Janani Ravichandran <janani.rvchndrn@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
riel@surriel.com, akpm@linux-foundation.org, hannes@compxchg.org,
vdavydov@virtuozzo.com, mhocko@suse.com, vbabka@suse.cz,
mgorman@techsingularity.net, kirill.shutemov@linux.intel.com,
bywxiaobai@163.com
Subject: Re: [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction tracepoints
Date: Wed, 27 Jul 2016 11:24:11 -0400 [thread overview]
Message-ID: <20160727112411.6e60c186@gandalf.local.home> (raw)
In-Reply-To: <7d2c2beef96e76cb01a21eee85ba5611bceb4307.1469629027.git.janani.rvchndrn@gmail.com>
On Wed, 27 Jul 2016 10:51:03 -0400
Janani Ravichandran <janani.rvchndrn@gmail.com> wrote:
> Add zone information to an existing tracepoint in compact_zone(). Also,
> add a new tracepoint at the end of the compaction code so that latency
> information can be derived.
>
> Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
> ---
>
> + trace_mm_compaction_try_to_compact_pages_end(rc, *contended);
> +
Again, I'm not to thrilled about tracepoints just being added to track
the length of function calls. We have function graph tracer for that.
-- Steve
> return rc;
> }
>
next prev parent reply other threads:[~2016-07-27 15:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 14:43 [PATCH 0/2] New tracepoints for slowpath and memory compaction Janani Ravichandran
2016-07-27 14:47 ` [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath Janani Ravichandran
2016-07-27 15:23 ` Steven Rostedt
2016-07-27 17:20 ` Dave Hansen
2016-07-27 17:30 ` Steven Rostedt
2016-07-28 20:11 ` Janani Ravichandran
2016-08-04 15:19 ` Steven Rostedt
2016-08-05 16:03 ` Janani Ravichandran
2016-08-05 16:30 ` Steven Rostedt
2016-08-07 10:36 ` Janani Ravichandran
2016-07-27 16:33 ` Michal Hocko
2016-07-27 18:16 ` Rik van Riel
2016-07-27 18:28 ` Steven Rostedt
2016-07-27 18:44 ` Michal Hocko
2016-07-27 18:57 ` Rik van Riel
2016-07-27 14:51 ` [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction tracepoints Janani Ravichandran
2016-07-27 15:24 ` Steven Rostedt [this message]
2016-08-01 13:25 ` Vlastimil Babka
2016-08-07 12:32 ` Janani Ravichandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160727112411.6e60c186@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=bywxiaobai@163.com \
--cc=hannes@compxchg.org \
--cc=janani.rvchndrn@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).