From: Mark Hounschell <markh@compro.net>
To: Lidza Louina <lidza.louina@gmail.com>
Cc: Sehro Rautenkranz <sehro@sehro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: dgnc: Fix Kconfig help header and text
Date: Mon, 1 Oct 2018 13:38:43 -0400 [thread overview]
Message-ID: <38775ed8-4fc3-8adb-510c-fe11a377fe15@compro.net> (raw)
In-Reply-To: <CA+t4uCPFZSTjyN-Wd3ppOp-edAXfSSTTdT8uab+-E53=Htv9+A@mail.gmail.com>
On 10/1/18 12:49 PM, Lidza Louina wrote:
> On Mon, Oct 1, 2018 at 8:09 AM Mark Hounschell <markh@compro.net
> <mailto:markh@compro.net>> wrote:
>
> On 9/28/18 3:59 PM, Lidza Louina wrote:
> > I haven't done work on this driver in a long time. I looked up the
> > devices, and they seem to already have an existing Linux driver:
> >
> https://www.digi.com/products/usb-and-serial-connectivity/serial-cards/digineo and
>
> > https://www.digi.com/support/productdetail?pid=1694
> >
> > I've contacted the company to see if the driver is still needed in
> > staging. I'll send an update once they get back to me.
> >
> > Lidza
> >
>
> Good luck with that. Digi obsoleted ALL their PCI serial cards several
> months ago. They would not even respond to requests from me to include
> their firmware for their PCI dgap cards into the kernel firmware
> package. The card for the dgnc driver is a pci-e card that may still be
> supported by them however. Also there does appear to be an already in
> kernel driver for these "PCI-e" cards too. It actually works as I
> have a
> couple of these cards. The module name is "jsm".
>
>
> 03:00.0 Serial controller: Digi International Device 00f0 (rev 02)
> (prog-if 02 [16550])
> Subsystem: Digi International Device 00f0
> Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping- SERR- FastB2B- DisINTx-
> Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=fast
> >TAbort-
> <TAbort- <MAbort- >SERR- <PERR- INTx-
> Interrupt: pin A routed to IRQ 29
> Region 0: Memory at f7200000 (32-bit, non-prefetchable)
> [size=4K]
> Capabilities: [40] Power Management version 2
> Flags: PMEClk+ DSI- D1- D2- AuxCurrent=0mA
> PME(D0-,D1-,D2-,D3hot+,D3cold-)
> Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
> Kernel driver in use: jsm
> Kernel modules: jsm
>
>
> Regards
> Mark
>
>
> Thanks for the heads up Mark. I've totally neglected this driver and
> should have caught this earlier. I'm okay with removing it from staging.
> We can bring it back if they need it.
>
It may actually be my fault that Greg-KH added the dgnc driver to
staging. Shortly after Digi stopped supporting their PCI cards, I had
some contact with Greg-KH and sent him all the Digi GPL drivers that I
was using at the time for possible inclusion. Digi was no longer
maintaining them. I did not know at the time about the jsm driver
already being there.
The dgnc driver supports the following PCI cards:
#define PCI_DEVICE_CLASSIC_4_DID 0x0028
#define PCI_DEVICE_CLASSIC_8_DID 0x0029
#define PCI_DEVICE_CLASSIC_4_422_DID 0x00D0
#define PCI_DEVICE_CLASSIC_8_422_DID 0x00D1
The jsm driver supports all of these plus their newer PCI-e cards:
#define PCI_DEVICE_ID_CLASSIC_4 0x0028
#define PCI_DEVICE_ID_CLASSIC_8 0x0029
#define PCI_DEVICE_ID_CLASSIC_4_422 0x00D0
#define PCI_DEVICE_ID_CLASSIC_8_422 0x00D1
#define PCI_DEVICE_ID_NEO_4 0x00B0
#define PCI_DEVICE_ID_NEO_1_422 0x00CC
#define PCI_DEVICE_ID_NEO_1_422_485 0x00CD
#define PCI_DEVICE_ID_NEO_2_422_485 0x00CE
#define PCIE_DEVICE_ID_NEO_8 0x00F0
#define PCIE_DEVICE_ID_NEO_4 0x00F1
#define PCIE_DEVICE_ID_NEO_4RJ45 0x00F2
#define PCIE_DEVICE_ID_NEO_8RJ45 0x00F3
So I think it is safe to remove the dgnc driver from staging. I also
think the PCI-e versions defined above are actually still available from
Digi as current products.
Regards
Mark
next prev parent reply other threads:[~2018-10-01 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 6:20 [PATCH] staging: dgnc: Fix Kconfig help header and text sehro rautenkranz
2018-09-25 15:34 ` Randy Dunlap
2018-09-25 15:53 ` sehro rautenkranz
2018-09-25 16:00 ` Randy Dunlap
2018-09-25 16:22 ` sehro rautenkranz
2018-09-25 18:46 ` Greg Kroah-Hartman
2018-09-25 19:49 ` Randy Dunlap
2018-09-25 23:41 ` [PATCH v3] " Sehro Rautenkranz
[not found] ` <CA+t4uCMAgpNtpdLfxNY_cmx7WONKOYjiaTBDGRNd+7H_GUdRAA@mail.gmail.com>
2018-10-01 12:09 ` Mark Hounschell
[not found] ` <CA+t4uCPFZSTjyN-Wd3ppOp-edAXfSSTTdT8uab+-E53=Htv9+A@mail.gmail.com>
2018-10-01 17:38 ` Mark Hounschell [this message]
2018-10-02 22:09 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38775ed8-4fc3-8adb-510c-fe11a377fe15@compro.net \
--to=markh@compro.net \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sehro@sehro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).