From: Randy Dunlap <rdunlap@infradead.org>
To: sehro rautenkranz <sehro@sehro.org>, lidza-louina@gmail.com
Cc: markh@compro.net, driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: Fix Kconfig help header and text
Date: Tue, 25 Sep 2018 08:34:43 -0700 [thread overview]
Message-ID: <d5bb4ab0-42f6-3fd1-006d-670a355e8702@infradead.org> (raw)
In-Reply-To: <20180925062001.12273-1-sehro@sehro.org>
On 9/24/18 11:20 PM, sehro rautenkranz wrote:
> Replace Kconfig help header and text to match other modules. Issue found
> by checkpatch.
>
> Signed-off-by: sehro rautenkranz <sehro@sehro.org>
> ---
Hi,
Documentation/process/coding-style.rst says:
Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.
> drivers/staging/dgnc/Kconfig | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/Kconfig b/drivers/staging/dgnc/Kconfig
> index 032c2a795238..c845b357b53d 100644
> --- a/drivers/staging/dgnc/Kconfig
> +++ b/drivers/staging/dgnc/Kconfig
> @@ -2,5 +2,9 @@ config DGNC
> tristate "Digi Neo and Classic PCI Products"
> default n
> depends on TTY && PCI
> - ---help---
> - Driver for the Digi International Neo and Classic PCI based product line.
> + help
> + Say Y here to enable support for the Digi International Neo and
> + Classic PCI based product line.
> +
> + To compile this driver as a module, say M here: the module will be
> + called dgnc
>
thanks,
--
~Randy
next prev parent reply other threads:[~2018-09-25 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 6:20 [PATCH] staging: dgnc: Fix Kconfig help header and text sehro rautenkranz
2018-09-25 15:34 ` Randy Dunlap [this message]
2018-09-25 15:53 ` sehro rautenkranz
2018-09-25 16:00 ` Randy Dunlap
2018-09-25 16:22 ` sehro rautenkranz
2018-09-25 18:46 ` Greg Kroah-Hartman
2018-09-25 19:49 ` Randy Dunlap
2018-09-25 23:41 ` [PATCH v3] " Sehro Rautenkranz
[not found] ` <CA+t4uCMAgpNtpdLfxNY_cmx7WONKOYjiaTBDGRNd+7H_GUdRAA@mail.gmail.com>
2018-10-01 12:09 ` Mark Hounschell
[not found] ` <CA+t4uCPFZSTjyN-Wd3ppOp-edAXfSSTTdT8uab+-E53=Htv9+A@mail.gmail.com>
2018-10-01 17:38 ` Mark Hounschell
2018-10-02 22:09 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5bb4ab0-42f6-3fd1-006d-670a355e8702@infradead.org \
--to=rdunlap@infradead.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=lidza-louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=sehro@sehro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).