linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sehro rautenkranz <sehro@sehro.org>
Cc: Lidza Louina <lidza.louina@gmail.com>,
	Mark Hounschell <markh@compro.net>,
	driverdev-devel@linuxdriverproject.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: Fix Kconfig help header and text
Date: Tue, 25 Sep 2018 12:49:18 -0700	[thread overview]
Message-ID: <59f16a7e-4221-73e0-cf6e-3461717be318@infradead.org> (raw)
In-Reply-To: <20180925184623.GA16455@kroah.com>

On 9/25/18 11:46 AM, Greg Kroah-Hartman wrote:
> On Tue, Sep 25, 2018 at 10:22:24AM -0600, sehro rautenkranz wrote:
>> Replace Kconfig help header and text to match other modules. Issue found
>> my checkpatch.
>>
>> Spacing adjusted to match Documentation/process/coding-style.rst. Issue
>> reported by rdunlap@infradead.org. (try 2)
> 
> The "try 2" needs go to below the --- line.
> 
> Also, you need to properly version your patches so that I have a clue
> as to which is the "latest" one.
> 
>> Signed-off-by: sehro rautenkranz <sehro@sehro.org>
> 
> You forgot Randy's Reported-by.
> 
> Also, properly Capitalize your name.
> 
> v3?

and the help text is still not indented correctly:
use one tab + 2 spaces for help text.

-- 
~Randy

  reply	other threads:[~2018-09-25 19:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25  6:20 [PATCH] staging: dgnc: Fix Kconfig help header and text sehro rautenkranz
2018-09-25 15:34 ` Randy Dunlap
2018-09-25 15:53   ` sehro rautenkranz
2018-09-25 16:00     ` Randy Dunlap
2018-09-25 16:22       ` sehro rautenkranz
2018-09-25 18:46         ` Greg Kroah-Hartman
2018-09-25 19:49           ` Randy Dunlap [this message]
2018-09-25 23:41             ` [PATCH v3] " Sehro Rautenkranz
     [not found]               ` <CA+t4uCMAgpNtpdLfxNY_cmx7WONKOYjiaTBDGRNd+7H_GUdRAA@mail.gmail.com>
2018-10-01 12:09                 ` Mark Hounschell
     [not found]                   ` <CA+t4uCPFZSTjyN-Wd3ppOp-edAXfSSTTdT8uab+-E53=Htv9+A@mail.gmail.com>
2018-10-01 17:38                     ` Mark Hounschell
2018-10-02 22:09                     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59f16a7e-4221-73e0-cf6e-3461717be318@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@compro.net \
    --cc=sehro@sehro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).