Re: [RFC] Migrating net/sched to new module interface

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

Rusty Russell wrote:

> 2) It's bad enough to force the interfaces to change: at least the
>    primitive they are to use is one many of them are already using,
>    and is very simple to understand.

They are indeed simple, but only because it's impossible to implement
anything more complex.
An example: A "rmmod -w loop" will currently deadlock on a busy loop
module. Could you please explain, how it will be possible to force a
safe removal of the loop module?

> PS.  The *implementation* flaw in your scheme: someone starts using a
>      module as you try to deregister it.  Either you re-register the
>      module (ie. you can never unload security modules), or you leave
>      it half unloaded (even worse).

What is the problem with a half unloaded module? Only the module knows
which interfaces it can safely remove to prevent new users, afterwards
it only has to wait for remaining user to leave to complete the cleanup.
BTW this also solves nicely the module init race.

bye, Roman