From: Valentin Schneider <valentin.schneider@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>,
"Zengtao (B)" <prime.zeng@hisilicon.com>,
Morten Rasmussen <morten.rasmussen@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Linuxarm <linuxarm@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpu-topology: warn if NUMA configurations conflicts with lower layer
Date: Mon, 13 Jan 2020 15:15:28 +0000 [thread overview]
Message-ID: <3b389423-4bc7-0706-660f-dbddf8445abd@arm.com> (raw)
In-Reply-To: <1fbe4475-363d-e800-8295-a1591d5e52d9@arm.com>
On 13/01/2020 14:49, Dietmar Eggemann wrote:
> LGTM. This code detects the issue in cpu_coregroup_mask(), which is the
> the cpumask function of the sched domain MC level struct
> sched_domain_topology_level of ARM64's (and other archs)
> default_topology[].
> I wonder how x86 copes with such a config error?
> Maybe they do it inside their cpu_coregroup_mask()?
>
>
> We could move validate_topology_spans() into the existing
>
> for_each_cpu(i, cpu_map)
> for_each_sd_topology(tl)
>
> loop in build_sched_domains() saving some code?
>
[...]
Yeah that should work. Folks might want to gate it under SCHED_DEBUG, but
that's another discussion.
next prev parent reply other threads:[~2020-01-13 15:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 8:16 [PATCH] cpu-topology: warn if NUMA configurations conflicts with lower layer z00214469
2019-12-31 16:40 ` Sudeep Holla
2020-01-02 3:05 ` Zengtao (B)
2020-01-02 11:29 ` Sudeep Holla
2020-01-02 12:47 ` Zengtao (B)
2020-01-02 13:22 ` Valentin Schneider
2020-01-02 19:30 ` Dietmar Eggemann
2020-01-03 4:24 ` Zengtao (B)
2020-01-03 10:57 ` Valentin Schneider
2020-01-03 12:14 ` Valentin Schneider
2020-01-03 17:20 ` Dietmar Eggemann
2020-01-06 1:48 ` Zengtao (B)
2020-01-06 14:31 ` Dietmar Eggemann
2020-01-08 2:19 ` Zengtao (B)
2020-01-09 11:05 ` Morten Rasmussen
2020-01-09 12:07 ` Dietmar Eggemann
2020-01-06 1:52 ` Zengtao (B)
2020-01-03 11:40 ` Sudeep Holla
2020-01-06 1:37 ` Zengtao (B)
2020-01-09 10:43 ` Morten Rasmussen
2020-01-09 12:58 ` Zengtao (B)
2020-01-11 20:56 ` Valentin Schneider
2020-01-13 6:51 ` Zengtao (B)
2020-01-13 11:16 ` Valentin Schneider
2020-01-13 12:08 ` Zengtao (B)
2020-01-13 12:22 ` Dietmar Eggemann
2020-01-13 14:49 ` Dietmar Eggemann
2020-01-13 15:15 ` Valentin Schneider [this message]
2020-01-09 10:52 ` Morten Rasmussen
2020-01-12 13:22 ` Valentin Schneider
2020-01-13 13:22 ` Morten Rasmussen
2020-01-02 13:59 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b389423-4bc7-0706-660f-dbddf8445abd@arm.com \
--to=valentin.schneider@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=morten.rasmussen@arm.com \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).