From: Valentin Schneider <valentin.schneider@arm.com>
To: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: "Zengtao (B)" <prime.zeng@hisilicon.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Linuxarm <linuxarm@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpu-topology: warn if NUMA configurations conflicts with lower layer
Date: Sun, 12 Jan 2020 13:22:02 +0000 [thread overview]
Message-ID: <f973e77b-9c0a-6506-da97-f7a0ea1829fd@arm.com> (raw)
In-Reply-To: <20200109105228.GB10914@e105550-lin.cambridge.arm.com>
On 09/01/2020 10:52, Morten Rasmussen wrote:
>> AFAIA what matters here is memory controllers, less so LLCs. Cores within
>> a single die could have private LLCs and separate memory controllers, or
>> shared LLC and separate memory controllers.
>
> Don't confuse cache boundaries, packages and nodes :-)
>
> core_siblings are cpus in the same package and doesn't say anything
> about cache boundaries. It is not given that there is sched_domain that
> matches the core_sibling span.
>
> The MC sched_domain is supposed to match the LLC span which might
> different for core_siblings. So the about example should be valid for a
> NUMA-in-package system with one package containing two nodes.
>
Right, the point I was trying to make is that node boundaries can be pretty
much anything, so nodes can span over LLCs, or LLCs can span over nodes,
which is why we need checks such as the one in arch_topology() that lets us
build up a usable domain hierarchy (which cares about LLCs, at least at some
level).
> Morten
>
next prev parent reply other threads:[~2020-01-12 13:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 8:16 [PATCH] cpu-topology: warn if NUMA configurations conflicts with lower layer z00214469
2019-12-31 16:40 ` Sudeep Holla
2020-01-02 3:05 ` Zengtao (B)
2020-01-02 11:29 ` Sudeep Holla
2020-01-02 12:47 ` Zengtao (B)
2020-01-02 13:22 ` Valentin Schneider
2020-01-02 19:30 ` Dietmar Eggemann
2020-01-03 4:24 ` Zengtao (B)
2020-01-03 10:57 ` Valentin Schneider
2020-01-03 12:14 ` Valentin Schneider
2020-01-03 17:20 ` Dietmar Eggemann
2020-01-06 1:48 ` Zengtao (B)
2020-01-06 14:31 ` Dietmar Eggemann
2020-01-08 2:19 ` Zengtao (B)
2020-01-09 11:05 ` Morten Rasmussen
2020-01-09 12:07 ` Dietmar Eggemann
2020-01-06 1:52 ` Zengtao (B)
2020-01-03 11:40 ` Sudeep Holla
2020-01-06 1:37 ` Zengtao (B)
2020-01-09 10:43 ` Morten Rasmussen
2020-01-09 12:58 ` Zengtao (B)
2020-01-11 20:56 ` Valentin Schneider
2020-01-13 6:51 ` Zengtao (B)
2020-01-13 11:16 ` Valentin Schneider
2020-01-13 12:08 ` Zengtao (B)
2020-01-13 12:22 ` Dietmar Eggemann
2020-01-13 14:49 ` Dietmar Eggemann
2020-01-13 15:15 ` Valentin Schneider
2020-01-09 10:52 ` Morten Rasmussen
2020-01-12 13:22 ` Valentin Schneider [this message]
2020-01-13 13:22 ` Morten Rasmussen
2020-01-02 13:59 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f973e77b-9c0a-6506-da97-f7a0ea1829fd@arm.com \
--to=valentin.schneider@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=morten.rasmussen@arm.com \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).