* [PATCH 1/2] mailbox: mailbox-test: Fix module autoload
@ 2016-10-20 3:34 Javier Martinez Canillas
2016-10-20 3:34 ` [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration Javier Martinez Canillas
2016-10-24 9:10 ` [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Lee Jones
0 siblings, 2 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2016-10-20 3:34 UTC (permalink / raw)
To: linux-kernel; +Cc: Lee Jones, Javier Martinez Canillas, Jassi Brar
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/mailbox/mailbox-test.ko | grep alias
$
After this patch:
$ modinfo drivers/mailbox/mailbox-test.ko | grep alias
alias: of:N*T*Cmailbox-testC*
alias: of:N*T*Cmailbox-test
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mailbox/mailbox-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
index 9ca96e9db6bf..deb9c61aebb4 100644
--- a/drivers/mailbox/mailbox-test.c
+++ b/drivers/mailbox/mailbox-test.c
@@ -357,6 +357,7 @@ static const struct of_device_id mbox_test_match[] = {
{ .compatible = "mailbox-test" },
{},
};
+MODULE_DEVICE_TABLE(of, mbox_test_match);
static struct platform_driver mbox_test_driver = {
.driver = {
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration
2016-10-20 3:34 [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Javier Martinez Canillas
@ 2016-10-20 3:34 ` Javier Martinez Canillas
2016-10-24 9:11 ` Lee Jones
2016-10-24 9:10 ` [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Lee Jones
1 sibling, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2016-10-20 3:34 UTC (permalink / raw)
To: linux-kernel; +Cc: Lee Jones, Javier Martinez Canillas, Jassi Brar
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/mailbox/mailbox-sti.ko | grep alias
alias: platform:mailbox-sti
After this patch:
$ modinfo drivers/mailbox/mailbox-sti.ko | grep alias
alias: platform:mailbox-sti
alias: of:N*T*Cst,stih407-mailboxC*
alias: of:N*T*Cst,stih407-mailbox
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mailbox/mailbox-sti.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c
index a334db5c9f1c..41bcd339b68a 100644
--- a/drivers/mailbox/mailbox-sti.c
+++ b/drivers/mailbox/mailbox-sti.c
@@ -403,6 +403,7 @@ static const struct of_device_id sti_mailbox_match[] = {
},
{ }
};
+MODULE_DEVICE_TABLE(of, sti_mailbox_match);
static int sti_mbox_probe(struct platform_device *pdev)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mailbox: mailbox-test: Fix module autoload
2016-10-20 3:34 [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Javier Martinez Canillas
2016-10-20 3:34 ` [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration Javier Martinez Canillas
@ 2016-10-24 9:10 ` Lee Jones
2016-11-29 14:53 ` Javier Martinez Canillas
1 sibling, 1 reply; 5+ messages in thread
From: Lee Jones @ 2016-10-24 9:10 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, Jassi Brar
On Thu, 20 Oct 2016, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
> alias: of:N*T*Cmailbox-testC*
> alias: of:N*T*Cmailbox-test
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mailbox/mailbox-test.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
> index 9ca96e9db6bf..deb9c61aebb4 100644
> --- a/drivers/mailbox/mailbox-test.c
> +++ b/drivers/mailbox/mailbox-test.c
> @@ -357,6 +357,7 @@ static const struct of_device_id mbox_test_match[] = {
> { .compatible = "mailbox-test" },
> {},
> };
> +MODULE_DEVICE_TABLE(of, mbox_test_match);
>
> static struct platform_driver mbox_test_driver = {
> .driver = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration
2016-10-20 3:34 ` [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration Javier Martinez Canillas
@ 2016-10-24 9:11 ` Lee Jones
0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2016-10-24 9:11 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, Jassi Brar
On Thu, 20 Oct 2016, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mailbox/mailbox-sti.ko | grep alias
> alias: platform:mailbox-sti
>
> After this patch:
>
> $ modinfo drivers/mailbox/mailbox-sti.ko | grep alias
> alias: platform:mailbox-sti
> alias: of:N*T*Cst,stih407-mailboxC*
> alias: of:N*T*Cst,stih407-mailbox
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/mailbox/mailbox-sti.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c
> index a334db5c9f1c..41bcd339b68a 100644
> --- a/drivers/mailbox/mailbox-sti.c
> +++ b/drivers/mailbox/mailbox-sti.c
> @@ -403,6 +403,7 @@ static const struct of_device_id sti_mailbox_match[] = {
> },
> { }
> };
> +MODULE_DEVICE_TABLE(of, sti_mailbox_match);
>
> static int sti_mbox_probe(struct platform_device *pdev)
> {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mailbox: mailbox-test: Fix module autoload
2016-10-24 9:10 ` [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Lee Jones
@ 2016-11-29 14:53 ` Javier Martinez Canillas
0 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2016-11-29 14:53 UTC (permalink / raw)
To: Jassi Brar; +Cc: Lee Jones, linux-kernel
Hello Jessi,
On 10/24/2016 06:10 AM, Lee Jones wrote:
> On Thu, 20 Oct 2016, Javier Martinez Canillas wrote:
>
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
>> $
>>
>> After this patch:
>>
>> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
>> alias: of:N*T*Cmailbox-testC*
>> alias: of:N*T*Cmailbox-test
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>> drivers/mailbox/mailbox-test.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
Any comments about this patch and 2/2? Lee acked both patches but
I see that were never picked.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-29 14:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-20 3:34 [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Javier Martinez Canillas
2016-10-20 3:34 ` [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration Javier Martinez Canillas
2016-10-24 9:11 ` Lee Jones
2016-10-24 9:10 ` [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Lee Jones
2016-11-29 14:53 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).